Adrian Nistor created LUCENE-5041: ------------------------------------- Summary: wasted work in CheckIndex.checkIndex(List) Key: LUCENE-5041 URL: https://issues.apache.org/jira/browse/LUCENE-5041 Project: Lucene - Core Issue Type: Bug Components: core/index Affects Versions: 4.3 Environment: any Reporter: Adrian Nistor Priority: Minor Attachments: patch.diff
The problem appears in version 4.3.0 and in revision 1490286. I attached a two-line patch that fixes it. In method "CheckIndex.checkIndex(List<String>)", the loop over "onlySegments" should not be executed when "infoStream" is "null". When "infoStream" is "null" the loop produces no results. The patch just flips the order of the "if" and "for" statements. Method "collect" in class "MultiComparatorNonScoringCollector" has a similar loop (the last loop in the method over "comparators"), and this loop is not executed when "queueFull" is false, just like in the proposed patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org