[ 
https://issues.apache.org/jira/browse/SOLR-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe resolved SOLR-9995.
------------------------------
       Resolution: Fixed
         Assignee: Steve Rowe
    Fix Version/s: 7.1
                   master (8.0)
                   7.0

Resolving as Fixed, since all child issues are resolved.


> refactor / cleanup PointFields code and overall asumptions about numerics
> -------------------------------------------------------------------------
>
>                 Key: SOLR-9995
>                 URL: https://issues.apache.org/jira/browse/SOLR-9995
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Steve Rowe
>            Priority: Trivial
>              Labels: numeric-tries-to-points
>             Fix For: 7.0, master (8.0), 7.1
>
>
> Generalizing this issue to serve as a parent for small individual 
> improvements/cleanup/refactoring subtasks that can be made to various places 
> in the solr code where we deal with Points fields and other older types of 
> numeric fields.
> ----
> Original description...
> As Suggested by Adrien in 
> [SOLR-8396|https://issues.apache.org/jira/browse/SOLR-8396?focusedCommentId=15828365&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15828365]
> {quote}
> in the below change, it looks like the logic that you apply to point fields 
> would work in the general case and be as efficient?
> {code}
> +    if (ft.isPointField()) {
> +      for (String term : terms) {
> +        int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), 
> parsed.docs);
> +        res.add(term, count);
> +      }
> +    } else {
> +      for (String term : terms) {
> +        String internal = ft.toInternal(term);
> +        int count = searcher.numDocs(new TermQuery(new Term(field, 
> internal)), parsed.docs);
> +        res.add(term, count);
> +      }
>      }
> {code}
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to