[
https://issues.apache.org/jira/browse/LUCENE-8665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Ferenczi updated LUCENE-8665:
---------------------------------
Description:
Today TestBackwardsCompatibility can handle a single release at a time because
TestBackwardsCompatibility#testAllVersionsTested is lenient on the latest
version only (the one that is released). However and since we want to release
two versions simultaneously (7.7 and 8.0) this test is failing on branch_8x.
This means that we need to do one release at a time or add more leniency in the
test to handle this special case. We could for instance add something like:
{noformat}
// NORELEASE: we have two releases in progress (7.7.0 and 8.0.0) so we
could be missing
// 2 files, 1 for 7.7.0 and one for 8.0.0. This should be removed when
7.7.0 is released.
if (extraFiles.isEmpty() && missingFiles.size() == 2 &&
missingFiles.contains("7.7.0-cfs") && missingFiles.contains("8.0.0-cfs")) {
// success
return;
}
{noformat}
and remove the code when 7.7.0 is released ?
was:
Today TestBackwardsCompatibility can handle a single release at a time because
TestBackwardsCompatibility#testAllVersionsTested is lenient on the latest
version only (the one that is released). However and since we want to release
two versions simultaneously (7.7 and 8.0) this test is failing on branch_8x.
This means that we need to do one release at a time or add more leniency in the
test to handle this special case. We could for instance add something like:
{noformat}
// NORELEASE: we have two releases in progress (7.7.0 and 8.0.0) so we
could be missing
// 2 files, 1 for 7.7.0 and one for 8.0.0. This should be removed when
7.7.0 is released.
if (extraFiles.isEmpty() && missingFiles.size() == 2 &&
missingFiles.contains("7.7.0-cfs") && missingFiles.contains("8.0.0-cfs")) {
// success
return;
}
{noformat}
and remove the code when 7.6.0 is released ?
> Add temporary code in TestBackwardsCompatibility to handle two concurrent
> releases
> ----------------------------------------------------------------------------------
>
> Key: LUCENE-8665
> URL: https://issues.apache.org/jira/browse/LUCENE-8665
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Jim Ferenczi
> Priority: Major
>
> Today TestBackwardsCompatibility can handle a single release at a time
> because TestBackwardsCompatibility#testAllVersionsTested is lenient on the
> latest version only (the one that is released). However and since we want to
> release two versions simultaneously (7.7 and 8.0) this test is failing on
> branch_8x. This means that we need to do one release at a time or add more
> leniency in the test to handle this special case. We could for instance add
> something like:
> {noformat}
> // NORELEASE: we have two releases in progress (7.7.0 and 8.0.0) so we
> could be missing
> // 2 files, 1 for 7.7.0 and one for 8.0.0. This should be removed when
> 7.7.0 is released.
> if (extraFiles.isEmpty() && missingFiles.size() == 2 &&
> missingFiles.contains("7.7.0-cfs") && missingFiles.contains("8.0.0-cfs")) {
> // success
> return;
> }
> {noformat}
> and remove the code when 7.7.0 is released ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
