[ https://issues.apache.org/jira/browse/SOLR-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Gerlowski updated SOLR-8405: ---------------------------------- Attachment: SOLR-8405.patch Here's a patch which makes the change as recommended in the description. All tests pass. Running {{bin/solr start -e techproducts -Xoption}} will start the Solr process with the {{-Xoption}} flag, where before the script would've reported an error message from SolrCLI about an invalid argument. Two caveats with respect to this patch. 1.) The patch contains a small tweak to {{bin/solr/solr.in.cmd}} that I'm not sure how to test. My guess is that file is used on Windows, which I'm not setup to test. I could also be wrong about that, in which case I just don't know how to exercise it. I'd appreciate a double-check on the changes to that file, even though they're likely trivial. 2.) SolrCLI accepts/documents some options which could conflict with {{-X}} options. I'm thinking particularly of the {{-m} argument (specifies JVM memory for Solr). Should we continue to support these arguments, now that users can directly specify their own {{-X}} args? Or is it fine to let this collision occur if script users put themselves in this position? > bin/solr (and its cmd sibling) should pass thru -X options as it does with -D > ----------------------------------------------------------------------------- > > Key: SOLR-8405 > URL: https://issues.apache.org/jira/browse/SOLR-8405 > Project: Solr > Issue Type: Bug > Components: scripts and tools > Affects Versions: 5.0, 5.1, 5.2, 5.2.1, 5.3, 5.4 > Environment: all > Reporter: Timothy Potter > Priority: Minor > Attachments: SOLR-8405.patch > > > Currently the bin/solr scripts pass any options that being with -D on to the > JVM directly. It should to the same for -X vs. having to put -X inside of -a -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org