[
https://issues.apache.org/jira/browse/LUCENE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863384#action_12863384
]
Yonik Seeley commented on LUCENE-2438:
--
Looks good.
This is trunk, and currently
[
https://issues.apache.org/jira/browse/LUCENE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863414#action_12863414
]
Uwe Schindler commented on LUCENE-2438:
---
We should keep the issue open after the
[
https://issues.apache.org/jira/browse/LUCENE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863422#action_12863422
]
Yonik Seeley commented on LUCENE-2438:
--
Another issue is that it looks like some code
[
https://issues.apache.org/jira/browse/LUCENE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863433#action_12863433
]
Yonik Seeley commented on LUCENE-2438:
--
I've added javadoc that defines result.offset