[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872140#action_12872140
]
Uwe Schindler commented on LUCENE-2455:
---
Should we not add a 3.1 index (created with
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872149#action_12872149
]
Shai Erera commented on LUCENE-2455:
Yes! I'll add them and update the tests. Will
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872153#action_12872153
]
Shai Erera commented on LUCENE-2455:
Hmm ... I've created the indexes using the 3x
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872182#action_12872182
]
Shai Erera commented on LUCENE-2455:
Yes - after I updated my checkout and re-create
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871622#action_12871622
]
Shai Erera commented on LUCENE-2455:
Committed revision 948394 (3x).
Will now port
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871630#action_12871630
]
Uwe Schindler commented on LUCENE-2455:
---
Hi Shai,
I have seen this only lately. You
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871631#action_12871631
]
Uwe Schindler commented on LUCENE-2455:
---
I looked at the code, it simply tests trhat
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871639#action_12871639
]
Shai Erera commented on LUCENE-2455:
Ok I added the indexes from trunk (didn't know
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871641#action_12871641
]
Shai Erera commented on LUCENE-2455:
While porting the code to trunk, I've noticed
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871718#action_12871718
]
Michael McCandless commented on LUCENE-2455:
bq. So I think these can be
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871728#action_12871728
]
Shai Erera commented on LUCENE-2455:
Committed revision 948415 (copied the 3.0 indexes
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871075#action_12871075
]
Michael McCandless commented on LUCENE-2455:
Could you fix firstInt' to have a
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871109#action_12871109
]
Shai Erera commented on LUCENE-2455:
The only place I see firstInt is used perhaps
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871233#action_12871233
]
Michael McCandless commented on LUCENE-2455:
Patch looks good Shai! Thanks.
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870548#action_12870548
]
Michael McCandless commented on LUCENE-2455:
Patch looks great! So awesome
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870549#action_12870549
]
Michael McCandless commented on LUCENE-2455:
bq. Backwards support should be
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870688#action_12870688
]
Shai Erera commented on LUCENE-2455:
I'm not sure about the live migration, Mike.
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870743#action_12870743
]
Michael McCandless commented on LUCENE-2455:
bq. With that behind us, did
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870761#action_12870761
]
Shai Erera commented on LUCENE-2455:
I will document it in CHANGES under API section.
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12869563#action_12869563
]
Shai Erera commented on LUCENE-2455:
I've started to implement
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868198#action_12868198
]
Andrzej Bialecki commented on LUCENE-2455:
---
I understand - see the edited
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868221#action_12868221
]
Andrzej Bialecki commented on LUCENE-2455:
---
bq. So can't the PrunningReader run
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868277#action_12868277
]
Shai Erera commented on LUCENE-2455:
Ok let's keep addIndexes(IndexReader) around.
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12867870#action_12867870
]
Michael McCandless commented on LUCENE-2455:
bq. Question: if we've just added
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12867871#action_12867871
]
Shai Erera commented on LUCENE-2455:
bq. Also, you shouldn't call
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12867498#action_12867498
]
Shai Erera commented on LUCENE-2455:
While changing addIndexes(reader), I've noticed
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12867523#action_12867523
]
Michael McCandless commented on LUCENE-2455:
Patch looks good Shai! Only a
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12867793#action_12867793
]
Shai Erera commented on LUCENE-2455:
In fact, I've create newAddIndexes (just for the
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12866524#action_12866524
]
Michael McCandless commented on LUCENE-2455:
bq. But, why wouldn't they be
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12866539#action_12866539
]
Shai Erera commented on LUCENE-2455:
bq. Adding indexes using FilterIndexReader is
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12866118#action_12866118
]
Michael McCandless commented on LUCENE-2455:
bq. Remove optimize() call from
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12866245#action_12866245
]
Shai Erera commented on LUCENE-2455:
bq. You mean addIndexes(Directory..)?
Yes,
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12866302#action_12866302
]
Michael McCandless commented on LUCENE-2455:
I agree, addIndexes should be
[
https://issues.apache.org/jira/browse/LUCENE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12866444#action_12866444
]
Shai Erera commented on LUCENE-2455:
Ok. But since addIndexes(IR) is for IR extensions
34 matches
Mail list logo