[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429166#comment-13429166
]
Erik Hatcher commented on SOLR-1725:
bq. How do these tests pass under Ant?
Maybe this
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429176#comment-13429176
]
Uwe Schindler commented on SOLR-1725:
-
Hi, this is not a problem at all. OpenJDK on
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429178#comment-13429178
]
Steven Rowe commented on SOLR-1725:
---
Thanks Uwe, I'll add rhino to maven builds.
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429214#comment-13429214
]
Steven Rowe commented on SOLR-1725:
---
bq. OpenJDK on FreeBSD contains no scripting engine.
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429219#comment-13429219
]
Robert Muir commented on SOLR-1725:
---
{noformat}
[rcmuir@lucene /home/hudson/.ant/lib]$ ls
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429218#comment-13429218
]
Robert Muir commented on SOLR-1725:
---
I think they are added to ~hudson/.ant/lib ?
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429222#comment-13429222
]
Steven Rowe commented on SOLR-1725:
---
Thanks Robert, I see them now.
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429240#comment-13429240
]
Hoss Man commented on SOLR-1725:
I (think i) fixed the assumptions in these tests to
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429387#comment-13429387
]
Steven Rowe commented on SOLR-1725:
---
After Hoss's commits, both ASF Jenkins Maven jobs
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429458#comment-13429458
]
Uwe Schindler commented on SOLR-1725:
-
I think, this is all fine:
- Java 6 spec
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429468#comment-13429468
]
Hoss Man commented on SOLR-1725:
bq. Java 6 spec requires a JavaScript engine to be shipped
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429472#comment-13429472
]
Hoss Man commented on SOLR-1725:
{quote}
bq. I strongly -1 shipping with additional
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429487#comment-13429487
]
Uwe Schindler commented on SOLR-1725:
-
Hoss, you are right, it is not required that JS
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429528#comment-13429528
]
Uwe Schindler commented on SOLR-1725:
-
I opened SOLR-3716.
Script
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429585#comment-13429585
]
Steven Rowe commented on SOLR-1725:
---
On IRC, Uwe suggested adding the Rhino jars to
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428675#comment-13428675
]
Steven Rowe commented on SOLR-1725:
---
bq. Maybe something mentioned here
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428018#comment-13428018
]
Erik Hatcher commented on SOLR-1725:
bq. The tests committed here 3 weeks ago have
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427840#comment-13427840
]
Steven Rowe commented on SOLR-1725:
---
The tests committed here 3 weeks ago have never
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424263#comment-13424263
]
Erik Hatcher commented on SOLR-1725:
Committed an example script/configuration to trunk
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413958#comment-13413958
]
Mikhail Khludnev commented on SOLR-1725:
Hoss,
Congrats! Btw, have you seen one
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413081#comment-13413081
]
Erik Hatcher commented on SOLR-1725:
bq. i plan to cmmit backport to 4x in the next 24
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405934#comment-13405934
]
Erik Hatcher commented on SOLR-1725:
bq. I would rather people have to write a few
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405936#comment-13405936
]
Erik Hatcher commented on SOLR-1725:
Do we really need to support multiple scripts
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405962#comment-13405962
]
Lance Norskog commented on SOLR-1725:
-
What if I have a main file and a library file?
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405974#comment-13405974
]
David Smiley commented on SOLR-1725:
+1 to Erik's proposal of streamlining the common
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406247#comment-13406247
]
Hoss Man commented on SOLR-1725:
bq. I think this just demands that we implement an
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405331#comment-13405331
]
Erik Hatcher commented on SOLR-1725:
Hoss - I've been following along. Well done Hoss
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405337#comment-13405337
]
Erik Hatcher commented on SOLR-1725:
bq. Let's start some wiki documentation on this
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405338#comment-13405338
]
Erik Hatcher commented on SOLR-1725:
Hoss - in StatelessScriptUpdateProcessorFactory,
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405416#comment-13405416
]
Erik Hatcher commented on SOLR-1725:
I'm not fond of a script having to implement all
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403838#comment-13403838
]
Robert Muir commented on SOLR-1725:
---
{quote}
fixed InputStreamReader to use UTF-8
{quote}
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403841#comment-13403841
]
Robert Muir commented on SOLR-1725:
---
We do have sugar for this already actually:
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402743#comment-13402743
]
Hoss Man commented on SOLR-1725:
bq. My comment above still stands: Another TODO is to get
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295512#comment-13295512
]
Lance Norskog commented on SOLR-1725:
-
bq.I simply added jruby.jar and jython.jar to my
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295882#comment-13295882
]
Erik Hatcher commented on SOLR-1725:
bq. Doesn't the first comment answer the second?
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295921#comment-13295921
]
Lance Norskog commented on SOLR-1725:
-
So, parking them into solr.home/lib or
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295974#comment-13295974
]
Erik Hatcher commented on SOLR-1725:
bq. So, parking them into solr.home/lib or
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279545#comment-13279545
]
Erik Hatcher commented on SOLR-1725:
With the latest patch, you can implement an update
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279547#comment-13279547
]
Erik Hatcher commented on SOLR-1725:
Is there really a need for multiple scripts
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279549#comment-13279549
]
Erik Hatcher commented on SOLR-1725:
Just FYI, with the current patch, I've gotten the
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279551#comment-13279551
]
Erik Hatcher commented on SOLR-1725:
Another TODO is to get this to work with a
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279010#comment-13279010
]
Erik Hatcher commented on SOLR-1725:
The latest patch also refactors the test case a
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278118#comment-13278118
]
Erik Hatcher commented on SOLR-1725:
I'm picking this much needed issue up. I've
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278257#comment-13278257
]
Andrzej Bialecki commented on SOLR-1725:
-
Erik, good stuff, very much needed!
My
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13061823#comment-13061823
]
Bill Bell commented on SOLR-1725:
-
Is there a reason why this is not committed. It seems
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13061838#comment-13061838
]
Simon Willnauer commented on SOLR-1725:
---
bq. Is there a reason why this is not
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007627#comment-13007627
]
Grant Ingersoll commented on SOLR-1725:
---
bq. As time passes, the case for moving to
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006284#comment-13006284
]
David Smiley commented on SOLR-1725:
This capability is awesome, just as it's DIH
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805500#action_12805500
]
Jan Høydahl commented on SOLR-1725:
---
It looks logical and nice.
However, I'm leaning
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805532#action_12805532
]
Yonik Seeley commented on SOLR-1725:
Cool feature!
Performance:
- It looks like
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805612#action_12805612
]
Uri Boness commented on SOLR-1725:
--
{quote}
Performance:
It looks like scripts are read
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805672#action_12805672
]
Uri Boness commented on SOLR-1725:
--
Been looking more into it and I think there's a nice
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805678#action_12805678
]
Yonik Seeley commented on SOLR-1725:
As you pointed out, Java5 is EOL'd already and
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805691#action_12805691
]
Uri Boness commented on SOLR-1725:
--
Well then... I just hope others will not shed tears as
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805051#action_12805051
]
Jan Høydahl commented on SOLR-1725:
---
Lance, what do you mean by DIH language?
In my
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805235#action_12805235
]
Uri Boness commented on SOLR-1725:
--
Lance, I lost you a bit as well.
bq. Uri, I'd prefer
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805247#action_12805247
]
Hoss Man commented on SOLR-1725:
Some random comments/questions from the peanut gallery...
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805254#action_12805254
]
Uri Boness commented on SOLR-1725:
--
bq. 1) what is the value add in making
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804725#action_12804725
]
Lance Norskog commented on SOLR-1725:
-
This is growing into the DataImportHandler :)
Is
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804092#action_12804092
]
Uri Boness commented on SOLR-1725:
--
If we move this to the contrib. we'll need to extract
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804093#action_12804093
]
Jan Høydahl commented on SOLR-1725:
---
This is very much wanted!
Would it make more sense
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804094#action_12804094
]
Uri Boness commented on SOLR-1725:
--
bq. Would it make more sense to execute the scripts in
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804106#action_12804106
]
Chris A. Mattmann commented on SOLR-1725:
-
oh and one other thing -- I _really_ like
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804105#action_12804105
]
Chris A. Mattmann commented on SOLR-1725:
-
Is there any reason for SOLR _not_ to
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804114#action_12804114
]
Uri Boness commented on SOLR-1725:
--
bq. oh and one other thing - I really like this patch,
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802496#action_12802496
]
Uri Boness commented on SOLR-1725:
--
The DIH ScriptTransformer can really be cleaned up
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802607#action_12802607
]
Mark Miller commented on SOLR-1725:
---
We might want to think about making this a contrib?
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801971#action_12801971
]
Mark Miller commented on SOLR-1725:
---
This is a great idea.
bq. This patch also introduces
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801983#action_12801983
]
Uri Boness commented on SOLR-1725:
--
bq. What about the existing ResourceLoaderAware?
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801988#action_12801988
]
Uri Boness commented on SOLR-1725:
--
Is there any reason for currently limiting the classes
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801991#action_12801991
]
Mark Miller commented on SOLR-1725:
---
I believe its somewhat arbitrary based on what makes
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801994#action_12801994
]
Uri Boness commented on SOLR-1725:
--
Right... ok... I'll add another class to this list (I
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802001#action_12802001
]
Uri Boness commented on SOLR-1725:
--
Thanks for the reference
Script based
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802022#action_12802022
]
Uri Boness commented on SOLR-1725:
--
Yes, it depends on Java 6. I guess the concern is
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802024#action_12802024
]
Uri Boness commented on SOLR-1725:
--
Sorry... of course it matters for the build :-)
[
https://issues.apache.org/jira/browse/SOLR-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802100#action_12802100
]
Noble Paul commented on SOLR-1725:
--
Why are we limiting this to javascript . Why can't
76 matches
Mail list logo
