[jira] [Commented] (LUCENE-3193) TwoPhaseCommit interface

2011-06-13 Thread Michael McCandless (JIRA)
! TwoPhaseCommit interface Key: LUCENE-3193 URL: https://issues.apache.org/jira/browse/LUCENE-3193 Project: Lucene - Java Issue Type: New Feature Components: core/index Reporter: Shai Erera

[jira] [Resolved] (LUCENE-3193) TwoPhaseCommit interface

2011-06-13 Thread Shai Erera (JIRA)
). TwoPhaseCommit interface Key: LUCENE-3193 URL: https://issues.apache.org/jira/browse/LUCENE-3193 Project: Lucene - Java Issue Type: New Feature Components: core/index Reporter: Shai Erera

[jira] [Commented] (LUCENE-3193) TwoPhaseCommit interface

2011-06-12 Thread Michael McCandless (JIRA)
won't do this correctly -- rollback will be a no-op in this case since it rolls back to the last successful commit. This is actually correctable, but it requires some more work to properly wrap the IndexWriter. TwoPhaseCommit interface Key: LUCENE-3193

[jira] [Commented] (LUCENE-3193) TwoPhaseCommit interface

2011-06-12 Thread Shai Erera (JIRA)
commit() was successfully executed may be a no-op. I put it on execute because I think it is more related to the tool than TPC.rollback() definition. TwoPhaseCommit interface Key: LUCENE-3193 URL: https://issues.apache.org/jira/browse

[jira] [Commented] (LUCENE-3193) TwoPhaseCommit interface

2011-06-12 Thread Michael McCandless (JIRA)
. But: perhaps a different exception should be thrown if there is a problem in the commit() loop vs the prepareCommit() loop? This way caller can differentiate this case? TwoPhaseCommit interface Key: LUCENE-3193 URL: https

[jira] [Commented] (LUCENE-3193) TwoPhaseCommit interface

2011-06-12 Thread Shai Erera (JIRA)
IOE for convenience (in case someone does not want to differentiate the two, it's easier to handle both cases in one catch block). I'll add these and upload a new patch by tomorrow. TwoPhaseCommit interface Key: LUCENE-3193 URL: https

[jira] [Updated] (LUCENE-3193) TwoPhaseCommit interface

2011-06-12 Thread Shai Erera (JIRA)
TPCTool into its own class, which now encapsulates the new exceptions + wrapper. Marked it @experimental too. I think this is ready for commit. TwoPhaseCommit interface Key: LUCENE-3193 URL: https://issues.apache.org/jira/browse

A TwoPhaseCommit interface

2011-06-11 Thread Shai Erera
Hi I wrote a TwoPhaseCommit interface which declares the methods necessary to implement a 2-phase commit algorithm: * prepareCommit() * commit() * rollback() The prepare/commit ones have variants that take a (MapString,String commitData) following the ones we have in IndexWriter. I also wrote

Re: A TwoPhaseCommit interface

2011-06-11 Thread Michael McCandless
This sounds great! Mike McCandless http://blog.mikemccandless.com On Sat, Jun 11, 2011 at 7:28 AM, Shai Erera ser...@gmail.com wrote: Hi I wrote a TwoPhaseCommit interface which declares the methods necessary to implement a 2-phase commit algorithm: * prepareCommit() * commit

[jira] [Created] (LUCENE-3193) TwoPhaseCommit interface

2011-06-11 Thread Shai Erera (JIRA)
TwoPhaseCommit interface Key: LUCENE-3193 URL: https://issues.apache.org/jira/browse/LUCENE-3193 Project: Lucene - Java Issue Type: New Feature Components: core/index Reporter: Shai Erera

Re: A TwoPhaseCommit interface

2011-06-11 Thread Shai Erera
a TwoPhaseCommit interface which declares the methods necessary to implement a 2-phase commit algorithm: * prepareCommit() * commit() * rollback() The prepare/commit ones have variants that take a (MapString,String commitData) following the ones we have in IndexWriter. I also wrote

[jira] [Updated] (LUCENE-3193) TwoPhaseCommit interface

2011-06-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-3193: --- Attachment: LUCENE-3193.patch Patch introduces: * TwoPhaseCommit interface * TPCTool (inner to TPC

[jira] [Issue Comment Edited] (LUCENE-3193) TwoPhaseCommit interface

2011-06-11 Thread Shai Erera (JIRA)
: -- Patch introduces: * TwoPhaseCommit interface + test * TPCTool (inner to TPC interface) for running a 2-phase commit algorithm * TPCWrapper, for running TPCTool w/ commitData * Modify IW to impl TPC * Add CHANGES entry (under the 3.x section). TPCWrapper is just a convenience class for passing

Re: A TwoPhaseCommit interface

2011-06-11 Thread Simon Willnauer
On Sat, Jun 11, 2011 at 2:00 PM, Michael McCandless luc...@mikemccandless.com wrote: This sounds great! +1 Mike McCandless http://blog.mikemccandless.com On Sat, Jun 11, 2011 at 7:28 AM, Shai Erera ser...@gmail.com wrote: Hi I wrote a TwoPhaseCommit interface which declares the methods

[jira] [Commented] (LUCENE-3193) TwoPhaseCommit interface

2011-06-11 Thread Shai Erera (JIRA)
appreciate a review of the definitions plus TPCTool impl. I will give it a couple of days before I commit. We can always fix issues later. TwoPhaseCommit interface Key: LUCENE-3193 URL: https://issues.apache.org/jira/browse/LUCENE-3193