RE: Approach towards solving split package issues?

2020-11-30 Thread Uwe Schindler
grating-serviceloader-java-9- > module-system/ > > > > I am not sure if JDEPS figures this out automatically! > > > > Uwe > > > > - > > Uwe Schindler > > Achterdiek 19, D-28357 Bremen > > https://www.thetaphi.de > > eMail: u...@thetaphi.

Re: Approach towards solving split package issues?

2020-11-30 Thread Dawid Weiss
we > > - > Uwe Schindler > Achterdiek 19, D-28357 Bremen > https://www.thetaphi.de > eMail: u...@thetaphi.de > > > -Original Message- > > From: Dawid Weiss > > Sent: Saturday, November 28, 2020 9:52 PM > > To: Lucene Dev > > Subje

RE: Approach towards solving split package issues?

2020-11-30 Thread Uwe Schindler
lly! Uwe - Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Dawid Weiss > Sent: Saturday, November 28, 2020 9:52 PM > To: Lucene Dev > Subject: Re: Approach towards solving split package issues

Re: Approach towards solving split package issues?

2020-11-28 Thread Dawid Weiss
fore, you can see what >> >> >>>>>>>>>> changes will be needed for analyzers-common (and core). >> >> >>>>>>>>>> >> >> >>>>>>>>>> >> >> >>>>>>>>>> 2020年9

Re: Approach towards solving split package issues?

2020-11-28 Thread Tomoko Uchida
>>>>>> are required for that, while most of our analyzers and so > on are in a > >> >>>>>>>>>>> separate analysis module. Perhaps we will need to move some > basic > >> >>>>>>>>>>&

Re: Approach towards solving split package issues?

2020-11-26 Thread Dawid Weiss
system with core only. However some basic analysis >> >>>>>>>>>>> tools >> >>>>>>>>>>> are required for that, while most of our analyzers and so on are >> >>>>>>>>>>>

Re: Approach towards solving split package issues?

2020-11-25 Thread Tomoko Uchida
all > >>>>>>>>>>> the analysis code into the analysis module and acknowledge > that it is > >>>>>>>>>>> a fundamental dependency (more essential than core, really). > >>>>>>>&g

Re: Approach towards solving split package issues?

2020-11-11 Thread Dawid Weiss
>>>> analyzers out of com.amazon.lucene.analysis? Or the reverse - move >>>>>>>>>>> all >>>>>>>>>>> the analysis code into the analysis module and acknowledge that it >>>>>>>>>>> is >

Re: Approach towards solving split package issues?

2020-11-11 Thread Tomoko Uchida
ore, really). >>>>>>>>>> >>>>>>>>>> On Tue, Sep 1, 2020 at 8:26 AM Tomoko Uchida >>>>>>>>>> wrote: >>>>>>>>>> > >>>>>>>>>> > yes, Jigsaw was on my

Re: Approach towards solving split package issues?

2020-11-05 Thread Tomoko Uchida
gt;>> > >>>>>>>>> > yes, Jigsaw was on my mind too... >>>>>>>>> > >>>>>>>>> > > why not go ahead and try to clean it up right away? >>>>>>>>> > >>>

Re: Approach towards solving split package issues?

2020-10-24 Thread Tomoko Uchida
a strong +1 to clean this up! >>>>>>>> > >>>>>>>> > OK, maybe I should open two issues, one for Lucene and one for >>>>>>>> Solr, and link existing wip issues to them. >>>>>>>> > Once we start it, these will be blockers for 9.0.0

Re: Approach towards solving split package issues?

2020-10-17 Thread Tomoko Uchida
he changes or >>>>>>> technical obstacles). Are there any objections or comments? >>>>>>> > >>>>>>> > >>>>>>> > 2020年9月1日(火) 19:34 Uwe Schindler : >>>>>>> >> >>>>>

Re: Approach towards solving split package issues?

2020-09-03 Thread Tomoko Uchida
ssue is that split packages make migrating to the >>>>>> Java 9 module system impossible. It's not allowed to have same package >>>>>> name >>>>>> (with classes) in different JAR files. >>>>>> >&g

Re: Approach towards solving split package issues?

2020-09-02 Thread Tomoko Uchida
Java >>>>> 9 module system impossible. It's not allowed to have same package name >>>>> (with classes) in different JAR files. >>>>> >> >>>>> >> Some of those require to open up visibility of classes. Some split >>>>&

Re: Approach towards solving split package issues?

2020-09-01 Thread Gus Heck
's not allowed to have same package name >>>> (with classes) in different JAR files. >>>> >> >>>> >> Some of those require to open up visibility of classes. Some split >>>> packages issues were done because of package privat

Re: Approach towards solving split package issues?

2020-09-01 Thread Adrien Grand
fects the test framework, although this >>> is not such a big deal (I would exclude that for now), because you would >>> never run UNIT tests inside a module system, only integration tests. >>> >> >>> >> So a strong +1 to clean this up! &

Re: Approach towards solving split package issues?

2020-09-01 Thread Tomoko Uchida
>> is not such a big deal (I would exclude that for now), because you would >> never run UNIT tests inside a module system, only integration tests. >> >> >> >> So a strong +1 to clean this up! >> >> Uwe >> >> >> >> - >> >>

Re: Approach towards solving split package issues?

2020-09-01 Thread Tomoko Uchida
lude that for now), because you would > never run UNIT tests inside a module system, only integration tests. > >> > >> So a strong +1 to clean this up! > >> Uwe > >> > >> - > >> Uwe Schindler > >> Achterdiek 19, D-28357 Breme

Re: Approach towards solving split package issues?

2020-09-01 Thread Michael Sokolov
ever >> run UNIT tests inside a module system, only integration tests. >> >> So a strong +1 to clean this up! >> Uwe >> >> - >> Uwe Schindler >> Achterdiek 19, D-28357 Bremen >> https://www.thetaphi.de >> eMail: u...@thetaphi.de >> >

Re: Approach towards solving split package issues?

2020-09-01 Thread Tomoko Uchida
//www.thetaphi.de > eMail: u...@thetaphi.de > > > -Original Message- > > From: Dawid Weiss > > Sent: Tuesday, September 1, 2020 9:22 AM > > To: Lucene Dev > > Subject: Re: Approach towards solving split package issues? > > > > This is a big

RE: Approach towards solving split package issues?

2020-09-01 Thread Uwe Schindler
Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Dawid Weiss > Sent: Tuesday, September 1, 2020 9:22 AM > To: Lucene Dev > Subject: Re: Approach towards solving split package issues? > > This is a

Re: Approach towards solving split package issues?

2020-09-01 Thread Dawid Weiss
This is a big headache for many things. I wouldn't mind doing this even for 9x. This is a major release, why not go ahead and try to clean it up right away? Dawid On Mon, Aug 31, 2020 at 11:50 PM Tomoko Uchida wrote: > > Hello devs, > > we have lots of package name conflicts (shared package

Re: Approach towards solving split package issues?

2020-08-31 Thread Alexandre Rafalovitch
It was causing issues when I was building solr start resource website too. So +1 on sorting it out. Regards, Alex. On Mon., Aug. 31, 2020, 5:50 p.m. Tomoko Uchida, < tomoko.uchida.1...@gmail.com> wrote: > Hello devs, > > we have lots of package name conflicts (shared package names) between

Approach towards solving split package issues?

2020-08-31 Thread Tomoko Uchida
Hello devs, we have lots of package name conflicts (shared package names) between modules in the Lucene/Solr source tree. It is not only annoying for devs/users but also indeed bad practice since Java 9 (according to my understanding), and we already have some problems with Javadocs due to these