Re: Do we run findbugs or any other static code analysis tool as part of the build process?

2017-01-17 Thread Pushkar Raste
Thanks David. I will try to fix as many errors as possible. It also seems like we do have some findbugs configuration in build.xml, I will see if I could get it working. On Jan 16, 2017 11:48 AM, "David Smiley" wrote: > See https://issues.apache.org/jira/browse/LUCENE-3973 Perhaps you care

Re: Do we run findbugs or any other static code analysis tool as part of the build process?

2017-01-16 Thread David Smiley
See https://issues.apache.org/jira/browse/LUCENE-3973 Perhaps you care to revive the issue. I really look forward to static analysis checks. On Sat, Jan 14, 2017 at 10:19 PM Pushkar Raste wrote: > Hi, > I saw a couple concerning bugs in the code like > >- comparing String, Integer, Float a

Do we run findbugs or any other static code analysis tool as part of the build process?

2017-01-14 Thread Pushkar Raste
Hi, I saw a couple concerning bugs in the code like - comparing String, Integer, Float and objects of other wrapper types using == instead of .equals() method. - Accessing methods on potentially null reference. I ran findbugs on the code base and found a lot of other errors as well. I am