Make IndexingChain and friends protected?

2014-03-07 Thread Michael Busch
Hi All, At Twitter we're using customized IndexingChains and also extend a lot of abstract classes like e.g. TermsHashConsumer. Most of these classes are currently package-private, because they were always considered expert APIs. I was wondering if we could switch from package-private to

Re: Make IndexingChain and friends protected?

2014-03-07 Thread Robert Muir
if the change can mostly just expose the indexing chain and related abstract classe so that its properly pluggable, yet passes our documentation-lint task without unravelling the whole thing and making some of the crazier impl stuff public, I think it could be a change for the better overall. On

Re: Make IndexingChain and friends protected?

2014-03-07 Thread Michael McCandless
+1 Mike McCandless http://blog.mikemccandless.com On Fri, Mar 7, 2014 at 2:39 PM, Robert Muir rcm...@gmail.com wrote: if the change can mostly just expose the indexing chain and related abstract classe so that its properly pluggable, yet passes our documentation-lint task without

Re: Make IndexingChain and friends protected?

2014-03-07 Thread Michael Busch
Sounds good. I'll work on a patch. On 3/7/14 1:05 PM, Michael McCandless wrote: +1 Mike McCandless http://blog.mikemccandless.com On Fri, Mar 7, 2014 at 2:39 PM, Robert Muir rcm...@gmail.com wrote: if the change can mostly just expose the indexing chain and related abstract classe so that