Re: New branch and feature freeze for Lucene/Solr 8.4.0

Hi Kevin, If you don't mind waiting a bit, that will make things easier. Otherwise we'd need to add the 8.4.1 version to the changelog for this change, and this would be in the way of a new RC, would we need to do another one. On Fri, Dec 20, 2019 at 5:24 AM Kevin Risden wrote: > Adrien -

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Adrien - there is a bug fix for Solr and TLS clientAuth - https://issues.apache.org/jira/browse/SOLR-14106. Based on the comments there don't think its required to respin 8.4.0. Is it ok to commit to branch_8_4 in case there is a need for a respin so it gets picked up? Otherwise I would expect it

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Go ahead Cassandra, I have built already, I'm now uploading the artifacts. On Tue, Dec 17, 2019 at 4:39 PM Cassandra Targett wrote: > I’m going to have a few commits coming in to branch_8_4 today for the Ref > Guide - I’m assuming as usual it’s OK for me to go ahead but if you want me > to hold

Re: New branch and feature freeze for Lucene/Solr 8.4.0

I’m going to have a few commits coming in to branch_8_4 today for the Ref Guide - I’m assuming as usual it’s OK for me to go ahead but if you want me to hold for a short time while you’re building or whatever, I will. On Dec 16, 2019, 9:35 AM -0600, Adrien Grand , wrote: > Awesome, thanks Ishan.

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Awesome, thanks Ishan. On Mon, Dec 16, 2019 at 4:14 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Adrien, I've pushed a fix for that issue. The failure was probably due > to usual flakiness, but hopefully you won't see the exception for that > test that Dawid reported. > I don't

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Adrien, I've pushed a fix for that issue. The failure was probably due to usual flakiness, but hopefully you won't see the exception for that test that Dawid reported. I don't think it should be a blocker anymore (the other problem is that a test is trying to write data to source tree; I think

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Could someone look at https://issues.apache.org/jira/browse/SOLR-14096 which Dawid just opened? It looks to me like it should be a blocker? On Mon, Dec 16, 2019 at 1:55 PM Adrien Grand wrote: > I have to rebuild because of SOLR-14094, so I'll include SOLR-14087 too. > > On Mon, Dec 16, 2019 at

Re: New branch and feature freeze for Lucene/Solr 8.4.0

I have to rebuild because of SOLR-14094, so I'll include SOLR-14087 too. On Mon, Dec 16, 2019 at 1:52 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Hi Adrien, > I reverted one of the changes in SOLR-14087, and backported to 8.4 > branch. Apologies for the last moment change. > If

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Hi Adrien, I reverted one of the changes in SOLR-14087, and backported to 8.4 branch. Apologies for the last moment change. If RC1 goes out without this change, no worries and we'll deal with it later. Thanks and regards, Ishan On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya wrote: > > Hi

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Hi Adrien, Let's push it to 8.5. +1 to proceed for RC1. Thanks, Ishan On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, wrote: > Among the various JIRAs mentioned above, it looks like only > https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please > let me know if there are other JIRAs

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Among the various JIRAs mentioned above, it looks like only https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please let me know if there are other JIRAs that you are thinking of getting it that have not been pushed yet, but in general I'd like to start pushing changes to 8.5

Re: New branch and feature freeze for Lucene/Solr 8.4.0

I plan to commit the following as well. It's just a precautionery measure to avoid any future exploits https://github.com/apache/lucene-solr/pull/1085 On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya wrote: > > I've added a few critical fixes for SOLR-13662 to the branch. I tested > them

Re: New branch and feature freeze for Lucene/Solr 8.4.0

I've added a few critical fixes for SOLR-13662 to the branch. I tested them thoroughly and got reviews for the fixes from Jan, Noble and Eduardo. On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand wrote: > > Hi Kevin, > > I'll defer to your judgement regarding whether this is safe to get in 8.4. > >

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Hi Kevin, I'll defer to your judgement regarding whether this is safe to get in 8.4. Le sam. 14 déc. 2019 à 21:00, Kevin Risden a écrit : > Tim found SOLR-14086 which looks like a test only dependency leaking into > compile caused by SOLR-14033. I put a patch up. I won't get to get it until >

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Go ahead Jan. Le sam. 14 déc. 2019 à 20:09, Jan Høydahl a écrit : > Deprecation of DIH is ready for review > https://issues.apache.org/jira/browse/SOLR-14066 > One code change which is a WARN log at startup, other changes are > documentation. > > Low risk and we’d like to deprecate sooner

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Tim found SOLR-14086 which looks like a test only dependency leaking into compile caused by SOLR-14033. I put a patch up. I won't get to get it until later tonight or tomorrow ~24hrs from now. This causes any Solr Tika usage with 7z or a few other compressed file types (depends if they use

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Deprecation of DIH is ready for review https://issues.apache.org/jira/browse/SOLR-14066 One code change which is a WARN log at startup, other changes are documentation. Low risk and we’d like to deprecate sooner rather than later in 8.x. Your

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Let's get that one in as well, thanks Yonik. On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley wrote: > Heads up on https://issues.apache.org/jira/browse/SOLR-14079 > Bad bug (autoscale triggers use async, so splitByPrefix does not work.) . > The fix is super simple and very low risk since it's

Re: New branch and feature freeze for Lucene/Solr 8.4.0

t; I enabled the Jenkins jobs on Policeman Jenkins. > >>> > >>> > >>> > >>> Uwe > >>> > >>> > >>> > >>> - > >>> > >>> Uwe Schindler > >>> > >>> Achterdiek

Re: New branch and feature freeze for Lucene/Solr 8.4.0

; >>> > >>> > >>> > >>> - > >>> > >>> Uwe Schindler > >>> > >>> Achterdiek 19, D-28357 Bremen > >>> > >>> https://www.thetaphi.de > >>> > >>> eMail: u...@th

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Heads up on https://issues.apache.org/jira/browse/SOLR-14079 Bad bug (autoscale triggers use async, so splitByPrefix does not work.) . The fix is super simple and very low risk since it's encapsulated within the block only used when splitByPrefix=true. -Yonik

Re: New branch and feature freeze for Lucene/Solr 8.4.0

Policeman Jenkins. >>> >>> >>> >>> Uwe >>> >>> >>> >>> - >>> >>> Uwe Schindler >>> >>> Achterdiek 19, D-28357 Bremen >>> >>> https://www.thetaphi.de >>> >>> eM

Re: New branch and feature freeze for Lucene/Solr 8.4.0

8357 Bremen >> >> https://www.thetaphi.de <https://www.thetaphi.de/> >> eMail: u...@thetaphi.de <mailto:u...@thetaphi.de> >> >> >> From: Adrien Grand mailto:jpou...@gmail.com>> >> Sent: Thursday, December 12, 2019 9:56 AM >> T

Re: New branch and feature freeze for Lucene/Solr 8.4.0

>> https://www.thetaphi.de >> >> eMail: u...@thetaphi.de >> >> >> >> *From:* Adrien Grand >> *Sent:* Thursday, December 12, 2019 9:56 AM >> *To:* Lucene Dev >> *Subject:* New branch and feature freeze for Lucene/Solr 8.4.0 >&

Re: New branch and feature freeze for Lucene/Solr 8.4.0

--- > > Uwe Schindler > > Achterdiek 19, D-28357 Bremen > > https://www.thetaphi.de <https://www.thetaphi.de/> > eMail: u...@thetaphi.de <mailto:u...@thetaphi.de> > > > From: Adrien Grand mailto:jpou...@gmail.com>> > Sent: Thursday, Decemb

Re: New branch and feature freeze for Lucene/Solr 8.4.0

.@thetaphi.de > > > > *From:* Adrien Grand > *Sent:* Thursday, December 12, 2019 9:56 AM > *To:* Lucene Dev > *Subject:* New branch and feature freeze for Lucene/Solr 8.4.0 > > > > NOTICE: > > Branch branch_8_4 has been cut and versions updated to 8.5 on st

RE: New branch and feature freeze for Lucene/Solr 8.4.0

branch and feature freeze for Lucene/Solr 8.4.0 NOTICE: Branch branch_8_4 has been cut and versions updated to 8.5 on stable branch. Please observe the normal rules: * No new features may be committed to the branch. * Documentation patches, build patches and serious bug fixes may be com

New branch and feature freeze for Lucene/Solr 8.4.0

NOTICE: Branch branch_8_4 has been cut and versions updated to 8.5 on stable branch. Please observe the normal rules: * No new features may be committed to the branch. * Documentation patches, build patches and serious bug fixes may be committed to the branch. However, you should submit all