Re: maven build issues with non-numeric custom version

2014-01-29 Thread Steve Rowe
Ryan, Shikhar, Uwe: thanks for the feedback. I committed the fix on LUCENE-5420, and all of the following worked for me (no build errors) and ‘mvn -DskipTests install’ also worked for each from the resulting POMs under maven-build/: ant -Dversion=4.7.r1562172M get-maven-poms ant -Ddev.version

Re: maven build issues with non-numeric custom version

2014-01-29 Thread Steve Rowe
See https://issues.apache.org/jira/browse/LUCENE-5420 - I put up a patch that fixes the issue for me. - Steve On Jan 28, 2014, at 3:10 PM, Steve Rowe wrote: > Ryan, I'll take a look today. - Steve > > On Jan 28, 2014 2:39 PM, "Ryan McKinley" wrote: > The real version number i was trying was:

Re: maven build issues with non-numeric custom version

2014-01-28 Thread Steve Rowe
Ryan, I'll take a look today. - Steve On Jan 28, 2014 2:39 PM, "Ryan McKinley" wrote: > The real version number i was trying was: > -Dversion=4.7.r1562172M > > essentially a standard lucene build with a few chances. Having the > non-numbers in the version make it fail > > This used to work -- an

Re: maven build issues with non-numeric custom version

2014-01-28 Thread Ryan McKinley
The real version number i was trying was: -Dversion=4.7.r1562172M essentially a standard lucene build with a few chances. Having the non-numbers in the version make it fail This used to work -- and now seems to fail only for lucene-analyzers-phonetic but i don't have any idea where to start! r

RE: maven build issues with non-numeric custom version

2014-01-28 Thread Uwe Schindler
You should not use a version like this to build artifacts, because it violates the Maven specs for versioning. You can define a custom version, but you have to prepend it with a valid Maven-version number, like: -Dversion=“4.6-my-special-version” Ideally do it like Jenkins with build numb

Re: maven build issues with non-numeric custom version

2014-01-28 Thread shikhar
On Tue, Jan 28, 2014 at 7:28 PM, shikhar wrote: > I have run into this as well. It'd be great to allow arbitary strings for > versioning of custom releases. > Specifically, I was trying to use git sha's.

Re: maven build issues with non-numeric custom version

2014-01-28 Thread shikhar
I have run into this as well. It'd be great to allow arbitary strings for versioning of custom releases. This is the culprit: https://github.com/apache/lucene-solr/blob/branch_4x/lucene/tools/src/java/org/apache/lucene/dependencies/GetMavenDependenciesTask.java#L627 On Tue, Jan 28, 2014 at 4:10