RE: svn commit: r1354361 - /lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java

2012-06-28 Thread Uwe Schindler
Very Nice! I prefer this one, too! Uwe P.S.: And now please also wrap with Collections.unmodifiableSet() :-) - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de -Original Message- From: dwe...@apache.org [mailto:dwe...@apache.org]

Re: svn commit: r1354361 - /lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java

2012-06-28 Thread Dawid Weiss
P.S.: And now please also wrap with Collections.unmodifiableSet() :-) Subclass-style initialization may look fancy in code but generates an additional .class file and in general is not clear to somebody who isn't familiar with the trick. The fact it's not a constant doesn't bother me that much