Re: HitQueue.getSentinelObject() and performance

2017-01-22 Thread Michael McCandless
Aha! Thanks for bringing closure... Mike McCandless http://blog.mikemccandless.com On Sat, Jan 21, 2017 at 4:24 PM, Rob Audenaerde wrote: > Hi Mike, > > I was curious too, so with the help of your hint I did some more digging. > You were correct, as I found two occurences using this constructi

Re: HitQueue.getSentinelObject() and performance

2017-01-21 Thread Rob Audenaerde
Hi Mike, I was curious too, so with the help of your hint I did some more digging. You were correct, as I found two occurences using this construction: final TopDocs topDocs = indexSearcher.search(pageQuery, Integer.MAX_VALUE); As there are 4.5M documents in this specific index, this caused

Re: HitQueue.getSentinelObject() and performance

2017-01-20 Thread Toke Eskildsen
Michael McCandless wrote: > It's curious that you see this as a hot spot. > > Are you collecting a very large top N docs, relative to how many hits > the queries match, maybe? I did some testing on that some time ago. Microbenchmarks, so usual caveats apply. https://sbdevel.wordpress.com/2015/1

Re: HitQueue.getSentinelObject() and performance

2017-01-20 Thread Michael McCandless
It's curious that you see this as a hot spot. Are you collecting a very large top N docs, relative to how many hits the queries match, maybe? I don't think we can make this a static instance: the collection process will re-use the entry it pulls out of the queue. Mike McCandless http://blog.mik