Re: missing javadocs/package.html

2012-09-29 Thread Tommaso Teofili
thanks Robert and Chris for coming back to this, I do agree with Robert those javadoc comments are very important and often just the first thing one dev would look into. Also it'd be nice to have the mentioned check in the build. Thanks, Tommaso 2012/9/28 Robert Muir > I will do this! > > On Fr

Re: missing javadocs/package.html

2012-09-28 Thread Robert Muir
I will do this! On Fri, Sep 28, 2012 at 2:58 PM, Chris Hostetter wrote: > > https://issues.apache.org/jira/browse/SOLR-3904 > > If someone who knows more then me about the build/smoke checks can attach > a patch with the neccessary bits to make the build fail when solr packages > don't have packa

RE: missing javadocs/package.html

2012-09-28 Thread Chris Hostetter
https://issues.apache.org/jira/browse/SOLR-3904 If someone who knows more then me about the build/smoke checks can attach a patch with the neccessary bits to make the build fail when solr packages don't have package level docs, i'll work towards getting the build to pass with that patch. : Fi

RE: missing javadocs/package.html

2012-09-27 Thread Robert Muir
I wanted to respond to Tommaso's comment in the release vote in a separate thread for discussion: > one thing I noticed is : > "no package description (missing package.html in src?)" > for most of the Solr source code therefore we should add those > package(-info).html for the javadoc. We've bee