Re: Standardize Leading Test or Trailing Test

+1 On Fri, Aug 7, 2020 at 8:37 PM Marcus Eagan wrote: > > Any -1's? I just learned more about them from David Smiley earlier today and > I recognize they are for the rare case, but I want to ensure consensus before > I spend time on this tomorrow evening. I hadn't remembered seeing them in >

Re: Standardize Leading Test or Trailing Test

Any -1's? I just learned more about them from David Smiley earlier today and I recognize they are for the rare case, but I want to ensure consensus before I spend time on this tomorrow evening. I hadn't remembered seeing them in real life except for on the Lucene/Solr separation vote. Of course,

Re: Standardize Leading Test or Trailing Test

Yeah +1 for standardization +1.01 if it lands on *Test :) but that's just my personal preference. On Thu, Aug 6, 2020 at 9:17 AM Adrien Grand wrote: > +1 > > On Thu, Aug 6, 2020 at 1:54 PM Erick Erickson > wrote: > >> This has amused/annoyed me for a long time. But did I ever have the >>

Re: Standardize Leading Test or Trailing Test

+1 On Thu, Aug 6, 2020 at 1:54 PM Erick Erickson wrote: > This has amused/annoyed me for a long time. But did I ever have the > energy to tackle it? N. > > +1 > > > On Aug 6, 2020, at 1:50 AM, Tomás Fernández Löbbe > wrote: > > > > +1 > > > > On Wed, Aug 5, 2020 at 10:37 PM David

Re: Standardize Leading Test or Trailing Test

This has amused/annoyed me for a long time. But did I ever have the energy to tackle it? N. +1 > On Aug 6, 2020, at 1:50 AM, Tomás Fernández Löbbe > wrote: > > +1 > > On Wed, Aug 5, 2020 at 10:37 PM David Smiley wrote: > +1 to standardize on something. > This has been brought

Re: Standardize Leading Test or Trailing Test

+1 On Wed, Aug 5, 2020 at 10:37 PM David Smiley wrote: > +1 to standardize on something. > This has been brought up before: LUCENE-8626 > -- credit to > Christine who started the work. I recommend resuming the discussion there. > > ~ David >

Re: Standardize Leading Test or Trailing Test

+1 to standardize on something. This has been brought up before: LUCENE-8626 -- credit to Christine who started the work. I recommend resuming the discussion there. ~ David On Thu, Aug 6, 2020 at 12:08 AM Anshum Gupta wrote: > +1 > > Thanks

Re: Standardize Leading Test or Trailing Test

+1 Thanks for bringing this up, Marcus. Standardizing this is really great. On Wed, Aug 5, 2020 at 8:01 PM Marcus Eagan wrote: > Hi community, what do you think a small effort to standardize on leading > with the word "Test" or trailing with the word "Test" in the repo. Most > projects do one

Re: Standardize Leading Test or Trailing Test

This is almost a comical level of inconsistency in our code! On Wed, Aug 5, 2020 at 10:35 PM Robert Muir wrote: > > > On Wed, Aug 5, 2020 at 11:25 PM Mike Drob wrote: > >> +1 >> >> This is something I’ve been annoyed with before but then never did >> anything about. >> >> My suggestion would

Re: Standardize Leading Test or Trailing Test

On Wed, Aug 5, 2020 at 11:25 PM Mike Drob wrote: > +1 > > This is something I’ve been annoyed with before but then never did > anything about. > > My suggestion would be to end class names with Test and start method names > with test. I think LuceneTestCase already checks for the latter. > >

Re: Standardize Leading Test or Trailing Test

+1 Maybe we can add naming rules for test classes on check-source-patterns.groovy? https://github.com/apache/lucene-solr/blob/f03e6aac59cbdb0422aa05047fbc1c4bc5324cd9/lucene/tools/src/groovy/check-source-patterns.groovy Tomoko 2020年8月6日(木) 12:17 Robert Muir : > +1 > > There is no good reason

Re: Standardize Leading Test or Trailing Test

+1 This is something I’ve been annoyed with before but then never did anything about. My suggestion would be to end class names with Test and start method names with test. I think LuceneTestCase already checks for the latter. Mike On Wed, Aug 5, 2020 at 10:17 PM Robert Muir wrote: > +1 > >

Re: Standardize Leading Test or Trailing Test

+1 There is no good reason to name the source files inconsistently. It should be as easy as possible to do things with the tests with regular expressions, simple tools like grep and so on. Ideally we can fail the build if one tries to get added in the wrong way (some kind of precommit check:

Standardize Leading Test or Trailing Test

Hi community, what do you think a small effort to standardize on leading with the word "Test" or trailing with the word "Test" in the repo. Most projects do one or the other and it has an impact on developer productivity. I'll explain my use case: I'm working on a class and I want to modify the