Re: Test Harness behaviour on a package run

2018-10-29 Thread Christine Poerschke (BLOOMBERG/ LONDON)
: Test Harness behaviour on a package run +1. Would be great if precommit enforced a standard - both in the same package makes sorting/browsing weird. We should also enforce that classes under test that are not tests don't match that pattern. - Mark On Thu, Oct 25, 2018 at 10:04 AM David S

Re: Test Harness behaviour on a package run

2018-10-25 Thread Mark Miller
+1. Would be great if precommit enforced a standard - both in the same package makes sorting/browsing weird. We should also enforce that classes under test that are not tests don't match that pattern. - Mark On Thu, Oct 25, 2018 at 10:04 AM David Smiley wrote: > +1 to standardize test class na

Re: Test Harness behaviour on a package run

2018-10-25 Thread David Smiley
+1 to standardize test class naming! On Thu, Oct 25, 2018 at 10:32 AM Gus Heck wrote: > Or we could corral the naming of our tests into one pattern... > > On Wed, Oct 24, 2018 at 5:08 PM Varun Thacker wrote: > >> Thanks Steve! That worked for me >> >> I'll go ahrad and make this as the default

Re: Test Harness behaviour on a package run

2018-10-25 Thread Gus Heck
Or we could corral the naming of our tests into one pattern... On Wed, Oct 24, 2018 at 5:08 PM Varun Thacker wrote: > Thanks Steve! That worked for me > > I'll go ahrad and make this as the default example to the "test-help" > target > > - [help] ant test "-Dtests.class=org.apache.lucene.packag

Re: Test Harness behaviour on a package run

2018-10-24 Thread Varun Thacker
Thanks Steve! That worked for me I'll go ahrad and make this as the default example to the "test-help" target - [help] ant test "-Dtests.class=org.apache.lucene.package.*" + [help] ant test "-Dtests.class=org.apache.lucene.package.Test*|org.apache.lucene.package.*Test" On Wed, Oct 24, 2018 at 7

Re: Test Harness behaviour on a package run

2018-10-24 Thread Steve Rowe
This worked for me: ant clean test "-Dtests.class=org.apache.solr.search.facet.Test*|org.apache.solr.search.facet.*Test" -- Steve www.lucidworks.com > On Oct 24, 2018, at 3:20 AM, Dawid Weiss wrote: > > There is no way for the runner to tell which class is a JUnit test > class. Typically thi

Re: Test Harness behaviour on a package run

2018-10-24 Thread Dawid Weiss
There is no way for the runner to tell which class is a JUnit test class. Typically this is done with pattern matching on file names. common-build.xml converts this property to an file inclusion pattern (see tests.explicitclass) and if you include everything, the runner tries to load and inspect a

Test Harness behaviour on a package run

2018-10-23 Thread Varun Thacker
I wanted to run all tests within one package so I ran it like this ant clean test "-Dtests.class=org.apache.solr.search.facet.*" The test run fails because the harness is trying to run DebugAgg as it's a public class while it's not really a test class. [junit4] Tests with failures [seed: EB7B