Re: TestReplicationHandler is failing 100% (master and 7.x / 7.3)

bq. because it used to fail sometimes on slow machines It will very likely fail then on those virtboxes, etc. D. On Thu, Mar 15, 2018 at 5:02 AM, Shalin Shekhar Mangar wrote: > Hi Erick, > > The test was disabled because it used to fail sometimes on slow machines. I >

Re: TestReplicationHandler is failing 100% (master and 7.x / 7.3)

OK. Note that only certain Jenkins jobs run with BadApple=true set. Mark's beastit stuff (he's got that back up and running) runs with badapple=true though, so maybe if it survives a few days running there we can un-annotate it. How about this. I'll check Marks stuff and, if by Saturday there

Re: TestReplicationHandler is failing 100% (master and 7.x / 7.3)

Hi Erick, The test was disabled because it used to fail sometimes on slow machines. I haven't beasted it to see if that still happens but it probably does. I only fixed it so that it doesn't always fail. So let's see how Jenkins is doing and then decide. On Thu, Mar 15, 2018 at 3:31 AM, Erick

Re: TestReplicationHandler is failing 100% (master and 7.x / 7.3)

Shalin: Should we remove (actually, comment out with a date?) the BadApple annotation for doTestIndexFetchOnMasterRestart? And do you think your fixes have any influence on the other BadApple (doTestIndexAndConfigReplication)? There's no problem with un-BadApple-ing test that have been or are

Re: TestReplicationHandler is failing 100% (master and 7.x / 7.3)

This is fixed. I committed the fix to master, branch_7x and branch_7_3 branches. On Wed, Mar 14, 2018 at 9:44 PM, Alan Woodward wrote: > Thanks Shalin! > > > On 14 Mar 2018, at 15:50, Shalin Shekhar Mangar > wrote: > > I'll take a look at it

Re: TestReplicationHandler is failing 100% (master and 7.x / 7.3)

Thanks Shalin! > On 14 Mar 2018, at 15:50, Shalin Shekhar Mangar > wrote: > > I'll take a look at it tomorrow morning my time. > > On Wed, Mar 14, 2018 at 9:07 PM, Andrzej Białecki >

Re: TestReplicationHandler is failing 100% (master and 7.x / 7.3)

I'll take a look at it tomorrow morning my time. On Wed, Mar 14, 2018 at 9:07 PM, Andrzej Białecki < andrzej.biale...@lucidworks.com> wrote: > Well … I looked at it briefly but I have no idea what’s going on there. I > could dig into it nonetheless, but if there’s someone who already knows the >

Re: TestReplicationHandler is failing 100% (master and 7.x / 7.3)

Well … I looked at it briefly but I have no idea what’s going on there. I could dig into it nonetheless, but if there’s someone who already knows the replication handler ins and outs it would probably get fixed sooner... > On 14 Mar 2018, at 14:23, Alan Woodward wrote: >

Re: TestReplicationHandler is failing 100% (master and 7.x / 7.3)

I’m happy either way, but if it’s a bug can we get it fixed quickly? Can you take ownership of this one Andrzej? > On 14 Mar 2018, at 11:24, Andrzej Białecki > wrote: > > Hi, > > This test has always been fragile, but recently it’s been failing

TestReplicationHandler is failing 100% (master and 7.x / 7.3)

Hi, This test has always been fragile, but recently it’s been failing 100%, most often in ‘doTestIndexFetchOnMasterRestart’. I don’t know the replication handler enough to be able to find the real reason behind these failures, but there are two possibilities that I see: * the test has a bug