Re: new candidate list for BadApple-ing on Saturday, 17-Mar

2018-03-15 Thread Erick Erickson
Sure, the Lucene tests will _not_ be BadApple-d on Saturday. Any of those tests that do _not_ fail according to Hoss' and Mark's projects on Friday/Saturday will NOT be annotated anyway. On Thu, Mar 15, 2018 at 2:24 AM, Alan Woodward wrote: > The lucene failures might well

Re: new candidate list for BadApple-ing on Saturday, 17-Mar

2018-03-15 Thread Alan Woodward
The lucene failures might well be linked to https://issues.apache.org/jira/browse/LUCENE-8203 - let’s see if they drop off the list. > On 14 Mar 2018, at 21:52, Erick Erickson >

Re: new candidate list for BadApple-ing on Saturday, 17-Mar

2018-03-15 Thread Dawid Weiss
> org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads I know what the problem here is (wall-time). I'll look into fixing it. https://issues.apache.org/jira/browse/LUCENE-8206 D. - To unsubscribe, e-mail:

Re: new candidate list for BadApple-ing on Saturday, 17-Mar

2018-03-14 Thread Erick Erickson
Gus: Nice sleuthing! The problem has been that there has been s much noise that it's been almost impossible, for me at least, to get motivated to dig into them. I certainly suspect systemic issues like this are behind some of our intermittent failures, so I'm very glad you took the

Re: new candidate list for BadApple-ing on Saturday, 17-Mar

2018-03-14 Thread Mark Miller
Can you file a JIRA issue? In general, we want to be super forgiving by default and only harsh for a specific test that might demand it. - Mark On Wed, Mar 14, 2018 at 9:45 PM Gus Heck wrote: > Beginning to answer my own question... > > public abstract class

Re: new candidate list for BadApple-ing on Saturday, 17-Mar

2018-03-14 Thread Gus Heck
Beginning to answer my own question... public abstract class AbstractZkTestCase extends SolrTestCaseJ4 { private static final String ZOOKEEPER_FORCE_SYNC = "zookeeper.forceSync"; public static final int TIMEOUT = 45000; seems to be at least one place we are probably not getting what we

Re: new candidate list for BadApple-ing on Saturday, 17-Mar

2018-03-14 Thread Gus Heck
Being slightly irritated by the fact one of my tests shows up in this, I did some digging and I found [junit4] 2> 485679 ERROR (OverseerThreadFactory-788-thread-1-processing-n:127.0.0.1:35771_solr) [n:127.0.0.1:35771_solr] o.a.s.c.a.c.OverseerCollectionMessageHandler Collection:

new candidate list for BadApple-ing on Saturday, 17-Mar

2018-03-14 Thread Erick Erickson
We had a drop off in the number of failing tests over the last couple of days, so I'm going to ignore the fails 11-12 Mar. Or it was a temporary increase for those days, take your pick ;) I'll check against Hoss' and Mark's lists and only BadApple tests that've failed Friday or later. In