RE: precommit failure

2018-08-15 Thread Uwe Schindler
Hi, > To be sure we're talking about the same thing, your preferred > initialization looks like this? > > static final Map solrClassMap = > Collections.unmodifiableMap(Stream.of( > new SimpleEntry<>(TEST_TYPE.TINT, "solr.TrieIntField"), > > new SimpleEntry<>(TEST_TYPE.BOOL, "solr.BoolFie

Re: precommit failure

2018-08-14 Thread Erick Erickson
Robert: Thanks, upgrading the ecj compiler to 4.6.1 did the trick. I'll open a separate Lucene JIRA for upgrading. FWIW both my original construct and the one below failed precommit under 4.4.1. Didn't test the older way I was initializing under 4.6.1, but the one below works both code-wise and pr

Re: precommit failure

2018-08-14 Thread Uwe Schindler
...and the inline lambdas are horrible. You'd should use a method reference, because that's how those key and value mappers should be used. Am August 14, 2018 8:19:21 PM UTC schrieb Uwe Schindler : >You have to be careful with this construct anyways, as the resulting >map is modifiable. You'd nee

Re: precommit failure

2018-08-14 Thread Uwe Schindler
You have to be careful with this construct anyways, as the resulting map is modifiable. You'd need to make it unmodifiable afterwards. Uwe Am August 14, 2018 8:00:24 PM UTC schrieb Erick Erickson : >Robert: > >I'll give it a shot, thanks! It'll be this evening before I can report >back though.

Re: precommit failure

2018-08-14 Thread Erick Erickson
Robert: I'll give it a shot, thanks! It'll be this evening before I can report back though. Erick On Tue, Aug 14, 2018 at 12:03 PM, Robert Muir wrote: > ecj compiler is loaded from the common-build here: > https://github.com/apache/lucene-solr/blob/master/lucene/common-build.xml#L2099 > > Looks

Re: precommit failure

2018-08-14 Thread Robert Muir
ecj compiler is loaded from the common-build here: https://github.com/apache/lucene-solr/blob/master/lucene/common-build.xml#L2099 Looks like the compiler is a little out of date: it uses 4.4.1 but looking at maven it seems 4.6.1 is the latest one. Maybe try bumping it to see if it addresses your

precommit failure

2018-08-14 Thread Erick Erickson
OK, so I'm trying to get modern and used the following construct to initialize a map: static final Map solrClassMap = Collections.unmodifiableMap(Stream.of( new SimpleEntry<>(TEST_TYPE.TINT, "solr.TrieIntField"), new SimpleEntry<>(TEST_TYPE.BOOL, "solr.BoolField")) .collect(Collectors.

Re: Precommit failure

2017-02-19 Thread Ishan Chattopadhyaya
< [email protected]> wrote: > Got the same failure on master as well. I'll dig in tomorrow to find out > which commit broke this for me. > > On Sun, Feb 19, 2017 at 2:35 PM, Ishan Chattopadhyaya < > [email protected]> wrote: > >> I got a precom

Re: Precommit failure

2017-02-19 Thread Ishan Chattopadhyaya
Got the same failure on master as well. I'll dig in tomorrow to find out which commit broke this for me. On Sun, Feb 19, 2017 at 2:35 PM, Ishan Chattopadhyaya < [email protected]> wrote: > I got a precommit failure on branch_6x. However, I went ahead and > backported

Precommit failure

2017-02-19 Thread Ishan Chattopadhyaya
I got a precommit failure on branch_6x. However, I went ahead and backported anyway. Does this happen for everyone, or is there something wrong with my setup? Here's the log: ... ivy-fail: ivy-configure: [ivy:configure] :: loading settings :: file = /home/ishan/lucene-solr-committers