Re: solr.common.util.Pair --> commons.lang3.tuple.Pair

Thanks everyone for your input! I have created https://issues.apache.org/jira/browse/SOLR-9079 as a future 'wish' item. Christine - Original Message - From: dev@lucene.apache.org To: dev@lucene.apache.org At: May 5 2016 19:53:58 On 5/5/2016 11:07 AM, Erick Erickson wrote: > Or

Re: solr.common.util.Pair --> commons.lang3.tuple.Pair

On 5/5/2016 11:07 AM, Erick Erickson wrote: > Or upgrade commons-lang I did think of that, and thought it probably would not work because commons-lang 2.x was almost guaranteed to be a sub-dependency to one of Solr's other dependencies. Just for giggles, I updated the ivy config to pull in

Re: solr.common.util.Pair --> commons.lang3.tuple.Pair

Or upgrade commons-lang On Thu, May 5, 2016 at 10:01 AM, Shawn Heisey wrote: > On 5/5/2016 10:38 AM, Erick Erickson wrote: >> Even for a trivial class, +1 to going to the commons version if it >> doesn't include a new dependency. > > Solr currently has commons-lang 2.6

Re: solr.common.util.Pair --> commons.lang3.tuple.Pair

On 5/5/2016 10:38 AM, Erick Erickson wrote: > Even for a trivial class, +1 to going to the commons version if it > doesn't include a new dependency. Solr currently has commons-lang 2.6 as a dependency. The class mentioned in the subject says "lang3" ... so I think that would be a new dependency.

Re: solr.common.util.Pair --> commons.lang3.tuple.Pair

Even for a trivial class, +1 to going to the commons version if it doesn't include a new dependency. On Thu, May 5, 2016 at 7:29 AM, Mark Miller wrote: > I probably made the Solr one. I don't know what else existed and didn't look > - if I remember right, someone committed

Re: solr.common.util.Pair --> commons.lang3.tuple.Pair

I probably made the Solr one. I don't know what else existed and didn't look - if I remember right, someone committed a Pair reference that came from a library not included on all platforms and I just made the class to fix the build since it's about 10 lines of boiler plate. - Mark On Thu, May

solr.common.util.Pair --> commons.lang3.tuple.Pair

Steve Davids wrote on another email thread: Though, out of curiosity why not just use the Pair class in Apache Commons-Lang? http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/tuple/Pair.html I'd be +1 to switching over to org.apache.commons.lang3.tuple.Pair - it