Re: svn commit: r1481912 - in /lucene/dev/trunk/dev-tools/maven/lucene: pom.xml.template replicator/pom.xml.template

2013-05-13 Thread Shai Erera
ok I just committed a fix to the template following the build failure. Appreciate if you can review the change too! Shai On Mon, May 13, 2013 at 6:21 PM, Steve Rowe wrote: > Thanks for the review, Shai, I'll just remove the comment altogether > (copy-paste-o from Solrj). - Steve > > On May 13

Re: svn commit: r1481912 - in /lucene/dev/trunk/dev-tools/maven/lucene: pom.xml.template replicator/pom.xml.template

2013-05-13 Thread Steve Rowe
Thanks for the review, Shai, I'll just remove the comment altogether (copy-paste-o from Solrj). - Steve On May 13, 2013, at 11:15 AM, sar...@apache.org wrote: > Author: sarowe > Date: Mon May 13 15:15:01 2013 > New Revision: 1481912 > > URL: http://svn.apache.org/r1481912 > Log: > LUCENE-4975:

Re: svn commit: r1481912 - in /lucene/dev/trunk/dev-tools/maven/lucene: pom.xml.template replicator/pom.xml.template

2013-05-13 Thread Shai Erera
Thanks Steve. But you may want to rename this comment: to ? Shai On Mon, May 13, 2013 at 6:15 PM, wrote: > Author: sarowe > Date: Mon May 13 15:15:01 2013 > New Revision: 1481912 > > URL: http://svn.apache.org/r1481912 > Log: > LUCENE-4975: replicator module: make Maven configuration function