[jira] [Commented] (SOLR-2894) Implement distributed pivot faceting

2013-01-13 Thread Shahar Davidson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552166#comment-13552166 ] Shahar Davidson commented on SOLR-2894: --- Hi Chris, Thanks for the updated patch. I

[jira] [Commented] (LUCENE-4682) Reduce wasted bytes in FST due to array arcs

2013-01-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552184#comment-13552184 ] Michael McCandless commented on LUCENE-4682: OK I ran several performance

[jira] [Commented] (LUCENE-4682) Reduce wasted bytes in FST due to array arcs

2013-01-13 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552189#comment-13552189 ] Robert Muir commented on LUCENE-4682: - Well, i think actually we shouldnt allow 25%

[jira] [Resolved] (SOLR-1028) Automatic core loading unloading for multicore

2013-01-13 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-1028. -- Resolution: Fixed Should have resolved this quite a while ago, thanks for prompting me Steve.

[jira] [Assigned] (SOLR-4217) post.jar ignores -Dparams when -Durl is used

2013-01-13 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Hatcher reassigned SOLR-4217: -- Assignee: Erik Hatcher post.jar ignores -Dparams when -Durl is used

A minor optimization for Fixed/OpenBitSet?

2013-01-13 Thread Shai Erera
Hi Both these classes set/get do this: int bit = index 0x3f; // mod 64 long bitmask = 1L bit; Since bit has only 64 values, bitmask can only be 1, 10, 100... etc. I was thinking that instead of doing the , we can have a static BIT_MASK array, indexed by bit, and then we could use it

[jira] [Commented] (LUCENE-4682) Reduce wasted bytes in FST due to array arcs

2013-01-13 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552218#comment-13552218 ] Dawid Weiss commented on LUCENE-4682: - bq. I think if it would be too wasteful (e.g.

Re: A minor optimization for Fixed/OpenBitSet?

2013-01-13 Thread Dawid Weiss
I doubt it'll be faster, not with array bounds checking and the typical Java overhead. Feel free to benchmark using Caliper, for example: http://code.google.com/p/caliper/ Dawid On Sun, Jan 13, 2013 at 4:37 PM, Shai Erera ser...@gmail.com wrote: Hi Both these classes set/get do this: int

[jira] [Commented] (LUCENE-4678) FST should use paged byte[] instead of single contiguous byte[]

2013-01-13 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552224#comment-13552224 ] Commit Tag Bot commented on LUCENE-4678: [trunk commit] Michael McCandless

Questions about LUCENE-4682

2013-01-13 Thread Shawn Heisey
Watching jira, I have seen recent activity on LUCENE-4682, and also a few other issues that look similar. It appears that this issue would likely require reindexing on Solr. Is that the case? Is it expected to be applied to branch_4x, and if so, will it make it into 4.1? I'm not

Re: A minor optimization for Fixed/OpenBitSet?

2013-01-13 Thread Yonik Seeley
On Sun, Jan 13, 2013 at 10:39 AM, Dawid Weiss dawid.we...@cs.put.poznan.pl wrote: I doubt it'll be faster, Yeah, this shift will be pretty simple - 1 cycle, and normally with a max throughput of 2 to 3 per cycle for x86 server CPUs. Even without java bounds checking, the most you could hope for

[jira] [Commented] (SOLR-1028) Automatic core loading unloading for multicore

2013-01-13 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552233#comment-13552233 ] Yonik Seeley commented on SOLR-1028: I started a really quick review of the code, but

[jira] [Reopened] (SOLR-3911) Make Directory and DirectoryFactory first class so that the majority of Solr's features work with any custom implementations.

2013-01-13 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller reopened SOLR-3911: --- I think this needs a little more work. Now that we write small meta data files through the directory,

Re: Questions about LUCENE-4682

2013-01-13 Thread Michael McCandless
Hi Shawn, The plan is to hold these FST changes until 4.2: they are too risky / need time to bake on trunk (though so far they look OK: Jenkins seems to be at peace). When we do backport the changes (after 4.1 branch is cut) it will be an index format change, however since 4.x is currently still

[jira] [Commented] (SOLR-3911) Make Directory and DirectoryFactory first class so that the majority of Solr's features work with any custom implementations.

2013-01-13 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552254#comment-13552254 ] Commit Tag Bot commented on SOLR-3911: -- [trunk commit] Mark Robert Miller

[jira] [Commented] (SOLR-3911) Make Directory and DirectoryFactory first class so that the majority of Solr's features work with any custom implementations.

2013-01-13 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552257#comment-13552257 ] Commit Tag Bot commented on SOLR-3911: -- [branch_4x commit] Mark Robert Miller

Re: A minor optimization for Fixed/OpenBitSet?

2013-01-13 Thread Adrien Grand
In addition to what Dawid and Yonik said, Packed64 used to have such optimizations but they have been removed because they were slower than computing masks on the fly (see https://issues.apache.org/jira/browse/LUCENE-4171). -- Adrien Grand

[jira] [Created] (SOLR-4300) Possible race condition in CoreContainer.getCore() when lazily loading cores.

2013-01-13 Thread Erick Erickson (JIRA)
Erick Erickson created SOLR-4300: Summary: Possible race condition in CoreContainer.getCore() when lazily loading cores. Key: SOLR-4300 URL: https://issues.apache.org/jira/browse/SOLR-4300 Project:

[jira] [Commented] (SOLR-4299) Failed with java.net.BindException Address already in use

2013-01-13 Thread Nithin Chacko Ninan (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552267#comment-13552267 ] Nithin Chacko Ninan commented on SOLR-4299: --- awesome thank you very much. I will

[jira] [Commented] (SOLR-1028) Automatic core loading unloading for multicore

2013-01-13 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552268#comment-13552268 ] Erick Erickson commented on SOLR-1028: -- You're right, thanks! I'm a bit reluctant to

[jira] [Updated] (SOLR-2298) Javadoc weak for SolrDocument.addField

2013-01-13 Thread Siva Natarajan (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siva Natarajan updated SOLR-2298: - Attachment: SOLR-2298.patch Updated JavaDoc for SolrDocument.addField() and

Re: A minor optimization for Fixed/OpenBitSet?

2013-01-13 Thread Shai Erera
Thanks guys! Shai On Sun, Jan 13, 2013 at 7:59 PM, Adrien Grand jpou...@gmail.com wrote: In addition to what Dawid and Yonik said, Packed64 used to have such optimizations but they have been removed because they were slower than computing masks on the fly (see

Possible bug in Solr SpellCheckComponent if more than one QueryConverter class is present

2013-01-13 Thread Jack Krupansky
Reading through the code for Solr SpellCheckComponent.java for 4.1, it looks like it neither complains nor defaults reasonably if more than on QueryConverter class is present in the Solr lib directories: MapString, QueryConverter queryConverters = new HashMapString, QueryConverter();

[jira] [Commented] (SOLR-3755) shard splitting

2013-01-13 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552307#comment-13552307 ] Yonik Seeley commented on SOLR-3755: OK, after chatting w/ Mark a bit, this seems to be

[jira] [Updated] (LUCENE-3298) FST has hard limit max size of 2.1 GB

2013-01-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-3298: --- Attachment: LUCENE-3298.patch New patch, beefing up the test (it passes: takes 10

[jira] [Created] (LUCENE-4683) Change Aggregator and CategoryListIterator to be per-segment

2013-01-13 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-4683: -- Summary: Change Aggregator and CategoryListIterator to be per-segment Key: LUCENE-4683 URL: https://issues.apache.org/jira/browse/LUCENE-4683 Project: Lucene - Core

[jira] [Commented] (LUCENE-3298) FST has hard limit max size of 2.1 GB

2013-01-13 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552323#comment-13552323 ] Dawid Weiss commented on LUCENE-3298: - {code} + void finish(long startNode) throws

[jira] [Commented] (LUCENE-3298) FST has hard limit max size of 2.1 GB

2013-01-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552330#comment-13552330 ] Michael McCandless commented on LUCENE-3298: bq. Doesn't this change the

[jira] [Commented] (LUCENE-3298) FST has hard limit max size of 2.1 GB

2013-01-13 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552334#comment-13552334 ] Dawid Weiss commented on LUCENE-3298: - duh... sorry i missed the fact that method arg

[jira] [Commented] (LUCENE-3298) FST has hard limit max size of 2.1 GB

2013-01-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552364#comment-13552364 ] Michael McCandless commented on LUCENE-3298: Search perf looks fine ... maybe

[jira] [Commented] (LUCENE-3298) FST has hard limit max size of 2.1 GB

2013-01-13 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552373#comment-13552373 ] Robert Muir commented on LUCENE-3298: - This all looks like noise. +1 to commit.

[jira] [Commented] (LUCENE-4682) Reduce wasted bytes in FST due to array arcs

2013-01-13 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552374#comment-13552374 ] Robert Muir commented on LUCENE-4682: - I agree: about the code complication, its hard

[jira] [Comment Edited] (SOLR-1028) Automatic core loading unloading for multicore

2013-01-13 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552268#comment-13552268 ] Erick Erickson edited comment on SOLR-1028 at 1/14/13 2:39 AM:

[jira] [Created] (SOLR-4301) Consolidate lazily-loaded cores and loadOnStartup cores lists into a separate class

2013-01-13 Thread Erick Erickson (JIRA)
Erick Erickson created SOLR-4301: Summary: Consolidate lazily-loaded cores and loadOnStartup cores lists into a separate class Key: SOLR-4301 URL: https://issues.apache.org/jira/browse/SOLR-4301

[jira] [Updated] (SOLR-4300) Possible race condition in CoreContainer.getCore() when lazily loading cores.

2013-01-13 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-4300: - Attachment: SOLR-4300.patch Definitely a race condition. This patch includes a test case that

[jira] [Assigned] (SOLR-2298) Javadoc weak for SolrDocument.addField

2013-01-13 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-2298: Assignee: Erick Erickson Javadoc weak for SolrDocument.addField

[jira] [Updated] (SOLR-4217) post.jar ignores -Dparams when -Durl is used

2013-01-13 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Hatcher updated SOLR-4217: --- Fix Version/s: (was: 4.2) (was: 5.0) 4.1 post.jar

[jira] [Updated] (SOLR-4217) post.jar ignores -Dparams when -Durl is used

2013-01-13 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Hatcher updated SOLR-4217: --- Attachment: SOLR-4217.patch Alexandre - here's a patch I believe solves the problem. I added a test

[jira] [Commented] (SOLR-4127) Atomic updates used w/o updateLog should throw an error

2013-01-13 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552414#comment-13552414 ] Commit Tag Bot commented on SOLR-4127: -- [trunk commit] Erik Hatcher

[jira] [Resolved] (SOLR-4217) post.jar ignores -Dparams when -Durl is used

2013-01-13 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Hatcher resolved SOLR-4217. Resolution: Fixed Alexandre - thanks for bringing up this issue and showing the way to the fix

[jira] [Commented] (SOLR-4127) Atomic updates used w/o updateLog should throw an error

2013-01-13 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552415#comment-13552415 ] Commit Tag Bot commented on SOLR-4127: -- [branch_4x commit] Erik Hatcher

[jira] [Resolved] (SOLR-3911) Make Directory and DirectoryFactory first class so that the majority of Solr's features work with any custom implementations.

2013-01-13 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller resolved SOLR-3911. --- Resolution: Fixed Make Directory and DirectoryFactory first class so that the majority of

[jira] [Commented] (SOLR-4134) Cannot set multiple values into multivalued field with partial updates when using the standard RequestWriter.

2013-01-13 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552434#comment-13552434 ] Shalin Shekhar Mangar commented on SOLR-4134: - Hi Erick, a change log entry was