Re: 8.3 release

[Shalin Shekhar Mangar]

SOLR-13843 has also been committed to master, branch_8x and branch_8_3.
Thanks!

On Sat, Oct 19, 2019 at 1:33 AM Andrzej Białecki  wrote:

> SOLR-13677 is done. Thanks for your patience!
>
> On 18 Oct 2019, at 10:46, Ishan Chattopadhyaya 
> wrote:
>
> Sure Shalin, please go ahead. I'm still waiting for SOLR-13677 to be
> resolved.
> Thanks!
>
> On Fri, 18 Oct, 2019, 10:24 AM Shalin Shekhar Mangar, <
> shalinman...@gmail.com> wrote:
>
>> Hi Ishan,
>>
>> Is it okay to push https://issues.apache.org/jira/browse/SOLR-13843 to
>> 8.3 release? The patch is ready and tested and all I need is to commit and
>> merge it to the various branches.
>>
>> On Thu, Oct 17, 2019 at 4:37 AM Jan Høydahl 
>> wrote:
>>
>>> https://issues.apache.org/jira/browse/SOLR-13835 is merged.
>>>
>>> --
>>> Jan Høydahl, search solution architect
>>> Cominvent AS - www.cominvent.com
>>>
>>> 16. okt. 2019 kl. 22:15 skrev Cassandra Targett :
>>>
>>> Done, Ishan, thanks!
>>>
>>> Cassandra
>>> On Oct 16, 2019, 2:37 PM -0500, Ishan Chattopadhyaya <
>>> ichattopadhy...@gmail.com>, wrote:
>>>
>>> +1, Cassandra! Thanks.
>>>
>>> On Wed, 16 Oct, 2019, 11:41 PM Cassandra Targett, 
>>> wrote:
>>>
 Sorry, I meant branch_8_3.

 Cassandra
 On Oct 16, 2019, 12:59 PM -0500, Cassandra Targett <
 casstarg...@gmail.com>, wrote:

 I just committed to master and branch_8x
 https://issues.apache.org/jira/browse/SOLR-12786 to update the
 versions of tools we use for building the Ref Guide. I’d like to commit
 that into branch_8_x if you don’t mind, Ishan? It’s not urgent, though.

 Cassandra
 On Oct 16, 2019, 11:36 AM -0500, Alan Woodward ,
 wrote:

 LUCENE-9005 is committed.

 On 16 Oct 2019, at 17:12, Jan Høydahl  wrote:

 SOLR-13835  is also
 almost there.

 Jan Høydahl

 16. okt. 2019 kl. 16:53 skrev Adrien Grand :

 Hi Ishan,

 LUCENE-8920 needs more work indeed, but it is not blocking this release.

 On Wed, Oct 16, 2019 at 3:54 PM Ishan Chattopadhyaya
  wrote:


 Hi,

 Here are the issues that remain to be resolved for 8.3.


 LUCENE-8920: Committed, but not resolved. More work remains?

 LUCENE-9005: Patch available, not committed.

 SOLR-13677: Patch available, not committed. Need another day to

 complete cleanup and tests.


 I'll wait until all of them are finished and then proceed to build the
 RC1.

 Thanks and regards,

 Ishan


 On Tue, Oct 15, 2019 at 2:58 PM Ishan Chattopadhyaya

  wrote:


 Sure, Noble, thanks! Next time, please use a single commit to revert

 such features (you just used up 3 commits). branch_8_3's history is

 now littered with SOLR-13821 commits and reverts that shouldn't have

 been there :-)


 Thanks, Jan!


 On Tue, Oct 15, 2019 at 12:17 AM Noble Paul 
 wrote:


 Hi,

 I'll revert the package store commits related to SOLR-13821 in the 8.3

 branch. It is supposed to be used by the (SOLR-13822) and it is not a

 part of the 8.3 release.

 --Noble


 On Tue, Oct 15, 2019 at 5:22 AM Adrien Grand  wrote:


 Hi Ishan,


 The release is no longer blocked on LUCENE-8920.


 On Thu, Oct 10, 2019 at 6:18 PM Ishan Chattopadhyaya

  wrote:


 +1, Ignacio. Please feel free to do the needful, I'll wait until this
 is resolved.


 +1, Jan. Sure, I think we should get it in!



 On Thu, 10 Oct, 2019, 5:45 PM Đạt Cao Mạnh, 
 wrote:


 Hi Ishan,


 I pushed the fix to branch_8_3.


 On Thu, Oct 10, 2019 at 11:27 AM Jan Høydahl 
 wrote:


 Ishan, I'd like to get https://issues.apache.org/jira/browse/SOLR-13665
 included, since without it Solr won't work with SSL against Zookeeper.


 --

 Jan Høydahl, search solution architect

 Cominvent AS - www.cominvent.com


 10. okt. 2019 kl. 11:45 skrev Ignacio Vera :


 Hi Ishan,


 Thanks for taking care of the release. We have a blocker in Lucene (see
 https://issues.apache.org/jira/browse/LUCENE-8920). I remember that
 was an issue for the 8.2.0 release and it was reverted and naked as a
 blocker for this release. Maybe we should completely reverted until we have
 a better solution? let see what Mike thinks about it.


 Thanks,


 Ignacio


 On Wed, Oct 9, 2019 at 4:51 PM Uwe Schindler  wrote:


 Hi,


 I also had a customer complaining about this. I have the feeling it
 also happens from time to time during inter node comm, which uses solrj,
 too.


 Uwe


 Am October 9, 2019 

Re: Capturing URL params for use within Streaming Expressions

[Joel Bernstein]

I think it's fine to pass through parameters to the various stream sources.
Perhaps we should limit it to a set list of parameters to pass through just
so it limits the scope,


Joel Bernstein
http://joelsolr.blogspot.com/


On Wed, Oct 16, 2019 at 4:47 PM Houston Putman 
wrote:

> Streaming expressions allow for users to pass in any arbitrary URL params
> in the search streaming source. I'm looking to add the ability for certain
> streaming functions, maybe just "search()" but possibly more, to extract
> the extra URL params passed along in the streaming request.
>
> For example sending a request:
> http://localhost:8983/solr/example/stream?expr=search(collection1,
> q="*:*", fl="id", sort="id")&
> *shards.preference=shards.preference=replica.location:local*
>
> would be equivalent to:
> http://localhost:8983/solr/example/stream?expr=search(collection1,
> q="*:*", fl="id", sort="id",
> *shards.preference="shards.preference=replica.location:local"*)
>
> The beauty of URL params is that they can easily be overridden and
> checked, for example in a proxy between the user and solr. It is harder to
> do this with streaming expressions as the proxy would need to parse the
> expression and know the logic of the functions and sources.
>
> I'm open to discussion on whether the params able to be captured by the
> streaming function would need to be white-listed or black-listed. My idea
> is that this would be generically implemented through something like the
> StreamContext, so that any streaming function that wants to add this
> functionality is able to do so.
>
> Another option is to add a URL parameter such as
> *=replica.location:local* (
> *expr.override..=*). That way it's explicit
> that the user is trying to send options to the streaming expression, and
> extraneous URL params aren't accidentally captured when they were included
> for a different purpose.
>
> Anyways this would really help us for some uses cases, especially the
> replica routing options used in the example above. Really interested to see
> opinions on either of these options.
>
> - Houston Putman
>

Re: 8.3 release

[Andrzej Białecki]

SOLR-13677 is done. Thanks for your patience!

> On 18 Oct 2019, at 10:46, Ishan Chattopadhyaya  
> wrote:
> 
> Sure Shalin, please go ahead. I'm still waiting for SOLR-13677 to be resolved.
> Thanks!
> 
> On Fri, 18 Oct, 2019, 10:24 AM Shalin Shekhar Mangar,  > wrote:
> Hi Ishan,
> 
> Is it okay to push https://issues.apache.org/jira/browse/SOLR-13843 
>  to 8.3 release? The patch 
> is ready and tested and all I need is to commit and merge it to the various 
> branches.
> 
> On Thu, Oct 17, 2019 at 4:37 AM Jan Høydahl  > wrote:
> https://issues.apache.org/jira/browse/SOLR-13835 
>  is merged.
> 
> --
> Jan Høydahl, search solution architect
> Cominvent AS - www.cominvent.com 
> 
>> 16. okt. 2019 kl. 22:15 skrev Cassandra Targett > >:
>> 
>> Done, Ishan, thanks!
>> 
>> Cassandra
>> On Oct 16, 2019, 2:37 PM -0500, Ishan Chattopadhyaya 
>> mailto:ichattopadhy...@gmail.com>>, wrote:
>>> +1, Cassandra! Thanks.
>>> 
>>> On Wed, 16 Oct, 2019, 11:41 PM Cassandra Targett, >> > wrote:
>>> Sorry, I meant branch_8_3.
>>> 
>>> Cassandra
>>> On Oct 16, 2019, 12:59 PM -0500, Cassandra Targett >> >, wrote:
 I just committed to master and branch_8x 
 https://issues.apache.org/jira/browse/SOLR-12786 
  to update the versions 
 of tools we use for building the Ref Guide. I’d like to commit that into 
 branch_8_x if you don’t mind, Ishan? It’s not urgent, though.
 
 Cassandra
 On Oct 16, 2019, 11:36 AM -0500, Alan Woodward >>> >, wrote:
> LUCENE-9005 is committed.
> 
>> On 16 Oct 2019, at 17:12, Jan Høydahl > > wrote:
>> 
>> SOLR-13835  is also 
>> almost there.
>> 
>> Jan Høydahl
>> 
>>> 16. okt. 2019 kl. 16:53 skrev Adrien Grand >> >:
>>> 
>>> Hi Ishan,
>>> 
>>> LUCENE-8920 needs more work indeed, but it is not blocking this release.
>>> 
>>> On Wed, Oct 16, 2019 at 3:54 PM Ishan Chattopadhyaya
>>> mailto:ichattopadhy...@gmail.com>> wrote:
 
 Hi,
 Here are the issues that remain to be resolved for 8.3.
 
 LUCENE-8920: Committed, but not resolved. More work remains?
 LUCENE-9005: Patch available, not committed.
 SOLR-13677: Patch available, not committed. Need another day to
 complete cleanup and tests.
 
 I'll wait until all of them are finished and then proceed to build the 
 RC1.
 Thanks and regards,
 Ishan
 
 On Tue, Oct 15, 2019 at 2:58 PM Ishan Chattopadhyaya
 mailto:ichattopadhy...@gmail.com>> wrote:
> 
> Sure, Noble, thanks! Next time, please use a single commit to revert
> such features (you just used up 3 commits). branch_8_3's history is
> now littered with SOLR-13821 commits and reverts that shouldn't have
> been there :-)
> 
> Thanks, Jan!
> 
> On Tue, Oct 15, 2019 at 12:17 AM Noble Paul  > wrote:
>> 
>> Hi,
>> I'll revert the package store commits related to SOLR-13821 in the 
>> 8.3
>> branch. It is supposed to be used by the (SOLR-13822) and it is not a
>> part of the 8.3 release.
>> --Noble
>> 
>> On Tue, Oct 15, 2019 at 5:22 AM Adrien Grand > > wrote:
>>> 
>>> Hi Ishan,
>>> 
>>> The release is no longer blocked on LUCENE-8920.
>>> 
>>> On Thu, Oct 10, 2019 at 6:18 PM Ishan Chattopadhyaya
>>> mailto:ichattopadhy...@gmail.com>> 
>>> wrote:
 
 +1, Ignacio. Please feel free to do the needful, I'll wait until 
 this is resolved.
 
 +1, Jan. Sure, I think we should get it in!
 
 
 On Thu, 10 Oct, 2019, 5:45 PM Đạt Cao Mạnh, 
 mailto:caomanhdat...@gmail.com>> wrote:
> 
> Hi Ishan,
> 
> I pushed the fix to branch_8_3.
> 
> On Thu, Oct 10, 2019 at 11:27 AM Jan Høydahl 
> mailto:jan@cominvent.com>> wrote:
>> 
>> Ishan, I'd like to get 
>> https://issues.apache.org/jira/browse/SOLR-13665 
>>  included, 
>> since without it Solr won't work with SSL against Zookeeper.
>> 
>> --
>> Jan Høydahl, search solution architect

Re: 8.3 release

[Ishan Chattopadhyaya]

Sure Shalin, please go ahead. I'm still waiting for SOLR-13677 to be
resolved.
Thanks!

On Fri, 18 Oct, 2019, 10:24 AM Shalin Shekhar Mangar, <
shalinman...@gmail.com> wrote:

> Hi Ishan,
>
> Is it okay to push https://issues.apache.org/jira/browse/SOLR-13843 to
> 8.3 release? The patch is ready and tested and all I need is to commit and
> merge it to the various branches.
>
> On Thu, Oct 17, 2019 at 4:37 AM Jan Høydahl  wrote:
>
>> https://issues.apache.org/jira/browse/SOLR-13835 is merged.
>>
>> --
>> Jan Høydahl, search solution architect
>> Cominvent AS - www.cominvent.com
>>
>> 16. okt. 2019 kl. 22:15 skrev Cassandra Targett :
>>
>> Done, Ishan, thanks!
>>
>> Cassandra
>> On Oct 16, 2019, 2:37 PM -0500, Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com>, wrote:
>>
>> +1, Cassandra! Thanks.
>>
>> On Wed, 16 Oct, 2019, 11:41 PM Cassandra Targett, 
>> wrote:
>>
>>> Sorry, I meant branch_8_3.
>>>
>>> Cassandra
>>> On Oct 16, 2019, 12:59 PM -0500, Cassandra Targett <
>>> casstarg...@gmail.com>, wrote:
>>>
>>> I just committed to master and branch_8x
>>> https://issues.apache.org/jira/browse/SOLR-12786 to update the versions
>>> of tools we use for building the Ref Guide. I’d like to commit that into
>>> branch_8_x if you don’t mind, Ishan? It’s not urgent, though.
>>>
>>> Cassandra
>>> On Oct 16, 2019, 11:36 AM -0500, Alan Woodward ,
>>> wrote:
>>>
>>> LUCENE-9005 is committed.
>>>
>>> On 16 Oct 2019, at 17:12, Jan Høydahl  wrote:
>>>
>>> SOLR-13835  is also
>>> almost there.
>>>
>>> Jan Høydahl
>>>
>>> 16. okt. 2019 kl. 16:53 skrev Adrien Grand :
>>>
>>> Hi Ishan,
>>>
>>> LUCENE-8920 needs more work indeed, but it is not blocking this release.
>>>
>>> On Wed, Oct 16, 2019 at 3:54 PM Ishan Chattopadhyaya
>>>  wrote:
>>>
>>>
>>> Hi,
>>>
>>> Here are the issues that remain to be resolved for 8.3.
>>>
>>>
>>> LUCENE-8920: Committed, but not resolved. More work remains?
>>>
>>> LUCENE-9005: Patch available, not committed.
>>>
>>> SOLR-13677: Patch available, not committed. Need another day to
>>>
>>> complete cleanup and tests.
>>>
>>>
>>> I'll wait until all of them are finished and then proceed to build the
>>> RC1.
>>>
>>> Thanks and regards,
>>>
>>> Ishan
>>>
>>>
>>> On Tue, Oct 15, 2019 at 2:58 PM Ishan Chattopadhyaya
>>>
>>>  wrote:
>>>
>>>
>>> Sure, Noble, thanks! Next time, please use a single commit to revert
>>>
>>> such features (you just used up 3 commits). branch_8_3's history is
>>>
>>> now littered with SOLR-13821 commits and reverts that shouldn't have
>>>
>>> been there :-)
>>>
>>>
>>> Thanks, Jan!
>>>
>>>
>>> On Tue, Oct 15, 2019 at 12:17 AM Noble Paul 
>>> wrote:
>>>
>>>
>>> Hi,
>>>
>>> I'll revert the package store commits related to SOLR-13821 in the 8.3
>>>
>>> branch. It is supposed to be used by the (SOLR-13822) and it is not a
>>>
>>> part of the 8.3 release.
>>>
>>> --Noble
>>>
>>>
>>> On Tue, Oct 15, 2019 at 5:22 AM Adrien Grand  wrote:
>>>
>>>
>>> Hi Ishan,
>>>
>>>
>>> The release is no longer blocked on LUCENE-8920.
>>>
>>>
>>> On Thu, Oct 10, 2019 at 6:18 PM Ishan Chattopadhyaya
>>>
>>>  wrote:
>>>
>>>
>>> +1, Ignacio. Please feel free to do the needful, I'll wait until this is
>>> resolved.
>>>
>>>
>>> +1, Jan. Sure, I think we should get it in!
>>>
>>>
>>>
>>> On Thu, 10 Oct, 2019, 5:45 PM Đạt Cao Mạnh, 
>>> wrote:
>>>
>>>
>>> Hi Ishan,
>>>
>>>
>>> I pushed the fix to branch_8_3.
>>>
>>>
>>> On Thu, Oct 10, 2019 at 11:27 AM Jan Høydahl 
>>> wrote:
>>>
>>>
>>> Ishan, I'd like to get https://issues.apache.org/jira/browse/SOLR-13665
>>> included, since without it Solr won't work with SSL against Zookeeper.
>>>
>>>
>>> --
>>>
>>> Jan Høydahl, search solution architect
>>>
>>> Cominvent AS - www.cominvent.com
>>>
>>>
>>> 10. okt. 2019 kl. 11:45 skrev Ignacio Vera :
>>>
>>>
>>> Hi Ishan,
>>>
>>>
>>> Thanks for taking care of the release. We have a blocker in Lucene (see
>>> https://issues.apache.org/jira/browse/LUCENE-8920). I remember that was
>>> an issue for the 8.2.0 release and it was reverted and naked as a blocker
>>> for this release. Maybe we should completely reverted until we have a
>>> better solution? let see what Mike thinks about it.
>>>
>>>
>>> Thanks,
>>>
>>>
>>> Ignacio
>>>
>>>
>>> On Wed, Oct 9, 2019 at 4:51 PM Uwe Schindler  wrote:
>>>
>>>
>>> Hi,
>>>
>>>
>>> I also had a customer complaining about this. I have the feeling it also
>>> happens from time to time during inter node comm, which uses solrj, too.
>>>
>>>
>>> Uwe
>>>
>>>
>>> Am October 9, 2019 1:38:00 PM UTC schrieb Ishan Chattopadhyaya <
>>> ichattopadhy...@gmail.com>:
>>>
>>>
>>> +1, Dat! Please go ahead.
>>>
>>>
>>> On Wed, 9 Oct, 2019, 2:33 PM Andrzej Białecki,  wrote:
>>>
>>>
>>> It’s marked as Minor in Jira, but after reading the description it
>>> sounds scary - IMHO it should be at least well investigated before 8.3 in
>>> order to determine whether it causes real damage (apart from looking scary
>>> and filling the logs).
>>>
>>>
>>> +1 from