Re: [jira] [Updated] (LUCENE-9267) The documentation of getQueryBuildTime function reports a wrong time unit.

2020-03-07 Thread Erick Erickson 
WDYT about returning milliseconds? It seems silly/confusing to have one method 
return milliseconds and another nanoseconds. I suppose the calling code would 
have to be examined to see what the dependencies are

Best,
Erick

> On Mar 7, 2020, at 09:57, Pierre-Luc Perron (Jira)  wrote:
> 
> 
> [ 
> https://issues.apache.org/jira/browse/LUCENE-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>  ]
> 
> Pierre-Luc Perron updated LUCENE-9267:
> --
>Description: 
> As per documentation, the 
> [MatchingQueries|https://lucene.apache.org/core/8_4_1/monitor/org/apache/lucene/monitor/MatchingQueries.html]
>  class returns both getQueryBuildTime and getSearchTime in milliseconds. The 
> code shows 
> [searchTime|https://github.com/apache/lucene-solr/blob/320578274be74a18ce150b604d28a740545fde48/lucene/monitor/src/java/org/apache/lucene/monitor/CandidateMatcher.java#L112]
>  returning milliseconds. However, the code shows 
> [buildTime|https://github.com/apache/lucene-solr/blob/320578274be74a18ce150b604d28a740545fde48/lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java#L280]
>  returning nanoseconds.
> 
> The patch changes the documentation of getQueryBuildTime to report 
> nanoseconds instead of milliseconds.
> 
>  was:
> As per documentation, the 
> [MatchingQueries|https://lucene.apache.org/core/8_4_1/monitor/org/apache/lucene/monitor/MatchingQueries.html]
>  class returns both getQueryBuildTime and getSearchTime in milliseconds. The 
> code shows 
> [searchTime|https://github.com/apache/lucene-solr/blob/320578274be74a18ce150b604d28a740545fde48/lucene/monitor/src/java/org/apache/lucene/monitor/CandidateMatcher.java#L112]
>  returning milliseconds. However, the code shows 
> [buildTime|https://github.com/apache/lucene-solr/blob/320578274be74a18ce150b604d28a740545fde48/lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java#L280]
>  returning nanoseconds.
> 
> The patch changes the documentation of getQueryBuildTime to report 
> nanoseconds instead of milliseconds.
> 
> Edit: add reference to github [pull 
> request|https://github.com/apache/lucene-solr/pull/1330]
> 
> 
>> The documentation of getQueryBuildTime function reports a wrong time unit.
>> --
>> 
>>Key: LUCENE-9267
>>URL: https://issues.apache.org/jira/browse/LUCENE-9267
>>Project: Lucene - Core
>> Issue Type: Task
>> Components: modules/other
>>   Affects Versions: 8.2, 8.3, 8.4
>>   Reporter: Pierre-Luc Perron
>>   Priority: Trivial
>> Labels: documentation, newbie, pull-request-available
>>Attachments: LUCENE-9267.patch
>> 
>> Time Spent: 10m
>> Remaining Estimate: 0h
>> 
>> As per documentation, the 
>> [MatchingQueries|https://lucene.apache.org/core/8_4_1/monitor/org/apache/lucene/monitor/MatchingQueries.html]
>>  class returns both getQueryBuildTime and getSearchTime in milliseconds. The 
>> code shows 
>> [searchTime|https://github.com/apache/lucene-solr/blob/320578274be74a18ce150b604d28a740545fde48/lucene/monitor/src/java/org/apache/lucene/monitor/CandidateMatcher.java#L112]
>>  returning milliseconds. However, the code shows 
>> [buildTime|https://github.com/apache/lucene-solr/blob/320578274be74a18ce150b604d28a740545fde48/lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java#L280]
>>  returning nanoseconds.
>> The patch changes the documentation of getQueryBuildTime to report 
>> nanoseconds instead of milliseconds.
> 
> 
> 
> --
> This message was sent by Atlassian Jira
> (v8.3.4#803005)
> 
> -
> To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
> For additional commands, e-mail: issues-h...@lucene.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

RE: 8.5 release

2020-03-07 Thread Uwe Schindler 
Hi,

 

FYI, I cleaned, renamed, and changed the Jenkins Jobs, so the 8.5 branch is in 
the loop on ASF Jenkins and Policeman Jenkins.

 

Uwe

 

-

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: u...@thetaphi.de

 

From: Alan Woodward  
Sent: Wednesday, March 4, 2020 5:35 PM
To: dev@lucene.apache.org
Subject: Re: 8.5 release

 

I’ve created a branch for the 8.5 release (`branch_8_5`) and pushed it to the 
apache repository.  We’re now at feature freeze, so only bug fixes should be 
pushed to the branch.

 

I can see from 
https://issues.apache.org/jira/issues/?jql=project%20in%20(SOLR%2C%20LUCENE)%20AND%20status%20in%20(Open%2C%20Reopened)%20AND%20priority%20%3D%20Blocker%20AND%20fixVersion%20%3D%208.5%20ORDER%20BY%20priority%20DESC
 

  that we have 4 tickets marked as Blockers for this release.  I plan to build 
a first release candidate next Monday, which gives us a few days to resolve 
these.  If that’s not going to be long enough, please let me know.

 

Uwe, Steve, can one of you start the Jenkins tasks for the new branch?

 

Thanks, Alan





On 3 Mar 2020, at 14:50, Alan Woodward mailto:romseyg...@gmail.com> > wrote:

 

PSA: I’ve had to generate a new GPG key for this release, and it takes a while 
for it to get mirrored to the lucene KEYS file.  I’ll hold off cutting the 
branch until everything is ready, so it will probably now be tomorrow UK time 
before I start the release proper.




On 25 Feb 2020, at 07:49, Noble Paul mailto:noble.p...@gmail.com> > wrote:

+1

On Wed, Feb 19, 2020 at 9:35 PM Ignacio Vera mailto:iver...@gmail.com> > wrote:




+1

On Tue, Feb 18, 2020 at 7:26 PM Jan Høydahl mailto:jan@cominvent.com> > wrote:




+1

That should give us time to update release docs for the new website too.

Jan Høydahl

18. feb. 2020 kl. 18:28 skrev Adrien Grand mailto:jpou...@gmail.com> >:


+1

On Tue, Feb 18, 2020 at 4:58 PM Alan Woodward mailto:romseyg...@gmail.com> > wrote:




Hi all,

It’s been a while since we released lucene-solr 8.4, and we’ve accumulated 
quite a few nice new features since then.  I’d like to volunteer to be a 
release manager for an 8.5 release.  If there's agreement, then I plan to cut 
the release branch two weeks today, on Tuesday 3rd March.

- Alan
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org 
 
For additional commands, e-mail: dev-h...@lucene.apache.org 
 



--
Adrien




-- 
-
Noble Paul

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org 
 
For additional commands, e-mail: dev-h...@lucene.apache.org