Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-13 Thread Nhat Nguyen
Hi Mayya,

I would like to backport LUCENE-9935
, which enables
bulk-merge for stored fields with index sort, to 8.x this weekend. The
patch is ready , but we
prefer to give CI some cycles before backporting. Please let me know if
it's okay with the release plan.

Thanks,
Nhat

On Thu, May 13, 2021 at 12:44 PM Gus Heck  wrote:

> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be
> investigated before 8.9, maybe make it a blocker?
>
> On Thu, May 13, 2021 at 1:35 AM Robert Muir  wrote:
>
>> Mayya, I created backport for Adrien's issue here, to try to help out:
>> https://github.com/apache/lucene-solr/pull/2495
>>
>> Personally, I felt that merging non-trivial changes from main branch
>> to 8.x has some additional risks when cherry-picking:
>> * structural changes in main branch making merging more difficult
>> (e.g. LUCENE-9705 reorganization of codec versioning, great change
>> moving forwards though)
>> * there are many style changes due to spotless in main branch which
>> add noise to merging against old code.
>> * In the specific case of LUCENE-9827, the usual additional tricky
>> backwards compatibility for 8.x must be added in the backport (due to
>> minor version bumps there) which can go wrong.
>>
>> I still think that particular change is worth considering for 8.9, it
>> isn't just a performance bug but also a huge improvement to test
>> coverage that helps combat risks.
>>
>> But we should still take some precautions when releasing an 8.x IMO:
>> * be mindful of what we are backporting and the risks involved: it is
>> harder.
>> * try to let jenkins bake changes in 8.x branches for longer than
>> usual? even a few days really helps.
>>
>> On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
>>  wrote:
>> >
>> > Thanks everyone,
>> >
>> > Adrien, I  am happy to try to be a release manager for this release.
>> >
>> > Adrien, and Gus, please let me know when your changes are merged to 8.x
>> >
>> >
>> >
>> > On Tue, May 11, 2021 at 10:38 AM Gus Heck  wrote:
>> >>
>> >> I'm also looking to find time to get
>> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
>> I've recently completed the back port of 2/3 of the lucene tickets that are
>> related, and hope to work on the third tomorrow
>> >>
>> >> I had some feedback there, but I think folks were waiting for the
>> version integrated with the final form of the Lucene tickets before delving
>> further. Hopefully this week I can start on a patch that does that.
>> >>
>> >> On Tue, May 11, 2021 at 10:25 AM Adrien Grand 
>> wrote:
>> >>>
>> >>> I would like to backport LUCENE-9827 before we release 8.9, a
>> performance regression to stored fields merges. I'll work on this as soon
>> as possible.
>> >>>
>> >>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand 
>> wrote:
>> 
>>  +1
>> 
>>  Mayya, are you volunteering to be the release manager?
>> 
>>  Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com> a écrit :
>> >
>> > +1
>> >
>> > On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova <
>> mayya.sharip...@elastic.co.invalid> wrote:
>> >>
>> >> Hello everyone,
>> >> I was wondering if we can have a 8.9.0 release. It has been more
>> than 3 months since 8.8.0 was released.
>> >> 8.9.0 doesn't need to be the last release in the 8.x series.
>> >>
>> >> Thanks.
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Adrien
>> >>
>> >>
>> >>
>> >> --
>> >> http://www.needhamsoftware.com (work)
>> >> http://www.the111shift.com (play)
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>
>>
>
> --
> http://www.needhamsoftware.com (work)
> http://www.the111shift.com (play)
>


Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-13 Thread Gus Heck
Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be
investigated before 8.9, maybe make it a blocker?

On Thu, May 13, 2021 at 1:35 AM Robert Muir  wrote:

> Mayya, I created backport for Adrien's issue here, to try to help out:
> https://github.com/apache/lucene-solr/pull/2495
>
> Personally, I felt that merging non-trivial changes from main branch
> to 8.x has some additional risks when cherry-picking:
> * structural changes in main branch making merging more difficult
> (e.g. LUCENE-9705 reorganization of codec versioning, great change
> moving forwards though)
> * there are many style changes due to spotless in main branch which
> add noise to merging against old code.
> * In the specific case of LUCENE-9827, the usual additional tricky
> backwards compatibility for 8.x must be added in the backport (due to
> minor version bumps there) which can go wrong.
>
> I still think that particular change is worth considering for 8.9, it
> isn't just a performance bug but also a huge improvement to test
> coverage that helps combat risks.
>
> But we should still take some precautions when releasing an 8.x IMO:
> * be mindful of what we are backporting and the risks involved: it is
> harder.
> * try to let jenkins bake changes in 8.x branches for longer than
> usual? even a few days really helps.
>
> On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
>  wrote:
> >
> > Thanks everyone,
> >
> > Adrien, I  am happy to try to be a release manager for this release.
> >
> > Adrien, and Gus, please let me know when your changes are merged to 8.x
> >
> >
> >
> > On Tue, May 11, 2021 at 10:38 AM Gus Heck  wrote:
> >>
> >> I'm also looking to find time to get
> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
> I've recently completed the back port of 2/3 of the lucene tickets that are
> related, and hope to work on the third tomorrow
> >>
> >> I had some feedback there, but I think folks were waiting for the
> version integrated with the final form of the Lucene tickets before delving
> further. Hopefully this week I can start on a patch that does that.
> >>
> >> On Tue, May 11, 2021 at 10:25 AM Adrien Grand 
> wrote:
> >>>
> >>> I would like to backport LUCENE-9827 before we release 8.9, a
> performance regression to stored fields merges. I'll work on this as soon
> as possible.
> >>>
> >>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand 
> wrote:
> 
>  +1
> 
>  Mayya, are you volunteering to be the release manager?
> 
>  Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> a écrit :
> >
> > +1
> >
> > On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova <
> mayya.sharip...@elastic.co.invalid> wrote:
> >>
> >> Hello everyone,
> >> I was wondering if we can have a 8.9.0 release. It has been more
> than 3 months since 8.8.0 was released.
> >> 8.9.0 doesn't need to be the last release in the 8.x series.
> >>
> >> Thanks.
> >>>
> >>>
> >>>
> >>> --
> >>> Adrien
> >>
> >>
> >>
> >> --
> >> http://www.needhamsoftware.com (work)
> >> http://www.the111shift.com (play)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>

-- 
http://www.needhamsoftware.com (work)
http://www.the111shift.com (play)