[jira] [Commented] (LUCENE-8352) Make TokenStreamComponents final

[ https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618834#comment-16618834 ] Adrien Grand commented on LUCENE-8352: -- +1 Great to see that the patch is simpler than I expected.

[jira] [Commented] (LUCENE-8482) Boosting by geo distance

[ https://issues.apache.org/jira/browse/LUCENE-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618121#comment-16618121 ] Adrien Grand commented on LUCENE-8482: -- bq. New patch where we approximate using a box query which

[jira] [Commented] (LUCENE-8505) IndexWriter#addIndices should not sort indices if they are not already sorted

[ https://issues.apache.org/jira/browse/LUCENE-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617770#comment-16617770 ] Adrien Grand commented on LUCENE-8505: -- +1 You only plan to merge this to master, right? We still

[jira] [Commented] (LUCENE-8501) An ability to define the sum method for custom term frequencies

[ https://issues.apache.org/jira/browse/LUCENE-8501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617541#comment-16617541 ] Adrien Grand commented on LUCENE-8501: -- bq. In my case I'd be a bit worried about the loss of

[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader

[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617534#comment-16617534 ] Adrien Grand commented on LUCENE-8503: -- +1 > Simplify unwrapping Filter*Reader >

[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader

[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617289#comment-16617289 ] Adrien Grand commented on LUCENE-8503: -- I'm a bit on the fence about adding such an API to ease

[jira] [Commented] (LUCENE-8501) An ability to define the sum method for custom term frequencies

[ https://issues.apache.org/jira/browse/LUCENE-8501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617272#comment-16617272 ] Adrien Grand commented on LUCENE-8501: -- Storing floats as term frequencies not only raises issues

[jira] [Commented] (LUCENE-8502) Allow access to delegate in FilterCodecReader

[ https://issues.apache.org/jira/browse/LUCENE-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617212#comment-16617212 ] Adrien Grand commented on LUCENE-8502: -- +1 > Allow access to delegate in FilterCodecReader >

[jira] [Commented] (LUCENE-8498) Deprecate/Remove LowerCaseTokenizer

[ https://issues.apache.org/jira/browse/LUCENE-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614980#comment-16614980 ] Adrien Grand commented on LUCENE-8498: -- +1 > Deprecate/Remove LowerCaseTokenizer >

[jira] [Commented] (LUCENE-8490) Separate scoring features from Queries

[ https://issues.apache.org/jira/browse/LUCENE-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614918#comment-16614918 ] Adrien Grand commented on LUCENE-8490: -- One thing that annoys me a bit with the patch is that you

[jira] [Commented] (LUCENE-8490) Separate scoring features from Queries

[ https://issues.apache.org/jira/browse/LUCENE-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614917#comment-16614917 ] Adrien Grand commented on LUCENE-8490: -- One thing that annoys me a bit with the patch is that you

[jira] [Commented] (LUCENE-8496) Explore selective dimension indexing in BKDReader/Writer

[ https://issues.apache.org/jira/browse/LUCENE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614910#comment-16614910 ] Adrien Grand commented on LUCENE-8496: -- It is a pity that the patch is so large given that the

[jira] [Commented] (LUCENE-8489) Provide List type constructors for BaseCompositeReader based Readers

[ https://issues.apache.org/jira/browse/LUCENE-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608565#comment-16608565 ] Adrien Grand commented on LUCENE-8489: -- bq. but users will think positively if the API supports

[jira] [Commented] (LUCENE-8482) Boosting by geo distance

[ https://issues.apache.org/jira/browse/LUCENE-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607126#comment-16607126 ] Adrien Grand commented on LUCENE-8482: -- Indeed I had misread! > Boosting by geo distance >

[jira] [Commented] (LUCENE-8482) Boosting by geo distance

[ https://issues.apache.org/jira/browse/LUCENE-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607101#comment-16607101 ] Adrien Grand commented on LUCENE-8482: -- This looks promising! There seems to be an issue with

[jira] [Commented] (LUCENE-7862) Should BKD cells store their min/max packed values?

[ https://issues.apache.org/jira/browse/LUCENE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605853#comment-16605853 ] Adrien Grand commented on LUCENE-7862: -- The improvement in QPS look indeed very significant in some

[jira] [Commented] (LUCENE-8478) combine TermScorer constructors' implementation

[ https://issues.apache.org/jira/browse/LUCENE-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605745#comment-16605745 ] Adrien Grand commented on LUCENE-8478: -- bq. so not sure if this is worth pursuing further or not.

[jira] [Reopened] (LUCENE-8342) Can we enforce more properties on fields like uniquness

[ https://issues.apache.org/jira/browse/LUCENE-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand reopened LUCENE-8342: -- Reopen: was closed by mistake. > Can we enforce more properties on fields like uniquness >

[jira] [Commented] (LUCENE-8481) Javadocs should no longer reference RAMDirectory

[ https://issues.apache.org/jira/browse/LUCENE-8481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604268#comment-16604268 ] Adrien Grand commented on LUCENE-8481: -- This patch still looks like a net improvement to me by

[jira] [Commented] (LUCENE-8483) Enforce that Scorer cannot have a null Weight

[ https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604118#comment-16604118 ] Adrien Grand commented on LUCENE-8483: -- bq. I renamed FakeScorable to ScoreAndDoc +1 let's also

[jira] [Commented] (LUCENE-8484) Allow SubReaderWrapper to filter out entire readers

[ https://issues.apache.org/jira/browse/LUCENE-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603095#comment-16603095 ] Adrien Grand commented on LUCENE-8484: -- I see you just made it hard coded. +1 > Allow

[jira] [Commented] (LUCENE-8484) Allow SubReaderWrapper to filter out entire readers

[ https://issues.apache.org/jira/browse/LUCENE-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603079#comment-16603079 ] Adrien Grand commented on LUCENE-8484: -- What happens when a segment gets removed, will there be a

[jira] [Commented] (LUCENE-8483) Enforce that Scorer cannot have a null Weight

[ https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603002#comment-16603002 ] Adrien Grand commented on LUCENE-8483: -- Can we somehow avoid the FakeWeight in ValuesSourceScorer?

[jira] [Resolved] (LUCENE-8340) Efficient boosting by recency

[ https://issues.apache.org/jira/browse/LUCENE-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8340. -- Resolution: Fixed Fix Version/s: master (8.0) > Efficient boosting by recency >

[jira] [Commented] (LUCENE-6247) artifacts are half a gigabyte

[ https://issues.apache.org/jira/browse/LUCENE-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602960#comment-16602960 ] Adrien Grand commented on LUCENE-6247: -- I'm decreasing the priority from blocker to major since

[jira] [Updated] (LUCENE-6247) artifacts are half a gigabyte

[ https://issues.apache.org/jira/browse/LUCENE-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-6247: - Priority: Major (was: Blocker) > artifacts are half a gigabyte > -

[jira] [Created] (LUCENE-8482) Boosting by geo distance

Adrien Grand created LUCENE-8482: Summary: Boosting by geo distance Key: LUCENE-8482 URL: https://issues.apache.org/jira/browse/LUCENE-8482 Project: Lucene - Core Issue Type: New Feature

[jira] [Commented] (LUCENE-8481) Javadocs should no longer reference RAMDirectory

[ https://issues.apache.org/jira/browse/LUCENE-8481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602837#comment-16602837 ] Adrien Grand commented on LUCENE-8481: -- OK fair enough. > Javadocs should no longer reference

[jira] [Commented] (LUCENE-8340) Efficient boosting by recency

[ https://issues.apache.org/jira/browse/LUCENE-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602831#comment-16602831 ] Adrien Grand commented on LUCENE-8340: -- Good call, the way that the leadCost was leveraged was not

[jira] [Commented] (LUCENE-6228) Do not expose full-fledged scorers in LeafCollector.setScorer

[ https://issues.apache.org/jira/browse/LUCENE-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602771#comment-16602771 ] Adrien Grand commented on LUCENE-6228: -- I think FilterScorable should not delegate

[jira] [Commented] (LUCENE-8481) Javadocs should no longer reference RAMDirectory

[ https://issues.apache.org/jira/browse/LUCENE-8481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602711#comment-16602711 ] Adrien Grand commented on LUCENE-8481: -- I saw LUCENE-8474 but was thinking that we do not only need

[jira] [Commented] (SOLR-12074) Add numeric typed equivalents to StrField

[ https://issues.apache.org/jira/browse/SOLR-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602451#comment-16602451 ] Adrien Grand commented on SOLR-12074: - bq. I think Lucene allows one field to have a Terms index &

[jira] [Created] (LUCENE-8481) Javadocs should no longer reference RAMDirectory

Adrien Grand created LUCENE-8481: Summary: Javadocs should no longer reference RAMDirectory Key: LUCENE-8481 URL: https://issues.apache.org/jira/browse/LUCENE-8481 Project: Lucene - Core

[jira] [Commented] (LUCENE-8476) Bug fix and optimizations in UserDictionary(KoreanAnalyzer)

[ https://issues.apache.org/jira/browse/LUCENE-8476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602449#comment-16602449 ] Adrien Grand commented on LUCENE-8476: -- The problem with calling BufferedReader#close is that it

[jira] [Updated] (LUCENE-8340) Efficient boosting by recency

[ https://issues.apache.org/jira/browse/LUCENE-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8340: - Summary: Efficient boosting by recency (was: Allow to boost by recency) > Efficient boosting

[jira] [Commented] (LUCENE-8478) combine TermScorer constructors' implementation

[ https://issues.apache.org/jira/browse/LUCENE-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602446#comment-16602446 ] Adrien Grand commented on LUCENE-8478: -- I'm not sure this is a net win since it requires the

[jira] [Commented] (LUCENE-8340) Allow to boost by recency

[ https://issues.apache.org/jira/browse/LUCENE-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602299#comment-16602299 ] Adrien Grand commented on LUCENE-8340: -- So I went back to this patch and did some testing. I played

[jira] [Commented] (LUCENE-8422) Add Matches iteration to interval queries

[ https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602273#comment-16602273 ] Adrien Grand commented on LUCENE-8422: -- +1 > Add Matches iteration to interval queries >

[jira] [Commented] (LUCENE-8477) Improve handling of inner disjunctions in intervals

[ https://issues.apache.org/jira/browse/LUCENE-8477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602195#comment-16602195 ] Adrien Grand commented on LUCENE-8477: -- I'd be tempted to just document this behavior for now. I'm

[jira] [Commented] (LUCENE-8422) Add Matches iteration to interval queries

[ https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602180#comment-16602180 ] Adrien Grand commented on LUCENE-8422: -- I was thinking of something like having a MatchesUtils

[jira] [Commented] (LUCENE-8422) Add Matches iteration to interval queries

[ https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602123#comment-16602123 ] Adrien Grand commented on LUCENE-8422: -- bq. All sources return null from MatchesIterator#getQuery()

[jira] [Commented] (LUCENE-8422) Add Matches iteration to interval queries

[ https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602118#comment-16602118 ] Adrien Grand commented on LUCENE-8422: -- +1 to the patch in general, only two minor comments: -

[jira] [Commented] (LUCENE-6228) Do not expose full-fledged scorers in LeafCollector.setScorer

[ https://issues.apache.org/jira/browse/LUCENE-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602097#comment-16602097 ] Adrien Grand commented on LUCENE-6228: -- +1 to this patch, let's also make sure we add a note about

[jira] [Commented] (SOLR-12535) Remove syntax for providing index boosts in Solr's JSON update syntax

[ https://issues.apache.org/jira/browse/SOLR-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601678#comment-16601678 ] Adrien Grand commented on SOLR-12535: - +1 to remove support for indexing boosts entirely in 8.0 >

[jira] [Commented] (LUCENE-8475) Remove deprecated constants in RamUsageEstimator

[ https://issues.apache.org/jira/browse/LUCENE-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598952#comment-16598952 ] Adrien Grand commented on LUCENE-8475: -- +1 I'll commit next week. Thanks [~dathanasiou]! > Remove

[jira] [Commented] (LUCENE-8472) Soft-deletes merge retention query should be rewritten

[ https://issues.apache.org/jira/browse/LUCENE-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598778#comment-16598778 ] Adrien Grand commented on LUCENE-8472: -- +1 > Soft-deletes merge retention query should be

[jira] [Resolved] (LUCENE-8432) Stop calling comparator even if early termination is not possible

[ https://issues.apache.org/jira/browse/LUCENE-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8432. -- Resolution: Fixed Fix Version/s: master (8.0) 7.5 Merged. Thanks

[jira] [Resolved] (LUCENE-8465) Remove legacy auto-prefix logic from IntersectTermsEnum

[ https://issues.apache.org/jira/browse/LUCENE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8465. -- Resolution: Fixed Fix Version/s: master (8.0) > Remove legacy auto-prefix logic from

[jira] [Resolved] (LUCENE-765) Index package level javadocs needs content

[ https://issues.apache.org/jira/browse/LUCENE-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-765. - Resolution: Fixed Fix Version/s: master (8.0) 7.5 I was still

[jira] [Commented] (LUCENE-8267) Remove memory codecs from the codebase

[ https://issues.apache.org/jira/browse/LUCENE-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597132#comment-16597132 ] Adrien Grand commented on LUCENE-8267: -- +1 to recommend defaults > Remove memory codecs from the

[jira] [Commented] (LUCENE-8471) Expose the number of bytes currently being flushed in IndexWriter

[ https://issues.apache.org/jira/browse/LUCENE-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596581#comment-16596581 ] Adrien Grand commented on LUCENE-8471: -- +1 Let's maybe mention in javadocs that this is a subset of

[jira] [Commented] (LUCENE-8470) Remove Legacy*DocValues classes

[ https://issues.apache.org/jira/browse/LUCENE-8470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596541#comment-16596541 ] Adrien Grand commented on LUCENE-8470: -- Here is a patch. Instead of removing the legacy classes, I

[jira] [Updated] (LUCENE-8470) Remove Legacy*DocValues classes

[ https://issues.apache.org/jira/browse/LUCENE-8470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8470: - Attachment: LUCENE-8470.patch > Remove Legacy*DocValues classes >

[jira] [Updated] (LUCENE-8470) Remove Legacy*DocValues classes

[ https://issues.apache.org/jira/browse/LUCENE-8470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8470: - Attachment: (was: LUCENE-8470.patch) > Remove Legacy*DocValues classes >

[jira] [Updated] (LUCENE-8470) Remove Legacy*DocValues classes

[ https://issues.apache.org/jira/browse/LUCENE-8470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8470: - Attachment: LUCENE-8470.patch > Remove Legacy*DocValues classes >

[jira] [Created] (LUCENE-8470) Remove Legacy*DocValues classes

Adrien Grand created LUCENE-8470: Summary: Remove Legacy*DocValues classes Key: LUCENE-8470 URL: https://issues.apache.org/jira/browse/LUCENE-8470 Project: Lucene - Core Issue Type: Task

[jira] [Commented] (LUCENE-8469) Inline calls to the deprecated StringHelper.compare

[ https://issues.apache.org/jira/browse/LUCENE-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596332#comment-16596332 ] Adrien Grand commented on LUCENE-8469: -- Let's also remove StringHelper#compare on master? The patch

[jira] [Commented] (LUCENE-765) Index package level javadocs needs content

[ https://issues.apache.org/jira/browse/LUCENE-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596326#comment-16596326 ] Adrien Grand commented on LUCENE-765: - [~sokolov] I have precommit failures with this patch which

[jira] [Commented] (LUCENE-8466) FrozenBufferedUpdates#apply*Deletes is incorrect when index sorting is enabled

[ https://issues.apache.org/jira/browse/LUCENE-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596122#comment-16596122 ] Adrien Grand commented on LUCENE-8466: -- Maybe we should start thinking about releasing 7.5 because

[jira] [Commented] (LUCENE-8460) Javadoc changes in StoredField

[ https://issues.apache.org/jira/browse/LUCENE-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593741#comment-16593741 ] Adrien Grand commented on LUCENE-8460: -- Looking further at the patch, the "throws

[jira] [Commented] (LUCENE-8466) FrozenBufferedUpdates#apply*Deletes is incorrect when index sorting is enabled

[ https://issues.apache.org/jira/browse/LUCENE-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593652#comment-16593652 ] Adrien Grand commented on LUCENE-8466: -- Maybe rename the test since it doesn't only test delete by

[jira] [Commented] (LUCENE-8374) Reduce reads for sparse DocValues

[ https://issues.apache.org/jira/browse/LUCENE-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593644#comment-16593644 ] Adrien Grand commented on LUCENE-8374: -- Indeed I mentioned skip lists because this is the natural

[jira] [Created] (LUCENE-8466) FrozenBufferedUpdates#apply*Deletes is incorrect when index sorting is enabled

Adrien Grand created LUCENE-8466: Summary: FrozenBufferedUpdates#apply*Deletes is incorrect when index sorting is enabled Key: LUCENE-8466 URL: https://issues.apache.org/jira/browse/LUCENE-8466

[jira] [Commented] (LUCENE-765) Index package level javadocs needs content

[ https://issues.apache.org/jira/browse/LUCENE-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591790#comment-16591790 ] Adrien Grand commented on LUCENE-765: - Unfortunately the patch doesn't apply cleanly, [~sokolov] did

[jira] [Commented] (LUCENE-8432) Stop calling comparator even if early termination is not possible

[ https://issues.apache.org/jira/browse/LUCENE-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591556#comment-16591556 ] Adrien Grand commented on LUCENE-8432: -- I updated the patch to apply on a recent master and renamed

[jira] [Updated] (LUCENE-8432) Stop calling comparator even if early termination is not possible

[ https://issues.apache.org/jira/browse/LUCENE-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8432: - Attachment: LUCENE-8432.patch > Stop calling comparator even if early termination is not

[jira] [Commented] (LUCENE-8465) Remove legacy auto-prefix logic from IntersectTermsEnum

[ https://issues.apache.org/jira/browse/LUCENE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591515#comment-16591515 ] Adrien Grand commented on LUCENE-8465: -- Good call, I'll remove them when pushing. > Remove legacy

[jira] [Commented] (LUCENE-765) Index package level javadocs needs content

[ https://issues.apache.org/jira/browse/LUCENE-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591505#comment-16591505 ] Adrien Grand commented on LUCENE-765: - +1 I'll merge. Thanks [~sokolov]! > Index package level

[jira] [Commented] (LUCENE-8432) Stop calling comparator even if early termination is not possible

[ https://issues.apache.org/jira/browse/LUCENE-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591453#comment-16591453 ] Adrien Grand commented on LUCENE-8432: -- Got it, thanks. There have been a couple of changes to

[jira] [Commented] (LUCENE-8374) Reduce reads for sparse DocValues

[ https://issues.apache.org/jira/browse/LUCENE-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591452#comment-16591452 ] Adrien Grand commented on LUCENE-8374: -- The above numbers are very impressive! Do you have a sense

[jira] [Commented] (LUCENE-8422) Add Matches iteration to interval queries

[ https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591393#comment-16591393 ] Adrien Grand commented on LUCENE-8422: -- I see how putting the logic in IntervalIterator makes

[jira] [Commented] (LUCENE-8460) Javadoc changes in StoredField

[ https://issues.apache.org/jira/browse/LUCENE-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591299#comment-16591299 ] Adrien Grand commented on LUCENE-8460: -- bq. In fact, I think the null check is missing. +1 Let's

[jira] [Commented] (LUCENE-765) Index package level javadocs needs content

[ https://issues.apache.org/jira/browse/LUCENE-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591281#comment-16591281 ] Adrien Grand commented on LUCENE-765: - Thanks Mike, it looks great. Here are some suggestions: - I'm

[jira] [Commented] (LUCENE-8461) Add a Lucene80Codec

[ https://issues.apache.org/jira/browse/LUCENE-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590831#comment-16590831 ] Adrien Grand commented on LUCENE-8461: -- Woops, thanks Steve! > Add a Lucene80Codec >

[jira] [Updated] (LUCENE-8465) Remove legacy auto-prefix logic from IntersectTermsEnum

[ https://issues.apache.org/jira/browse/LUCENE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8465: - Attachment: LUCENE-8465.patch > Remove legacy auto-prefix logic from IntersectTermsEnum >

[jira] [Commented] (LUCENE-8465) Remove legacy auto-prefix logic from IntersectTermsEnum

[ https://issues.apache.org/jira/browse/LUCENE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590389#comment-16590389 ] Adrien Grand commented on LUCENE-8465: -- Here is a patch. > Remove legacy auto-prefix logic from

[jira] [Created] (LUCENE-8465) Remove legacy auto-prefix logic from IntersectTermsEnum

Adrien Grand created LUCENE-8465: Summary: Remove legacy auto-prefix logic from IntersectTermsEnum Key: LUCENE-8465 URL: https://issues.apache.org/jira/browse/LUCENE-8465 Project: Lucene - Core

[jira] [Resolved] (LUCENE-8461) Add a Lucene80Codec

[ https://issues.apache.org/jira/browse/LUCENE-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8461. -- Resolution: Fixed Fix Version/s: master (8.0) > Add a Lucene80Codec >

[jira] [Created] (LUCENE-8464) Implement ConstantScoreScorer#setMinCompetitiveScore

Adrien Grand created LUCENE-8464: Summary: Implement ConstantScoreScorer#setMinCompetitiveScore Key: LUCENE-8464 URL: https://issues.apache.org/jira/browse/LUCENE-8464 Project: Lucene - Core

[jira] [Created] (LUCENE-8463) Early-terminate queries sorted by SortField.DOC

Adrien Grand created LUCENE-8463: Summary: Early-terminate queries sorted by SortField.DOC Key: LUCENE-8463 URL: https://issues.apache.org/jira/browse/LUCENE-8463 Project: Lucene - Core

[jira] [Commented] (LUCENE-8461) Add a Lucene80Codec

[ https://issues.apache.org/jira/browse/LUCENE-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587683#comment-16587683 ] Adrien Grand commented on LUCENE-8461: -- Here is a patch. Lucene70Codec moved to the backward-codecs

[jira] [Updated] (LUCENE-8461) Add a Lucene80Codec

[ https://issues.apache.org/jira/browse/LUCENE-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8461: - Attachment: LUCENE-8461.patch > Add a Lucene80Codec > --- > >

[jira] [Created] (LUCENE-8461) Add a Lucene80Codec

Adrien Grand created LUCENE-8461: Summary: Add a Lucene80Codec Key: LUCENE-8461 URL: https://issues.apache.org/jira/browse/LUCENE-8461 Project: Lucene - Core Issue Type: Improvement

[jira] [Commented] (LUCENE-8448) Slowdown of nested boolean queries after LUCENE-8060

[ https://issues.apache.org/jira/browse/LUCENE-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586005#comment-16586005 ] Adrien Grand commented on LUCENE-8448: -- We now have in impressive speedup on AndHighOrMedMed

[jira] [Commented] (LUCENE-8448) Slowdown of nested boolean queries after LUCENE-8060

[ https://issues.apache.org/jira/browse/LUCENE-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580100#comment-16580100 ] Adrien Grand commented on LUCENE-8448: -- +1 Maybe we need to special case minCompetitiveScore == 0

[jira] [Commented] (LUCENE-8340) Allow to boost by recency

[ https://issues.apache.org/jira/browse/LUCENE-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579796#comment-16579796 ] Adrien Grand commented on LUCENE-8340: -- bq. we need to do some changes to make boolean queries as

[jira] [Commented] (LUCENE-8448) Slowdown of nested boolean queries after LUCENE-8060

[ https://issues.apache.org/jira/browse/LUCENE-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579774#comment-16579774 ] Adrien Grand commented on LUCENE-8448: -- Looks great. Let's add a unit test with fake scorers to

[jira] [Commented] (LUCENE-8452) BKD-based shape indexing benchmarks

[ https://issues.apache.org/jira/browse/LUCENE-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579481#comment-16579481 ] Adrien Grand commented on LUCENE-8452: -- This looks like a nice dataset for benchmarking indeed! >

[jira] [Commented] (LUCENE-8432) Stop calling comparator even if early termination is not possible

[ https://issues.apache.org/jira/browse/LUCENE-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578682#comment-16578682 ] Adrien Grand commented on LUCENE-8432: -- [~khitrin] Could you add a test for these changes? I could

[jira] [Commented] (LUCENE-8452) BKD-based shape indexing benchmarks

[ https://issues.apache.org/jira/browse/LUCENE-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578650#comment-16578650 ] Adrien Grand commented on LUCENE-8452: -- bq. What it actually concerns me is that the dimensions are

[jira] [Commented] (LUCENE-8449) Code Optimizations in FieldTermStack

[ https://issues.apache.org/jira/browse/LUCENE-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578488#comment-16578488 ] Adrien Grand commented on LUCENE-8449: -- If you share a patch created with git-format-patch, we can

[jira] [Commented] (LUCENE-8449) Code Optimizations in FieldTermStack

[ https://issues.apache.org/jira/browse/LUCENE-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578369#comment-16578369 ] Adrien Grand commented on LUCENE-8449: -- You can safely ignore the automated message! > Code

[jira] [Commented] (LUCENE-8447) Add DISJOINT and WITHIN support to LatLonShape queries

[ https://issues.apache.org/jira/browse/LUCENE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573516#comment-16573516 ] Adrien Grand commented on LUCENE-8447: -- +1 I'd just keep the transpose() method as an impl detail

[jira] [Commented] (LUCENE-8449) Code Optimizations in FieldTermStack

[ https://issues.apache.org/jira/browse/LUCENE-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573460#comment-16573460 ] Adrien Grand commented on LUCENE-8449: -- Changes 2, 3 and 4 look good to me. Can you revert 1 in

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573112#comment-16573112 ] Adrien Grand commented on LUCENE-8204: -- +1 > ReqOptSumScorer should leverage sub scorers'

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572971#comment-16572971 ] Adrien Grand commented on LUCENE-8204: -- +1 in general, some minor comments below: {code}

[jira] [Commented] (LUCENE-8439) DisjunctionMaxScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572938#comment-16572938 ] Adrien Grand commented on LUCENE-8439: -- FYI the patch includes some unintended changes in the solr/

[jira] [Commented] (LUCENE-8439) DisjunctionMaxScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572934#comment-16572934 ] Adrien Grand commented on LUCENE-8439: -- +1 > DisjunctionMaxScorer should leverage sub scorers'

[jira] [Commented] (LUCENE-8439) DisjunctionMaxScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571970#comment-16571970 ] Adrien Grand commented on LUCENE-8439: -- I'm curious why you introduced {{wrapTopScoresApprox}}

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571947#comment-16571947 ] Adrien Grand commented on LUCENE-8204: -- Thanks Jim! It looks great in general, I'm just a bit

<    1   2   3   4   5   6   7   8   9   10   >