[jira] [Created] (LUCENE-4892) Create a compressed LiveDocsFormat

2013-03-29 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-4892: Summary: Create a compressed LiveDocsFormat Key: LUCENE-4892 URL: https://issues.apache.org/jira/browse/LUCENE-4892 Project: Lucene - Core Issue Type: New

[jira] [Updated] (LUCENE-4892) Create a compressed LiveDocsFormat

2013-03-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-4892: - Description: There are lots of use-cases where the number of deleted documents is low. This

[jira] [Commented] (LUCENE-4858) Early termination with SortingMergePolicy

2013-03-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617674#comment-13617674 ] Adrien Grand commented on LUCENE-4858: -- [~shaie], maybe you want to take a look at

[jira] [Resolved] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-03-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-4876. -- Resolution: Fixed IndexWriterConfig.clone should clone the MergeScheduler

[jira] [Commented] (LUCENE-4858) Early termination with SortingMergePolicy

2013-03-30 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618091#comment-13618091 ] Adrien Grand commented on LUCENE-4858: -- No problem, enjoy your vacation!

[jira] [Commented] (LUCENE-4858) Early termination with SortingMergePolicy

2013-03-31 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618349#comment-13618349 ] Adrien Grand commented on LUCENE-4858: -- I like making it more robust by ensuring the

[jira] [Commented] (LUCENE-4888) SloppyPhraseScorer calls DocsAndPositionsEnum.advance with target = -1

2013-04-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619969#comment-13619969 ] Adrien Grand commented on LUCENE-4888: -- I plan to commit soon unless someone

[jira] [Commented] (LUCENE-4858) Early termination with SortingMergePolicy

2013-04-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619971#comment-13619971 ] Adrien Grand commented on LUCENE-4858: -- bq. We can deal w/ addIndexes later. If it

[jira] [Commented] (LUCENE-5493) Rename Sorter, NumericDocValuesSorter, and fix javadocs

2014-03-06 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922507#comment-13922507 ] Adrien Grand commented on LUCENE-5493: -- +1 on making those classes wrap a `Sort`. I

[jira] [Commented] (LUCENE-5493) Rename Sorter, NumericDocValuesSorter, and fix javadocs

2014-03-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923694#comment-13923694 ] Adrien Grand commented on LUCENE-5493: -- This is a very nice cleanup, and the ability

[jira] [Commented] (LUCENE-5500) SortingMergePolicy should error if the Sort refers to the score

2014-03-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923990#comment-13923990 ] Adrien Grand commented on LUCENE-5500: -- +1 SortingMergePolicy should error if the

[jira] [Created] (LUCENE-5501) Out-of-order collection testing

2014-03-07 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-5501: Summary: Out-of-order collection testing Key: LUCENE-5501 URL: https://issues.apache.org/jira/browse/LUCENE-5501 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-5501) Out-of-order collection testing

2014-03-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5501: - Attachment: LUCENE-5501.patch Here is a simple patch I've been playing with: -

[jira] [Commented] (LUCENE-5501) Out-of-order collection testing

2014-03-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924032#comment-13924032 ] Adrien Grand commented on LUCENE-5501: -- I was not thinking about these collectors at

[jira] [Commented] (LUCENE-5502) equals method of TermsFilter might equate two different filters

2014-03-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924912#comment-13924912 ] Adrien Grand commented on LUCENE-5502: -- Thank you Igor, I think this is a very bad

[jira] [Resolved] (LUCENE-5314) Decide on whether the central class of the sorting API should be a sorter or a comparator

2014-03-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5314. -- Resolution: Fixed Superseded by LUCENE-5493. Decide on whether the central class of the

[jira] [Resolved] (LUCENE-5501) Out-of-order collection testing

2014-03-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5501. -- Resolution: Fixed Fix Version/s: 4.8 Thanks for reviewing, Mike! Out-of-order

[jira] [Commented] (LUCENE-5502) equals method of TermsFilter might equate two different filters

2014-03-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925918#comment-13925918 ] Adrien Grand commented on LUCENE-5502: -- Thank you Igor, the patch looks good to me!

[jira] [Commented] (LUCENE-5502) equals method of TermsFilter might equate two different filters

2014-03-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13926088#comment-13926088 ] Adrien Grand commented on LUCENE-5502: -- Thanks for the review, Simon. I'll commit

[jira] [Reopened] (LUCENE-5501) Out-of-order collection testing

2014-03-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand reopened LUCENE-5501: -- Out-of-order collection testing --- Key:

[jira] [Updated] (LUCENE-5501) Out-of-order collection testing

2014-03-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5501: - Attachment: LUCENE-5501-2.patch Thinking about it again, I realized it would be possible to

[jira] [Resolved] (LUCENE-5502) equals method of TermsFilter might equate two different filters

2014-03-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5502. -- Resolution: Fixed Fix Version/s: 4.8 Assignee: Adrien Grand Committed, thanks

[jira] [Created] (LUCENE-5526) Forced merges

2014-03-14 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-5526: Summary: Forced merges Key: LUCENE-5526 URL: https://issues.apache.org/jira/browse/LUCENE-5526 Project: Lucene - Core Issue Type: Improvement

[jira] [Created] (LUCENE-5527) Make the Collector API work per-segment

2014-03-14 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-5527: Summary: Make the Collector API work per-segment Key: LUCENE-5527 URL: https://issues.apache.org/jira/browse/LUCENE-5527 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-5527) Make the Collector API work per-segment

2014-03-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5527: - Description: Spin-off of LUCENE-5299. LUCENE-5229 proposes different changes, some of them

[jira] [Commented] (LUCENE-5538) FastVectorHighlighter fails with booleans of phrases

2014-03-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940532#comment-13940532 ] Adrien Grand commented on LUCENE-5538: -- +1! FastVectorHighlighter fails with

[jira] [Updated] (LUCENE-5501) Out-of-order collection testing

2014-03-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5501: - Attachment: LUCENE-5501-2.patch Updated patch following the {{BulkScorer}} refactoring.

[jira] [Updated] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5527: - Fix Version/s: 5.0 Make the Collector API work per-segment

[jira] [Updated] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5527: - Attachment: LUCENE-5527.patch Here is a patch, all tests pass. As much as possible, I tried to

[jira] [Commented] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958891#comment-13958891 ] Adrien Grand commented on LUCENE-5527: -- I chose these names to make it clear what

[jira] [Commented] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959030#comment-13959030 ] Adrien Grand commented on LUCENE-5527: -- I like {{LeafCollector}} better too. So

[jira] [Created] (LUCENE-5569) Rename AtomicReader to LeafReader

2014-04-03 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-5569: Summary: Rename AtomicReader to LeafReader Key: LUCENE-5569 URL: https://issues.apache.org/jira/browse/LUCENE-5569 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959075#comment-13959075 ] Adrien Grand commented on LUCENE-5527: -- I opened LUCENE-5569 to discuss the

[jira] [Commented] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959092#comment-13959092 ] Adrien Grand commented on LUCENE-5527: -- bq. is setNextReader really an appropriate

[jira] [Commented] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959109#comment-13959109 ] Adrien Grand commented on LUCENE-5527: -- bq. Thanks for picking this up Adrien! I

[jira] [Commented] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959218#comment-13959218 ] Adrien Grand commented on LUCENE-5527: -- The patch only moves 3 methods of the

[jira] [Commented] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959252#comment-13959252 ] Adrien Grand commented on LUCENE-5527: -- Uwe, are you talking about the

[jira] [Commented] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959280#comment-13959280 ] Adrien Grand commented on LUCENE-5527: -- I think there are things to discuss

[jira] [Updated] (LUCENE-5527) Make the Collector API work per-segment

2014-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5527: - Attachment: LUCENE-5527.patch [~hossman_luc...@fucit.org] no worries! [~mikemccand] Thanks for

[jira] [Resolved] (LUCENE-5527) Make the Collector API work per-segment

2014-04-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5527. -- Resolution: Fixed Assignee: Adrien Grand Thanks everyone! Make the Collector API work

[jira] [Resolved] (LUCENE-5501) Out-of-order collection testing

2014-04-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5501. -- Resolution: Fixed Out-of-order collection testing ---

[jira] [Created] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-04 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-5578: Summary: Stored fields might accumulate checksums on merges Key: LUCENE-5578 URL: https://issues.apache.org/jira/browse/LUCENE-5578 Project: Lucene - Core

[jira] [Updated] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5578: - Attachment: LUCENE-5578.patch Here is an untested fix, I'd like to write tests for all our

[jira] [Commented] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960505#comment-13960505 ] Adrien Grand commented on LUCENE-5578: -- Indeed, bulk merge is disabled when the

[jira] [Commented] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960522#comment-13960522 ] Adrien Grand commented on LUCENE-5578: -- No it won't. Because the metadata of a block

[jira] [Commented] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960525#comment-13960525 ] Adrien Grand commented on LUCENE-5578: -- I quickly discussed with Robert about a way

[jira] [Commented] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960535#comment-13960535 ] Adrien Grand commented on LUCENE-5578: -- Indeed we should add such sanity checks!

[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader

2014-04-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961013#comment-13961013 ] Adrien Grand commented on LUCENE-5569: -- +1 to the patch. Maybe we should leave a

[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader

2014-04-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961018#comment-13961018 ] Adrien Grand commented on LUCENE-5569: -- +1 to do that in a follow-up issue Rename

[jira] [Updated] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5578: - Attachment: LUCENE-5578.patch Here is a patch: - as suggested by Uwe, I modified the stored

[jira] [Updated] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5578: - Attachment: LUCENE-5578.patch Thanks Uwe, I agree this can be confusing. I just modified the

[jira] [Created] (LUCENE-5580) Always verify stored fields' checksum on merge

2014-04-08 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-5580: Summary: Always verify stored fields' checksum on merge Key: LUCENE-5580 URL: https://issues.apache.org/jira/browse/LUCENE-5580 Project: Lucene - Core Issue

[jira] [Updated] (LUCENE-5580) Always verify stored fields' checksum on merge

2014-04-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5580: - Attachment: LUCENE-5580.patch Here is a patch that verifies checksums on stored fields when

[jira] [Commented] (LUCENE-5580) Always verify stored fields' checksum on merge

2014-04-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962743#comment-13962743 ] Adrien Grand commented on LUCENE-5580: -- I agree this would be nice to do that on

[jira] [Commented] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962756#comment-13962756 ] Adrien Grand commented on LUCENE-5578: -- Let me try to see how it goes. :-) Stored

[jira] [Updated] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5578: - Attachment: LUCENE-5578.patch Hey Mike, I tried to apply the changes that you proposed and I

[jira] [Commented] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963070#comment-13963070 ] Adrien Grand commented on LUCENE-5578: -- I ran a few more iterations of the tests and

[jira] [Resolved] (LUCENE-5578) Stored fields might accumulate checksums on merges

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5578. -- Resolution: Fixed Stored fields might accumulate checksums on merges

[jira] [Resolved] (LUCENE-5580) Always verify stored fields' checksum on merge

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5580. -- Resolution: Fixed Always verify stored fields' checksum on merge

[jira] [Created] (LUCENE-5583) Should BufferedChecksumIndexInput have its own buffer?

2014-04-09 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-5583: Summary: Should BufferedChecksumIndexInput have its own buffer? Key: LUCENE-5583 URL: https://issues.apache.org/jira/browse/LUCENE-5583 Project: Lucene - Core

[jira] [Commented] (LUCENE-5583) Should BufferedChecksumIndexInput have its own buffer?

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964131#comment-13964131 ] Adrien Grand commented on LUCENE-5583: -- bq. I personally think you shouldn't pass

[jira] [Commented] (LUCENE-5583) Should BufferedChecksumIndexInput have its own buffer?

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964155#comment-13964155 ] Adrien Grand commented on LUCENE-5583: -- Thanks for the feedback, I'll work on a

[jira] [Updated] (LUCENE-5586) BufferedChecksumIndexInput is not cloneable

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5586: - Description: {{BufferedChecksumIndexInput}} implements {{Cloneable}}, yet its close method

[jira] [Created] (LUCENE-5586) BufferedChecksumIndexInput is not cloneable

2014-04-09 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-5586: Summary: BufferedChecksumIndexInput is not cloneable Key: LUCENE-5586 URL: https://issues.apache.org/jira/browse/LUCENE-5586 Project: Lucene - Core Issue

[jira] [Updated] (LUCENE-5586) BufferedChecksumIndexInput is not cloneable

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5586: - Attachment: LUCENE-5586.patch Here is a patch. BufferedChecksumIndexInput is not cloneable

[jira] [Updated] (LUCENE-5583) Should BufferedChecksumIndexInput have its own buffer?

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5583: - Attachment: LUCENE-5583.patch Here is a patch. Should BufferedChecksumIndexInput have its own

[jira] [Commented] (LUCENE-5583) Should BufferedChecksumIndexInput have its own buffer?

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964245#comment-13964245 ] Adrien Grand commented on LUCENE-5583: -- I didn't think much about the thread-local,

[jira] [Commented] (LUCENE-5587) TestSimpleTextDocValuesFormat.testMergeStability -seed 161C8BDA82B2190F

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964256#comment-13964256 ] Adrien Grand commented on LUCENE-5587: -- +1 Thank you Mike for taking care of this.

[jira] [Updated] (LUCENE-5583) Should BufferedChecksumIndexInput have its own buffer?

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5583: - Attachment: LUCENE-5583.patch Here is an updated patch that stores the skip buffer as an

[jira] [Updated] (LUCENE-5583) Add DataInput.skipBytes

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5583: - Summary: Add DataInput.skipBytes (was: Should BufferedChecksumIndexInput have its own buffer?)

[jira] [Commented] (LUCENE-5583) Add DataInput.skipBytes

2014-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964650#comment-13964650 ] Adrien Grand commented on LUCENE-5583: -- Good point, I'll fix it! Add

[jira] [Resolved] (LUCENE-5583) Add DataInput.skipBytes

2014-04-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5583. -- Resolution: Fixed Assignee: Adrien Grand Committed to both branches, thanks Simon, Uwe

[jira] [Commented] (LUCENE-5586) BufferedChecksumIndexInput is not cloneable

2014-04-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965105#comment-13965105 ] Adrien Grand commented on LUCENE-5586: -- The current patch makes

[jira] [Updated] (LUCENE-5586) BufferedChecksumIndexInput is not cloneable

2014-04-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5586: - Attachment: LUCENE-5586.patch Fixed the patch to move the UOE from {{ChecksumIndexInput}} to

[jira] [Comment Edited] (LUCENE-5586) BufferedChecksumIndexInput is not cloneable

2014-04-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965111#comment-13965111 ] Adrien Grand edited comment on LUCENE-5586 at 4/10/14 8:05 AM:

[jira] [Resolved] (LUCENE-5586) BufferedChecksumIndexInput is not cloneable

2014-04-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5586. -- Resolution: Fixed Fix Version/s: 4.8 Assignee: Adrien Grand

[jira] [Commented] (LUCENE-5588) We should also fsync the directory when committing

2014-04-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965185#comment-13965185 ] Adrien Grand commented on LUCENE-5588: -- bq. In fact. it also does not work on Linux,

[jira] [Updated] (LUCENE-5602) always verify term vectors on bulk merge

2014-04-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5602: - Attachment: LUCENE-5602.patch Thanks Robert for adding the version check. I think we should

[jira] [Commented] (LUCENE-5602) always verify term vectors on bulk merge

2014-04-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13966573#comment-13966573 ] Adrien Grand commented on LUCENE-5602: -- That was my reasoning as well. :-) always

[jira] [Commented] (LUCENE-5604) Should we switch BytesRefHash to MurmurHash3?

2014-04-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968122#comment-13968122 ] Adrien Grand commented on LUCENE-5604: -- Strong +1 on this change! bq. Separately, I

[jira] [Commented] (LUCENE-5596) Support for index/search large numeric field

2014-04-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969284#comment-13969284 ] Adrien Grand commented on LUCENE-5596: -- bq. There is already another issue in ES

[jira] [Commented] (LUCENE-5596) Support for index/search large numeric field

2014-04-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969298#comment-13969298 ] Adrien Grand commented on LUCENE-5596: -- bq. but those types like BigDecimal or

[jira] [Commented] (LUCENE-5596) Support for index/search large numeric field

2014-04-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969306#comment-13969306 ] Adrien Grand commented on LUCENE-5596: -- bq. I would in that case don't do the

[jira] [Commented] (LUCENE-5596) Support for index/search large numeric field

2014-04-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969350#comment-13969350 ] Adrien Grand commented on LUCENE-5596: -- bq. Maybe we should discuss the API first

[jira] [Commented] (LUCENE-5596) Support for index/search large numeric field

2014-04-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969391#comment-13969391 ] Adrien Grand commented on LUCENE-5596: -- bq. Longer terms are only prefixed up to a

[jira] [Updated] (LUCENE-5569) Rename AtomicReader to LeafReader

2014-04-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5569: - Priority: Blocker (was: Minor) Rename AtomicReader to LeafReader

[jira] [Commented] (LUCENE-5646) stored fields bulk merging doesn't quite work right

2014-05-06 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990352#comment-13990352 ] Adrien Grand commented on LUCENE-5646: -- Indeed, code path #1 almost only happens on

[jira] [Commented] (LUCENE-5649) tests should sometime disable bulk merges for segments

2014-05-06 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990665#comment-13990665 ] Adrien Grand commented on LUCENE-5649: -- +1 tests should sometime disable bulk

[jira] [Commented] (LUCENE-5666) Add UninvertingReader

2014-05-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13994992#comment-13994992 ] Adrien Grand commented on LUCENE-5666: -- +1 Add UninvertingReader

[jira] [Commented] (LUCENE-5666) Add UninvertingReader

2014-05-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001204#comment-14001204 ] Adrien Grand commented on LUCENE-5666: -- +1 I like the change a lot! Add

[jira] [Commented] (LUCENE-5666) Add UninvertingReader

2014-05-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001204#comment-14001204 ] Adrien Grand commented on LUCENE-5666: -- +1 I like the change a lot! Add

[jira] [Commented] (LUCENE-5688) NumericDocValues fields with sparse data can be compressed better

2014-05-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004562#comment-14004562 ] Adrien Grand commented on LUCENE-5688: -- +1 to using binary search on an in-memory

[jira] [Created] (LUCENE-5695) Add DocIdSet.ramBytesUsed

2014-05-22 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-5695: Summary: Add DocIdSet.ramBytesUsed Key: LUCENE-5695 URL: https://issues.apache.org/jira/browse/LUCENE-5695 Project: Lucene - Core Issue Type: New Feature

[jira] [Updated] (LUCENE-5695) Add DocIdSet.ramBytesUsed

2014-05-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5695: - Attachment: LUCENE-5695.patch Here is a patch. Add DocIdSet.ramBytesUsed

[jira] [Commented] (LUCENE-5695) Add DocIdSet.ramBytesUsed

2014-05-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006090#comment-14006090 ] Adrien Grand commented on LUCENE-5695: -- I'm not too happy with the default

[jira] [Commented] (LUCENE-5696) Remove Weakhashmap from CachingWrapperFilter

2014-05-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006254#comment-14006254 ] Adrien Grand commented on LUCENE-5696: -- +1 to a concurrent hash table and removing

[jira] [Updated] (LUCENE-5695) Add DocIdSet.ramBytesUsed

2014-05-23 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5695: - Attachment: LUCENE-5695.patch Here is a new patch that makes ramBytesUsed abstract for 5.x. For

[jira] [Created] (LUCENE-5701) Move core closed listeners to AtomicReader

2014-05-23 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-5701: Summary: Move core closed listeners to AtomicReader Key: LUCENE-5701 URL: https://issues.apache.org/jira/browse/LUCENE-5701 Project: Lucene - Core Issue

[jira] [Updated] (LUCENE-5701) Move core closed listeners to AtomicReader

2014-05-23 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5701: - Attachment: LUCENE-5701.patch Here is a patch: * add/removeCoreClosedListener is abstract on

[jira] [Updated] (LUCENE-5701) Move core closed listeners to AtomicReader

2014-05-23 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-5701: - Attachment: LUCENE-5701.patch Move core closed listeners to AtomicReader

<    7   8   9   10   11   12   13   14   15   16   >