Ben Manes created SOLR-7355:
---
Summary: Java 8: ConcurrentLinkedHashMap - Caffeine
Key: SOLR-7355
URL: https://issues.apache.org/jira/browse/SOLR-7355
Project: Solr
Issue Type: Task
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-7355:
Attachment: SOLR-7355.patch
Java 8: ConcurrentLinkedHashMap - Caffeine
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-7355:
Attachment: (was: SOLR-7355.patch)
Java 8: ConcurrentLinkedHashMap - Caffeine
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484300#comment-14484300
]
Ben Manes commented on SOLR-7355:
-
This ticket is not an attempt to advocate a competing
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484418#comment-14484418
]
Ben Manes commented on SOLR-7355:
-
* License remains Apache 2.
* Performance should be the
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-7355:
Attachment: SOLR-7355.patch
Java 8: ConcurrentLinkedHashMap - Caffeine
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-7355:
Attachment: SOLR-7355.patch
Java 8: ConcurrentLinkedHashMap - Caffeine
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-7355:
Attachment: (was: SOLR-7355.patch)
Java 8: ConcurrentLinkedHashMap - Caffeine
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-7355:
Attachment: SOLR-7355.patch
Java 8: ConcurrentLinkedHashMap - Caffeine
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-7355:
Attachment: (was: SOLR-7355.patch)
Java 8: ConcurrentLinkedHashMap - Caffeine
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485238#comment-14485238
]
Ben Manes commented on SOLR-7355:
-
I saw that too and assumed python3 had to be available,
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485216#comment-14485216
]
Ben Manes commented on SOLR-7355:
-
Thanks! I thought I fixed that in the last update
[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485245#comment-14485245
]
Ben Manes commented on SOLR-7355:
-
Odd that the patch doesn't show that this was moved,
A
Ben Manes created SOLR-8241:
---
Summary: Evaluate W-TinyLfu cache
Key: SOLR-8241
URL: https://issues.apache.org/jira/browse/SOLR-8241
Project: Solr
Issue Type: Wish
Components: search
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-8241:
Description:
SOLR-2906 introduced an LFU cache and in-progress SOLR-3393 makes it O(1). The
discussions
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069335#comment-15069335
]
Ben Manes commented on SOLR-8241:
-
[Benchmarks|https://github.com/ben-manes/caffeine/wiki/Benchmarks] of
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-8241:
Attachment: SOLR-8241.patch
> Evaluate W-TinyLfu cache
>
>
> Key:
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136695#comment-15136695
]
Ben Manes commented on SOLR-8241:
-
Attached a patch that includes a new SolrCache implementation based on
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137321#comment-15137321
]
Ben Manes commented on SOLR-8241:
-
I only used the LruCache as a template and removed much of it, though
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237765#comment-15237765
]
Ben Manes commented on SOLR-8241:
-
There are some other caches that might be worth migrating as well (e.g.
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238184#comment-15238184
]
Ben Manes commented on SOLR-8241:
-
Thanks for the information. I definitely meant that would be a new issue
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178872#comment-15178872
]
Ben Manes commented on SOLR-8241:
-
Percentile stats are best obtained by the metrics library. The stats
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178106#comment-15178106
]
Ben Manes commented on SOLR-8241:
-
I see that [YCSB|https://github.com/brianfrankcooper/YCSB] includes Solr
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178389#comment-15178389
]
Ben Manes commented on SOLR-8241:
-
Using the metrics library should be really easy. There are two simple
[
https://issues.apache.org/jira/browse/SOLR-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222638#comment-15222638
]
Ben Manes commented on SOLR-8906:
-
Not sure if it helps, but there's discussion of using TinyLFU instead of
[
https://issues.apache.org/jira/browse/SOLR-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222663#comment-15222663
]
Ben Manes commented on SOLR-8906:
-
TinyLFU is scan resistant (see [Glimpse
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381077#comment-15381077
]
Ben Manes commented on SOLR-8241:
-
Can we try to move this forward again? Thanks!
> Evaluate W-TinyLfu
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839058#comment-15839058
]
Ben Manes commented on SOLR-8241:
-
[~elyograg]: Solr 6.4.0 was just released. Do you think we can make a
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873511#comment-15873511
]
Ben Manes commented on SOLR-10141:
--
Released 2.4.0
> Caffeine cache causes BlockCache corruption
>
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872221#comment-15872221
]
Ben Manes commented on SOLR-10141:
--
Thanks [~ysee...@gmail.com]. Sorry about any frustrations this
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872244#comment-15872244
]
Ben Manes commented on SOLR-8241:
-
[~Timothy055], solr master is now on 2.3.5 (to upgrade its usage in the
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872969#comment-15872969
]
Ben Manes commented on SOLR-10141:
--
Thanks! I'm resolving some issues with the latest error-prone (static
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872983#comment-15872983
]
Ben Manes edited comment on SOLR-10141 at 2/18/17 5:08 AM:
---
Thanks!!! I think I
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872983#comment-15872983
]
Ben Manes commented on SOLR-10141:
--
Thanks!!! I think I found the bug. It now passes your test case.
The
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872943#comment-15872943
]
Ben Manes commented on SOLR-10141:
--
Can you provide me with the latest version of a self-contained test?
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873011#comment-15873011
]
Ben Manes commented on SOLR-10141:
--
[Pull Request|https://github.com/ben-manes/caffeine/pull/144] with
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873334#comment-15873334
]
Ben Manes commented on SOLR-10141:
--
If you wish to ensure a very strict bounding by throttling writers,
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873361#comment-15873361
]
Ben Manes commented on SOLR-10141:
--
That makes sense. If its a fallback when an empty slot can't be
[
https://issues.apache.org/jira/browse/SOLR-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864352#comment-15864352
]
Ben Manes commented on SOLR-10121:
--
Can you try a local hack of changing Caffeine versions and, if it
[
https://issues.apache.org/jira/browse/SOLR-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863924#comment-15863924
]
Ben Manes commented on SOLR-10121:
--
Yes, a write should constitute a publication. Caffeine decorates a
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-10141:
-
Attachment: Solr10141Test.java
I updated the test to use Awaitility to avoid race conditions when
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868110#comment-15868110
]
Ben Manes commented on SOLR-10141:
--
It may be FJP retrying a task if it is slow to complete. If so, we
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868161#comment-15868161
]
Ben Manes commented on SOLR-10141:
--
I plan on porting the test to Caffeine's suite and checking against
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868205#comment-15868205
]
Ben Manes commented on SOLR-10141:
--
Running your test against master and it doesn't fail. Can you please
[
https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868168#comment-15868168
]
Ben Manes commented on SOLR-10141:
--
Oh, also older jdk8 versions had a bug in fjp causing it to drop
[
https://issues.apache.org/jira/browse/SOLR-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447579#comment-15447579
]
Ben Manes commented on SOLR-9284:
-
[~michael.sun]: If you upgrade to Caffeine 2.x then it will take
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517521#comment-15517521
]
Ben Manes commented on SOLR-8241:
-
The cache does provide basic snapshot features ordered by the policy
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521377#comment-15521377
]
Ben Manes commented on SOLR-8241:
-
I took look to refresh myself on LFUCache and decay. I don't think there
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558521#comment-15558521
]
Ben Manes commented on SOLR-8241:
-
I can take a stab at tests, but its unclear what to include other than
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-8241:
Attachment: proposal.patch
I have some basic tests ported (testSimple, testTimeDecay). The first performs
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558709#comment-15558709
]
Ben Manes commented on SOLR-8241:
-
I think there is a small bug in the "hottest" ordering provided by
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517094#comment-15517094
]
Ben Manes commented on SOLR-8241:
-
Expiration is tricky because it means the data is no longer valid to be
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-8241:
Comment: was deleted
(was: Expiration is tricky because it means the data is no longer valid to be
consumed
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517090#comment-15517090
]
Ben Manes commented on SOLR-8241:
-
Expiration is tricky because it means the data is no longer valid to be
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517433#comment-15517433
]
Ben Manes commented on SOLR-8241:
-
Can you explain why a new instance is required and the entire cache
[
https://issues.apache.org/jira/browse/SOLR-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437826#comment-15437826
]
Ben Manes commented on SOLR-9284:
-
Hopefully I didn't break this behavior when upgrading from
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-8241:
Attachment: SOLR-8241.patch
Rebased and updated to v2.3.4. Any remaining tasks?
> Evaluate W-TinyLfu cache
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802076#comment-15802076
]
Ben Manes commented on SOLR-8241:
-
I think the tests all passed last I checked with this new SolrCache, but
[
https://issues.apache.org/jira/browse/SOLR-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902487#comment-15902487
]
Ben Manes commented on SOLR-10205:
--
For writes you might prefer to use an atomic computation instead of a
[
https://issues.apache.org/jira/browse/SOLR-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115873#comment-16115873
]
Ben Manes commented on SOLR-10553:
--
In this case Caffeine is uses an embedded queue from JCTools, so
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307000#comment-16307000
]
Ben Manes commented on SOLR-8241:
-
Shawn, is this issue something you'd be interested in finalizing in the
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-8241:
Issue Type: Improvement (was: Wish)
> Evaluate W-TinyLfu cache
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated SOLR-8241:
Priority: Major (was: Minor)
> Evaluate W-TinyLfu cache
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710613#comment-16710613
]
Ben Manes commented on SOLR-8241:
-
Another year, another ping!
Do you think that you'll have some time
[
https://issues.apache.org/jira/browse/SOLR-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12689359#action_12689359
]
Ben Manes commented on SOLR-1082:
-
Yes, the LRU implementation in my CLHM is less than
65 matches
Mail list logo
