[jira] [Commented] (LUCENE-8330) Detach IndexWriter from MergePolicy

[ https://issues.apache.org/jira/browse/LUCENE-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489567#comment-16489567 ] Michael McCandless commented on LUCENE-8330: +1, this is awesome! {quote}removes the

[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released

[ https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482797#comment-16482797 ] Michael McCandless commented on LUCENE-8324: +1 > Unreferenced files of dropped segments

[jira] [Commented] (LUCENE-8319) A Time-limiting collector that works with CollectorManagers

[ https://issues.apache.org/jira/browse/LUCENE-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482649#comment-16482649 ] Michael McCandless commented on LUCENE-8319: {quote}I wonder if we could have

[jira] [Commented] (LUCENE-8317) TestStressNRT fails with missing document

[ https://issues.apache.org/jira/browse/LUCENE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478955#comment-16478955 ] Michael McCandless commented on LUCENE-8317: +1 phew. > TestStressNRT fails with missing

[jira] [Commented] (LUCENE-8317) TestStressNRT fails with missing document

[ https://issues.apache.org/jira/browse/LUCENE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478759#comment-16478759 ] Michael McCandless commented on LUCENE-8317: OK, phew, awesome find!  +1 > TestStressNRT

[jira] [Commented] (LUCENE-8317) TestStressNRT fails with missing document

[ https://issues.apache.org/jira/browse/LUCENE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478194#comment-16478194 ] Michael McCandless commented on LUCENE-8317:   {{fully}} --> {{full}} I'm a little

[jira] [Commented] (LUCENE-8316) Allow DV updates for not existing fields

[ https://issues.apache.org/jira/browse/LUCENE-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477534#comment-16477534 ] Michael McCandless commented on LUCENE-8316: +1 > Allow DV updates for not existing fields >

[jira] [Commented] (LUCENE-8310) Relax IWs check on pending deletes

[ https://issues.apache.org/jira/browse/LUCENE-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476524#comment-16476524 ] Michael McCandless commented on LUCENE-8310: +1 > Relax IWs check on pending deletes >

[jira] [Commented] (LUCENE-8310) Relax IWs check on pending deletes

[ https://issues.apache.org/jira/browse/LUCENE-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475993#comment-16475993 ] Michael McCandless commented on LUCENE-8310: +1, much cleaner! You can make

[jira] [Commented] (LUCENE-8310) Relax IWs check on pending deletes

[ https://issues.apache.org/jira/browse/LUCENE-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475667#comment-16475667 ] Michael McCandless commented on LUCENE-8310: {{+1}} {{futur}} -> {{future}} {{segment_s2}}

[jira] [Commented] (LUCENE-8309) Don't use mutable FixedBitSets as live docs Bits

[ https://issues.apache.org/jira/browse/LUCENE-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474053#comment-16474053 ] Michael McCandless commented on LUCENE-8309: +1, but maybe add a class javadoc to

[jira] [Commented] (LUCENE-8273) Add a ConditionalTokenFilter

[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472594#comment-16472594 ] Michael McCandless commented on LUCENE-8273: +1, very cool addition to Lucene! > Add a

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471009#comment-16471009 ] Michael McCandless commented on LUCENE-7976: Net/net I like this change; it would allow the

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470787#comment-16470787 ] Michael McCandless commented on LUCENE-7976: [~erickerickson] I'll review your latest patch

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470548#comment-16470548 ] Michael McCandless commented on LUCENE-7976: {quote}I really think we should start working

[jira] [Commented] (LUCENE-8298) Allow DocValues updates to reset a value

[ https://issues.apache.org/jira/browse/LUCENE-8298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467604#comment-16467604 ] Michael McCandless commented on LUCENE-8298: +1, very cool!  My favorite part of the patch

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465780#comment-16465780 ] Michael McCandless commented on LUCENE-7976: [~erickerickson] if you index with a single

[jira] [Commented] (LUCENE-8297) Add IW#tryUpdateDocValues(Reader, int, Fields...)

[ https://issues.apache.org/jira/browse/LUCENE-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465750#comment-16465750 ] Michael McCandless commented on LUCENE-8297: +1, great tests :)   Maybe rename

[jira] [Commented] (LUCENE-8297) Add IW#tryUpdateDocValues(Reader, int, Fields...)

[ https://issues.apache.org/jira/browse/LUCENE-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465268#comment-16465268 ] Michael McCandless commented on LUCENE-8297: I will look! > Add

[jira] [Commented] (LUCENE-8293) Ensure only hard deletes are carried over in a merge

[ https://issues.apache.org/jira/browse/LUCENE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462795#comment-16462795 ] Michael McCandless commented on LUCENE-8293: +1   I like how you tap into segment warmer in

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462618#comment-16462618 ] Michael McCandless commented on LUCENE-7976: Thanks [~erickerickson]; I will try to review

[jira] [Commented] (LUCENE-8293) Ensure only hard deletes are carried over in a merge

[ https://issues.apache.org/jira/browse/LUCENE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462266#comment-16462266 ] Michael McCandless commented on LUCENE-8293: +1, tricky ... we were previously just asking

[jira] [Commented] (LUCENE-8290) Keep soft deletes in sync with on-disk DocValues

[ https://issues.apache.org/jira/browse/LUCENE-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462256#comment-16462256 ] Michael McCandless commented on LUCENE-8290: +1 > Keep soft deletes in sync with on-disk

[jira] [Resolved] (LUCENE-8265) WordDelimiterFilter should pass through terms marked as keywords

[ https://issues.apache.org/jira/browse/LUCENE-8265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8265. Resolution: Fixed Fix Version/s: master (8.0) 7.4 Thanks

[jira] [Resolved] (LUCENE-8244) SearcherTaxonomyManager.refreshIfNeeded leaks file handles on exception

[ https://issues.apache.org/jira/browse/LUCENE-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8244. Resolution: Fixed Assignee: (was: Michael McCandless) Fix

[jira] [Commented] (LUCENE-8277) Better validate CodecReaders in addIndexes

[ https://issues.apache.org/jira/browse/LUCENE-8277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452947#comment-16452947 ] Michael McCandless commented on LUCENE-8277: +1; it's otherwise a way for "corrupted" indices

[jira] [Commented] (LUCENE-8264) Allow an option to rewrite all segments

[ https://issues.apache.org/jira/browse/LUCENE-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452072#comment-16452072 ] Michael McCandless commented on LUCENE-8264: I don't think it's realistic to expect Lucene to

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450110#comment-16450110 ] Michael McCandless commented on LUCENE-7976: {quote}    // We did our best to find the right

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450104#comment-16450104 ] Michael McCandless commented on LUCENE-7976: {quote}Right, but that has quite a few

[jira] [Commented] (LUCENE-8272) Share internal DV update code between binary and numeric

[ https://issues.apache.org/jira/browse/LUCENE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450028#comment-16450028 ] Michael McCandless commented on LUCENE-8272: +1 > Share internal DV update code between

[jira] [Commented] (LUCENE-8271) Remove IndexWriter from DWFlushQueue

[ https://issues.apache.org/jira/browse/LUCENE-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449834#comment-16449834 ] Michael McCandless commented on LUCENE-8271: +1 > Remove IndexWriter from DWFlushQueue >

[jira] [Commented] (LUCENE-8265) WordDelimiterFilter should pass through terms marked as keywords

[ https://issues.apache.org/jira/browse/LUCENE-8265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449819#comment-16449819 ] Michael McCandless commented on LUCENE-8265: Thanks [~sokolov]; new PR looks great. >

[jira] [Commented] (LUCENE-8269) Detach downstream classes from IndexWriter

[ https://issues.apache.org/jira/browse/LUCENE-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448275#comment-16448275 ] Michael McCandless commented on LUCENE-8269: +1, great cleanup. > Detach downstream classes

[jira] [Commented] (LUCENE-8265) WordDelimiterFilter should pass through terms marked as keywords

[ https://issues.apache.org/jira/browse/LUCENE-8265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447980#comment-16447980 ] Michael McCandless commented on LUCENE-8265: Thanks [~sokolov]; the PR looks great; I'll wait

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447323#comment-16447323 ] Michael McCandless commented on LUCENE-7976: {quote}About removing {{@lucene.experimental}},

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447006#comment-16447006 ] Michael McCandless commented on LUCENE-7976: This looks like it's coming together – thanks

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446985#comment-16446985 ] Michael McCandless commented on LUCENE-7976: It'd be great to have this simulator available

[jira] [Commented] (LUCENE-8260) Extract ReaderPool from IndexWriter

[ https://issues.apache.org/jira/browse/LUCENE-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446978#comment-16446978 ] Michael McCandless commented on LUCENE-8260: +1, this is wonderful!  I left minor comments on

[jira] [Commented] (LUCENE-8253) ForceMergeDeletes does not merge soft-deleted segments

[ https://issues.apache.org/jira/browse/LUCENE-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439279#comment-16439279 ] Michael McCandless commented on LUCENE-8253: +1, I left some small comments on GH. >

[jira] [Commented] (LUCENE-8248) Rename MergePolicyWrapper to FilterMergePolicy and override all of MergePolicy

[ https://issues.apache.org/jira/browse/LUCENE-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438060#comment-16438060 ] Michael McCandless commented on LUCENE-8248: Woops, thanks [~varunthacker]! > Rename

[jira] [Commented] (LUCENE-8248) Rename MergePolicyWrapper to FilterMergePolicy and override all of MergePolicy

[ https://issues.apache.org/jira/browse/LUCENE-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437766#comment-16437766 ] Michael McCandless commented on LUCENE-8248: Thanks [~msoko...@gmail.com]; new patch looks

[jira] [Commented] (LUCENE-8248) Rename MergePolicyWrapper to FilterMergePolicy and override all of MergePolicy

[ https://issues.apache.org/jira/browse/LUCENE-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435933#comment-16435933 ] Michael McCandless commented on LUCENE-8248: I suspect there was a time when

[jira] [Commented] (LUCENE-8248) Rename MergePolicyWrapper to FilterMergePolicy and override all of MergePolicy

[ https://issues.apache.org/jira/browse/LUCENE-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434208#comment-16434208 ] Michael McCandless commented on LUCENE-8248: Thanks [~msoko...@gmail.com], new patch looks

[jira] [Commented] (LUCENE-8248) Make MergePolicy.setMaxCFSSegmentSizeMB final

[ https://issues.apache.org/jira/browse/LUCENE-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433981#comment-16433981 ] Michael McCandless commented on LUCENE-8248: Ahh thank you for the new patch; it looks great!

[jira] [Commented] (LUCENE-8248) Make MergePolicy.setMaxCFSSegmentSizeMB final

[ https://issues.apache.org/jira/browse/LUCENE-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433177#comment-16433177 ] Michael McCandless commented on LUCENE-8248: Hmm maybe instead we should remove the {{final}}

[jira] [Commented] (LUCENE-8246) Allow to customize the number of deletes a merge claims

[ https://issues.apache.org/jira/browse/LUCENE-8246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432498#comment-16432498 ] Michael McCandless commented on LUCENE-8246: +1 > Allow to customize the number of deletes a

[jira] [Resolved] (LUCENE-8243) IndexWriter might delete DV update files if addIndices are invovled

[ https://issues.apache.org/jira/browse/LUCENE-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8243. Resolution: Fixed > IndexWriter might delete DV update files if addIndices are

[jira] [Commented] (LUCENE-8243) IndexWriter might delete DV update files if addIndices are invovled

[ https://issues.apache.org/jira/browse/LUCENE-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429782#comment-16429782 ] Michael McCandless commented on LUCENE-8243: OK I attached new patch w/ a new test that does

[jira] [Updated] (LUCENE-8243) IndexWriter might delete DV update files if addIndices are invovled

[ https://issues.apache.org/jira/browse/LUCENE-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-8243: --- Attachment: LUCENE-8243.patch > IndexWriter might delete DV update files if

[jira] [Commented] (LUCENE-8243) IndexWriter might delete DV update files if addIndices are invovled

[ https://issues.apache.org/jira/browse/LUCENE-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429778#comment-16429778 ] Michael McCandless commented on LUCENE-8243: Hmm actually I'm worried about my fix: this

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429059#comment-16429059 ] Michael McCandless commented on LUCENE-7976: I think this change might be cleaner if we can

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429054#comment-16429054 ] Michael McCandless commented on LUCENE-7976: I'm confused what this means: {quote}I further

[jira] [Commented] (LUCENE-7976) Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429038#comment-16429038 ] Michael McCandless commented on LUCENE-7976: Phew suddenly a lot of action here!  I'll review

[jira] [Commented] (LUCENE-8244) SearcherTaxonomyManager.refreshIfNeeded leaks file handles on exception

[ https://issues.apache.org/jira/browse/LUCENE-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428909#comment-16428909 ] Michael McCandless commented on LUCENE-8244: I attached patch w/ test case and fix. >

[jira] [Updated] (LUCENE-8244) SearcherTaxonomyManager.refreshIfNeeded leaks file handles on exception

[ https://issues.apache.org/jira/browse/LUCENE-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-8244: --- Attachment: LUCENE-8244.patch > SearcherTaxonomyManager.refreshIfNeeded leaks file

[jira] [Created] (LUCENE-8244) SearcherTaxonomyManager.refreshIfNeeded leaks file handles on exception

Michael McCandless created LUCENE-8244: -- Summary: SearcherTaxonomyManager.refreshIfNeeded leaks file handles on exception Key: LUCENE-8244 URL: https://issues.apache.org/jira/browse/LUCENE-8244

[jira] [Commented] (LUCENE-8243) IndexWriter might delete DV update files if addIndices are invovled

[ https://issues.apache.org/jira/browse/LUCENE-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428866#comment-16428866 ] Michael McCandless commented on LUCENE-8243: I just attached a patch that I think fixes the

[jira] [Updated] (LUCENE-8243) IndexWriter might delete DV update files if addIndices are invovled

[ https://issues.apache.org/jira/browse/LUCENE-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-8243: --- Attachment: LUCENE-8243.patch > IndexWriter might delete DV update files if

[jira] [Commented] (LUCENE-8243) IndexWriter might delete DV update files if addIndices are invovled

[ https://issues.apache.org/jira/browse/LUCENE-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428842#comment-16428842 ] Michael McCandless commented on LUCENE-8243: I'll dig ... > IndexWriter might delete DV

[jira] [Assigned] (LUCENE-8243) IndexWriter might delete DV update files if addIndices are invovled

[ https://issues.apache.org/jira/browse/LUCENE-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reassigned LUCENE-8243: -- Assignee: Michael McCandless > IndexWriter might delete DV update files if

[jira] [Resolved] (LUCENE-8238) WordDelimiterFilter javadocs reference nonexistent parameters

[ https://issues.apache.org/jira/browse/LUCENE-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8238. Resolution: Fixed Thanks [~sokolov]! > WordDelimiterFilter javadocs reference

[jira] [Commented] (LUCENE-8226) Don't use MemoryCodec for nightly runs of TestIndexSorting

[ https://issues.apache.org/jira/browse/LUCENE-8226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428801#comment-16428801 ] Michael McCandless commented on LUCENE-8226: [~romseygeek] I think it's fine to reduce the

[jira] [Commented] (LUCENE-8238) WordDelimiterFilter javadocs reference nonexistent parameters

[ https://issues.apache.org/jira/browse/LUCENE-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428788#comment-16428788 ] Michael McCandless commented on LUCENE-8238: Thanks [~sokolov], this looks like a nice doc

[jira] [Commented] (LUCENE-8237) Add a SoftDeletesDirectoryReaderWrapper

[ https://issues.apache.org/jira/browse/LUCENE-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425694#comment-16425694 ] Michael McCandless commented on LUCENE-8237: +1 > Add a SoftDeletesDirectoryReaderWrapper >

[jira] [Commented] (LUCENE-8233) Add support for soft deletes to IndexWriter delete accounting

[ https://issues.apache.org/jira/browse/LUCENE-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424007#comment-16424007 ] Michael McCandless commented on LUCENE-8233: +1; this is a simple way to expose soft deletes. 

[jira] [Commented] (LUCENE-8232) Separate out PendingDeletes from ReadersAndUpdates

[ https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420861#comment-16420861 ] Michael McCandless commented on LUCENE-8232: +1 for the internal cleanup patch, to pull

[jira] [Commented] (LUCENE-8232) Separate out PendingDeletes from ReadersAndUpdates

[ https://issues.apache.org/jira/browse/LUCENE-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420438#comment-16420438 ] Michael McCandless commented on LUCENE-8232: Maybe we could add a full test case showing how

[jira] [Commented] (LUCENE-8215) Fix several fragile exception handling places in o.a.l.index

[ https://issues.apache.org/jira/browse/LUCENE-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404923#comment-16404923 ] Michael McCandless commented on LUCENE-8215: +1, thanks [~simonw]! > Fix several fragile

[jira] [Commented] (LUCENE-8212) Never swallow Exceptions in IndexWriter and DocumentsWriter

[ https://issues.apache.org/jira/browse/LUCENE-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403663#comment-16403663 ] Michael McCandless commented on LUCENE-8212: +1, thanks [~simonw]! > Never swallow

[jira] [Commented] (LUCENE-8205) Simplify AbortingException handling and tragic event logic

[ https://issues.apache.org/jira/browse/LUCENE-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398845#comment-16398845 ] Michael McCandless commented on LUCENE-8205: +1, I left a few small comments on the github

[jira] [Commented] (LUCENE-8200) Allow doc-values to be updated atomically together with a document

[ https://issues.apache.org/jira/browse/LUCENE-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395875#comment-16395875 ] Michael McCandless commented on LUCENE-8200: +1, patch looks great; I left a minor comment on

[jira] [Commented] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

[ https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388500#comment-16388500 ] Michael McCandless commented on LUCENE-8192: +1 to latest patch, yay! > Remove

[jira] [Commented] (LUCENE-8155) Add Java 9 support to smoke tester

[ https://issues.apache.org/jira/browse/LUCENE-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363150#comment-16363150 ] Michael McCandless commented on LUCENE-8155: {quote}[~mikemccand]: Can you help with cleaing

[jira] [Commented] (LUCENE-8162) Make it possible to throttle (Tiered)MergePolicy when commit rate is high

[ https://issues.apache.org/jira/browse/LUCENE-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355352#comment-16355352 ] Michael McCandless commented on LUCENE-8162: The class looks like a fork of TMP, but it looks

[jira] [Commented] (LUCENE-8144) Remove QueryCachingPolicy.ALWAYS_CACHE

[ https://issues.apache.org/jira/browse/LUCENE-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350486#comment-16350486 ] Michael McCandless commented on LUCENE-8144: +1 > Remove QueryCachingPolicy.ALWAYS_CACHE >

[jira] [Commented] (LUCENE-7966) build mr-jar and use some java 9 methods if available

[ https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350482#comment-16350482 ] Michael McCandless commented on LUCENE-7966: +1!   Thank you for the detailed tests

[jira] [Commented] (LUCENE-8134) Disallow changing index options on the fly

[ https://issues.apache.org/jira/browse/LUCENE-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345109#comment-16345109 ] Michael McCandless commented on LUCENE-8134: +1 > Disallow changing index options on the fly

[jira] [Resolved] (LUCENE-8130) NullPointerException from TermStates.toString()

[ https://issues.apache.org/jira/browse/LUCENE-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8130. Resolution: Fixed Fix Version/s: 7.3 master (8.0) >

[jira] [Updated] (LUCENE-8130) NullPointerException from TermStates.toString()

[ https://issues.apache.org/jira/browse/LUCENE-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-8130: --- Attachment: LUCENE-8130.patch > NullPointerException from TermStates.toString() >

[jira] [Created] (LUCENE-8130) NullPointerException from TermStates.toString()

Michael McCandless created LUCENE-8130: -- Summary: NullPointerException from TermStates.toString() Key: LUCENE-8130 URL: https://issues.apache.org/jira/browse/LUCENE-8130 Project: Lucene - Core

[jira] [Commented] (LUCENE-8125) emoji sequence support in ICUTokenizer

[ https://issues.apache.org/jira/browse/LUCENE-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319308#comment-16319308 ] Michael McCandless commented on LUCENE-8125: +1, cool! > emoji sequence support in

[jira] [Commented] (LUCENE-8118) ArrayIndexOutOfBoundsException in TermsHashPerField.writeByte during indexing

[ https://issues.apache.org/jira/browse/LUCENE-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314548#comment-16314548 ] Michael McCandless commented on LUCENE-8118: bq. Well, I think a simple limit can work. For

[jira] [Commented] (LUCENE-8118) ArrayIndexOutOfBoundsException in TermsHashPerField.writeByte during indexing

[ https://issues.apache.org/jira/browse/LUCENE-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314514#comment-16314514 ] Michael McCandless commented on LUCENE-8118: Note that committing only once at the end is

[jira] [Commented] (LUCENE-8113) Allow terms dictionary lookups to be lazy when scores are not needed

[ https://issues.apache.org/jira/browse/LUCENE-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313083#comment-16313083 ] Michael McCandless commented on LUCENE-8113: I like the new name {{TermStates}}! Can we

[jira] [Commented] (LUCENE-7976) Add a parameter to TieredMergePolicy to merge segments that have more than X percent deleted documents

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306834#comment-16306834 ] Michael McCandless commented on LUCENE-7976: bq. WDYT about going one step further and

[jira] [Commented] (LUCENE-7976) Add a parameter to TieredMergePolicy to merge segments that have more than X percent deleted documents

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305755#comment-16305755 ] Michael McCandless commented on LUCENE-7976: +1 to the summary; thanks [~erickerickson],

[jira] [Updated] (LUCENE-8108) Field class should not let you analyze int values?

[ https://issues.apache.org/jira/browse/LUCENE-8108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-8108: --- Attachment: LUCENE-8108.patch Here's a patch with a failing test case; it creates a

[jira] [Created] (LUCENE-8108) Field class should not let you analyze int values?

Michael McCandless created LUCENE-8108: -- Summary: Field class should not let you analyze int values? Key: LUCENE-8108 URL: https://issues.apache.org/jira/browse/LUCENE-8108 Project: Lucene - Core

[jira] [Resolved] (LUCENE-8094) Improve TermInSetQuery.toString

[ https://issues.apache.org/jira/browse/LUCENE-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8094. Resolution: Fixed > Improve TermInSetQuery.toString >

[jira] [Commented] (LUCENE-5012) Make graph-based TokenFilters easier

[ https://issues.apache.org/jira/browse/LUCENE-5012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294139#comment-16294139 ] Michael McCandless commented on LUCENE-5012: This issue should make it easier to fix the bug

[jira] [Resolved] (LUCENE-8101) Make NumericDocValuesField.newSlowExact/RangeQuery fast with a sorted index

[ https://issues.apache.org/jira/browse/LUCENE-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8101. Resolution: Duplicate Aha! Yes it is; I'll resolve. Thanks [~jpountz]. > Make

[jira] [Updated] (LUCENE-8094) Improve TermInSetQuery.toString

[ https://issues.apache.org/jira/browse/LUCENE-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-8094: --- Attachment: LUCENE-8094.patch Simple patch; I think it's ready. > Improve

[jira] [Created] (LUCENE-8101) Make NumericDocValuesField.newSlowExact/RangeQuery fast with a sorted index

Michael McCandless created LUCENE-8101: -- Summary: Make NumericDocValuesField.newSlowExact/RangeQuery fast with a sorted index Key: LUCENE-8101 URL: https://issues.apache.org/jira/browse/LUCENE-8101

[jira] [Commented] (LUCENE-8084) FSTs can be very space-inefficient on array-expanded nodes

[ https://issues.apache.org/jira/browse/LUCENE-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288549#comment-16288549 ] Michael McCandless commented on LUCENE-8084: I like that idea! Maybe in the meantime we

[jira] [Created] (LUCENE-8094) Improve TermInSetQuery.toString

Michael McCandless created LUCENE-8094: -- Summary: Improve TermInSetQuery.toString Key: LUCENE-8094 URL: https://issues.apache.org/jira/browse/LUCENE-8094 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-8090) IndexWriter#flushNextBuffer can cause NPE

[ https://issues.apache.org/jira/browse/LUCENE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285904#comment-16285904 ] Michael McCandless commented on LUCENE-8090: +1, phew. > IndexWriter#flushNextBuffer can

[jira] [Commented] (LUCENE-8081) Allow IndexWriter to opt out of flushing on indexing threads

[ https://issues.apache.org/jira/browse/LUCENE-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280579#comment-16280579 ] Michael McCandless commented on LUCENE-8081: +1 Maybe expand the javadoc a bit to state that

[jira] [Commented] (LUCENE-8043) Attempting to add documents past limit can corrupt index

[ https://issues.apache.org/jira/browse/LUCENE-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277397#comment-16277397 ] Michael McCandless commented on LUCENE-8043: +1 to the patch! Phew that was tricky; thanks

[jira] [Commented] (LUCENE-8077) Integer remainder modulo 1 problem in /core/src/java/org/apache/lucene/index/CheckIndex.java

[ https://issues.apache.org/jira/browse/LUCENE-8077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276961#comment-16276961 ] Michael McCandless commented on LUCENE-8077: Wow nice catch! >Integer remainder modulo 1

[jira] [Resolved] (LUCENE-8073) TestBasicModelIn.testRandomScoring failure

[ https://issues.apache.org/jira/browse/LUCENE-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8073. Resolution: Duplicate Woops thanks [~rcmuir]! >

<    1   2   3   4   5   6   7   8   9   10   >