[jira] [Created] (LUCENE-8884) Add Directory wrapper to track per-query IO counters

2019-06-26 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-8884: -- Summary: Add Directory wrapper to track per-query IO counters Key: LUCENE-8884 URL: https://issues.apache.org/jira/browse/LUCENE-8884 Project: Lucene -

[jira] [Commented] (LUCENE-8865) Use incoming thread for execution if IndexSearcher has an executor

2019-06-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873293#comment-16873293 ] Michael McCandless commented on LUCENE-8865: I plan to test this using our production

[jira] [Commented] (LUCENE-8878) Provide alternative sorting utility from SortField other than FieldComparator

2019-06-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872270#comment-16872270 ] Michael McCandless commented on LUCENE-8878: +1 to simplify Lucene's comparator APIs – they

[jira] [Commented] (LUCENE-8867) Optimise BKD tree for low cardinality leaves

2019-06-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867256#comment-16867256 ] Michael McCandless commented on LUCENE-8867: +1 to both of these optimizations – I suspect

[jira] [Commented] (LUCENE-8854) Can we do "doc at a time scoring" from the BKD tree for exact queries?

2019-06-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862929#comment-16862929 ] Michael McCandless commented on LUCENE-8854: {quote}moving points from a visitor API to a

[jira] [Created] (LUCENE-8854) Can we do "doc at a time scoring" from the BKD tree for exact queries?

2019-06-12 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-8854: -- Summary: Can we do "doc at a time scoring" from the BKD tree for exact queries? Key: LUCENE-8854 URL: https://issues.apache.org/jira/browse/LUCENE-8854

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

2019-06-10 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860335#comment-16860335 ] Michael McCandless commented on LUCENE-8791: {quote}the default interface takes an

[jira] [Created] (LUCENE-8823) IllegalStateException: wrong number of values added during doc values merge

2019-06-03 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-8823: -- Summary: IllegalStateException: wrong number of values added during doc values merge Key: LUCENE-8823 URL: https://issues.apache.org/jira/browse/LUCENE-8823

[jira] [Created] (LUCENE-8822) UnsupportedOperationException: unused: not a comparsion-based sort during IndexWriter flush

2019-06-03 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-8822: -- Summary: UnsupportedOperationException: unused: not a comparsion-based sort during IndexWriter flush Key: LUCENE-8822 URL:

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

2019-05-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852068#comment-16852068 ] Michael McCandless commented on LUCENE-8791: {quote}In my opinion, rescorers should be used

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-20 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844005#comment-16844005 ] Michael McCandless commented on LUCENE-8757: {quote}Your last patch sorts in reverse order

[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

2019-05-20 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844003#comment-16844003 ] Michael McCandless commented on LUCENE-8804: +1 to the issue and patch, great catch, thanks

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-08 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835502#comment-16835502 ] Michael McCandless commented on LUCENE-8757: Are the work units tackled in order for each

[jira] [Commented] (LUCENE-8785) TestIndexWriterDelete.testDeleteAllNoDeadlock failure

2019-05-08 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835500#comment-16835500 ] Michael McCandless commented on LUCENE-8785: Thank you [~simonw]!  Love how open-source

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-08 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835498#comment-16835498 ] Michael McCandless commented on LUCENE-8757: Whoa, fast iterations over here! I think there

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

2019-05-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832327#comment-16832327 ] Michael McCandless commented on LUCENE-8791: {quote}Please have a look again at the spacing.

[jira] [Commented] (LUCENE-8756) MLT queries ignore custom term frequencies

2019-05-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832139#comment-16832139 ] Michael McCandless commented on LUCENE-8756: Ugh, sorry!  Thank you [~cpoerschke]! > MLT

[jira] [Created] (LUCENE-8790) Spooky exception merging doc values

2019-05-02 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-8790: -- Summary: Spooky exception merging doc values Key: LUCENE-8790 URL: https://issues.apache.org/jira/browse/LUCENE-8790 Project: Lucene - Core

[jira] [Commented] (LUCENE-8785) TestIndexWriterDelete.testDeleteAllNoDeadlock failure

2019-05-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832036#comment-16832036 ] Michael McCandless commented on LUCENE-8785: {quote}If there is another thread coming in

[jira] [Commented] (LUCENE-6687) MLT term frequency calculation bug

2019-05-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832027#comment-16832027 ] Michael McCandless commented on LUCENE-6687: OK thanks [~teofili] – I'll backport this soon.

[jira] [Commented] (LUCENE-8785) TestIndexWriterDelete.testDeleteAllNoDeadlock failure

2019-05-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831618#comment-16831618 ] Michael McCandless commented on LUCENE-8785: But at the point we call {{clear()}} haven't we

[jira] [Updated] (LUCENE-8785) TestIndexWriterDelete.testDeleteAllNoDeadlock failure

2019-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-8785: --- Environment: OpenJDK 1.8.0_202 (was: OpenJDK 11) >

[jira] [Created] (LUCENE-8785) TestIndexWriterDelete.testDeleteAllNoDeadlock failure

2019-04-30 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-8785: -- Summary: TestIndexWriterDelete.testDeleteAllNoDeadlock failure Key: LUCENE-8785 URL: https://issues.apache.org/jira/browse/LUCENE-8785 Project: Lucene -

[jira] [Commented] (LUCENE-6687) MLT term frequency calculation bug

2019-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830448#comment-16830448 ] Michael McCandless commented on LUCENE-6687: Hmm it looks like this change was not

[jira] [Commented] (LUCENE-8756) MLT queries ignore custom term frequencies

2019-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830206#comment-16830206 ] Michael McCandless commented on LUCENE-8756: Great, thanks [~ollik1] – I'll push soon. >

[jira] [Commented] (LUCENE-8708) Can we simplify conjunctions of range queries automatically?

2019-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830184#comment-16830184 ] Michael McCandless commented on LUCENE-8708: Hmm why do we need the

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830173#comment-16830173 ] Michael McCandless commented on LUCENE-8757: Thanks [~atris] – I agree it's important to

[jira] [Commented] (LUCENE-8756) MLT queries ignore custom term frequencies

2019-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830139#comment-16830139 ] Michael McCandless commented on LUCENE-8756: The change looks good – I left a couple minor

[jira] [Commented] (LUCENE-8783) Add FST Offheap for non-default Codecs

2019-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830070#comment-16830070 ] Michael McCandless commented on LUCENE-8783: +1 > Add FST Offheap for non-default Codecs >

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2019-04-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829561#comment-16829561 ] Michael McCandless commented on LUCENE-8776: [~venkat11] I'm sorry this change broke your

[jira] [Commented] (LUCENE-8756) MLT queries ignore custom term frequencies

2019-04-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829556#comment-16829556 ] Michael McCandless commented on LUCENE-8756: Ahh thanks for the ping [~ollik1] I agree we

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2019-04-24 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825332#comment-16825332 ] Michael McCandless commented on LUCENE-8776: I think your use case can be properly handled

[jira] [Commented] (LUCENE-8753) New PostingFormat - UniformSplit

2019-04-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809218#comment-16809218 ] Michael McCandless commented on LUCENE-8753: I think this is similar to the terms dictionary

[jira] [Commented] (LUCENE-8753) New PostingFormat - UniformSplit

2019-04-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809188#comment-16809188 ] Michael McCandless commented on LUCENE-8753: {quote}I think PKLookup should be disregarded

[jira] [Commented] (LUCENE-8740) AssertionError FlattenGraphFilter

2019-03-28 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804188#comment-16804188 ] Michael McCandless commented on LUCENE-8740: Maybe a dup of 

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2019-03-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796199#comment-16796199 ] Michael McCandless commented on LUCENE-8150: +1 > Remove references to segments.gen. >

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2019-03-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794558#comment-16794558 ] Michael McCandless commented on LUCENE-8150: Hi [~jpountz], I fixed one issue with

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2019-03-15 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793599#comment-16793599 ] Michael McCandless commented on LUCENE-8150: {quote}I think it's due to the fact that I'm

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2019-03-15 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793595#comment-16793595 ] Michael McCandless commented on LUCENE-8150: Hmm it looks like this was never committed? >

[jira] [Commented] (LUCENE-8542) Provide the LeafSlice to CollectorManager.newCollector to save memory on small index slices

2019-03-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791706#comment-16791706 ] Michael McCandless commented on LUCENE-8542: +1 to improve slices() to aggregate small

[jira] [Resolved] (LUCENE-8720) Integer overflow bug in NameIntCacheLRU.makeRoomLRU()

2019-03-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8720. Resolution: Fixed Fix Version/s: (was: 7.1.1) 8.1

[jira] [Commented] (LUCENE-8717) Handle stop words that appear at articulation points

2019-03-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790698#comment-16790698 ] Michael McCandless commented on LUCENE-8717: +1 for {{TermDeletedAttribute}}. Are we also

[jira] [Commented] (LUCENE-8692) IndexWriter.getTragicException() may not reflect all corrupting exceptions (notably: NoSuchFileException)

2019-03-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790690#comment-16790690 ] Michael McCandless commented on LUCENE-8692: {{rollback}} gives you a way to close

[jira] [Commented] (LUCENE-8720) Integer overflow bug in NameIntCacheLRU.makeRoomLRU()

2019-03-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790681#comment-16790681 ] Michael McCandless commented on LUCENE-8720: Thanks [~kirigirisu], nice catch – I'll pass

[jira] [Commented] (LUCENE-8542) Provide the LeafSlice to CollectorManager.newCollector to save memory on small index slices

2019-03-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790677#comment-16790677 ] Michael McCandless commented on LUCENE-8542: Maybe we should try swapping in the JDK's

[jira] [Commented] (LUCENE-8542) Provide the LeafSlice to CollectorManager.newCollector to save memory on small index slices

2019-03-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790576#comment-16790576 ] Michael McCandless commented on LUCENE-8542: I think the core API change is quite minor and

[jira] [Commented] (LUCENE-8216) Better cross-field scoring

2019-02-23 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775884#comment-16775884 ] Michael McCandless commented on LUCENE-8216: Can this be resolved now?  Looks like

[jira] [Commented] (LUCENE-8703) Build point writers only when needed on the BKD tree

2019-02-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775181#comment-16775181 ] Michael McCandless commented on LUCENE-8703: It'd be nice to have a metric in our nightly

[jira] [Commented] (LUCENE-8671) Add setting for moving FST offheap/onheap

2019-02-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775190#comment-16775190 ] Michael McCandless commented on LUCENE-8671: [~akjain] that's true, maybe we don't need

[jira] [Resolved] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-02-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8635. Resolution: Fixed Fix Version/s: master (9.0) 8.x

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-02-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772153#comment-16772153 ] Michael McCandless commented on LUCENE-8635: I ran luceneutil on {{wikimediumall}} with

[jira] [Commented] (LUCENE-8671) Add setting for moving FST offheap/onheap

2019-02-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772068#comment-16772068 ] Michael McCandless commented on LUCENE-8671: Actually I think this is a good use case for

[jira] [Commented] (LUCENE-8675) Divide Segment Search Amongst Multiple Threads

2019-02-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759440#comment-16759440 ] Michael McCandless commented on LUCENE-8675: {quote}If some segments are getting large

[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-02-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759431#comment-16759431 ] Michael McCandless commented on SOLR-13190: --- +1 to improve the exception message to include the

[jira] [Commented] (LUCENE-8675) Divide Segment Search Amongst Multiple Threads

2019-02-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758451#comment-16758451 ] Michael McCandless commented on LUCENE-8675: I think it'd be interesting to explore

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-02-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758431#comment-16758431 ] Michael McCandless commented on LUCENE-8635: {quote}Better would be an attribute of 

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755374#comment-16755374 ] Michael McCandless commented on LUCENE-8635: Oooh I like that proposal [~jpountz]! > Lazy

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755344#comment-16755344 ] Michael McCandless commented on LUCENE-8635: OK net/net it looks like there is a small

[jira] [Commented] (LUCENE-8653) Reverse FST storage so it can be read forward

2019-01-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748985#comment-16748985 ] Michael McCandless commented on LUCENE-8653: Impressive how simple this was!  I think it's

[jira] [Commented] (LUCENE-8618) MMapDirectory's read ahead on random-access files might trash the OS cache

2019-01-21 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747963#comment-16747963 ] Michael McCandless commented on LUCENE-8618: Was the index cold(ish) in this use case?  I.e.

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745253#comment-16745253 ] Michael McCandless commented on LUCENE-8635: OK thanks [~sokolov].  I'll try to also run

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-16 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744538#comment-16744538 ] Michael McCandless commented on LUCENE-8635: Thanks [~sokolov] – those numbers look quite a

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-15 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743137#comment-16743137 ] Michael McCandless commented on LUCENE-8635: Thanks for testing [~sokolov] – the results

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740764#comment-16740764 ] Michael McCandless commented on LUCENE-8635: Also, have you confirmed that all tests pass

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740757#comment-16740757 ] Michael McCandless commented on LUCENE-8635: Wow, this is impressive!  Surprising how small

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2019-01-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734103#comment-16734103 ] Michael McCandless commented on LUCENE-8601: Thanks [~muralikpbhat] – I'll review and push

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2019-01-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733641#comment-16733641 ] Michael McCandless commented on LUCENE-8601: Hi [~muralikpbhat], I pushed the change to

[jira] [Commented] (LUCENE-8621) Move LatLonShape out of sandbox

2019-01-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731697#comment-16731697 ] Michael McCandless commented on LUCENE-8621: +1 > Move LatLonShape out of sandbox >

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2019-01-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731696#comment-16731696 ] Michael McCandless commented on LUCENE-8601: Thanks I will review and push soon! > Adding

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2018-12-31 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731288#comment-16731288 ] Michael McCandless commented on LUCENE-8601: Ahh OK thanks [~muralikpbhat]; that makes

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2018-12-28 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730210#comment-16730210 ] Michael McCandless commented on LUCENE-8601: Thanks [~muralikpbhat]! Maybe add javadocs

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2018-12-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725297#comment-16725297 ] Michael McCandless commented on LUCENE-8601: Hmm, I'm concerned that segment merging may not

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2018-12-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725251#comment-16725251 ] Michael McCandless commented on LUCENE-8601: Thanks [~muralikpbhat]; new patch looks good

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2018-12-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723009#comment-16723009 ] Michael McCandless commented on LUCENE-8601: Thanks [~muralikpbhat]; new patch looks great. 

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2018-12-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722893#comment-16722893 ] Michael McCandless commented on LUCENE-8601: Thanks [~muralikpbhat]; can we make the

[jira] [Commented] (LUCENE-8600) DocValuesFieldUpdates should use a better sort

2018-12-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721520#comment-16721520 ] Michael McCandless commented on LUCENE-8600: +1, nice! > DocValuesFieldUpdates should use a

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2018-12-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721504#comment-16721504 ] Michael McCandless commented on LUCENE-8601: Patch looks great [~muralikpbhat]; impressive

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721299#comment-16721299 ] Michael McCandless commented on LUCENE-8609: Yeah +1 to deprecate! > Allow getting

[jira] [Commented] (LUCENE-8592) MultiSorter#sort incorrectly sort Integer/Long#MIN_VALUE when the natural sort is reversed

2018-12-07 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713130#comment-16713130 ] Michael McCandless commented on LUCENE-8592: +1, patch looks great!  Thanks [~jim.ferenczi].

[jira] [Commented] (LUCENE-8592) MultiSorter#sort incorrectly sort Integer/Long#MIN_VALUE when the natural sort is reversed

2018-12-07 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713127#comment-16713127 ] Michael McCandless commented on LUCENE-8592: Thanks [~jim.ferenczi], I'll look now! >

[jira] [Commented] (LUCENE-8592) MultiSorter#sort incorrectly sort Integer/Long#MIN_VALUE when the natural sort is reversed

2018-12-07 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712958#comment-16712958 ] Michael McCandless commented on LUCENE-8592: Phew this is evil, nice catch [~jim.ferenczi]!

[jira] [Commented] (LUCENE-8592) MultiSorter#sort incorrectly sort Integer/Long#MIN_VALUE when the natural sort is reversed

2018-12-07 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712938#comment-16712938 ] Michael McCandless commented on LUCENE-8592: I'll have a look; this is sneaky. >

[jira] [Created] (LUCENE-8595) TestMixedDocValuesUpdates.testTryUpdateMultiThreaded fails

2018-12-06 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-8595: -- Summary: TestMixedDocValuesUpdates.testTryUpdateMultiThreaded fails Key: LUCENE-8595 URL: https://issues.apache.org/jira/browse/LUCENE-8595 Project:

[jira] [Commented] (LUCENE-8562) Speed up merging segments of points with data dimensions

2018-12-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705899#comment-16705899 ] Michael McCandless commented on LUCENE-8562: Wow! > Speed up merging segments of points

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2018-11-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699316#comment-16699316 ] Michael McCandless commented on LUCENE-8574: +1, patch looks good. >

[jira] [Created] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2018-11-24 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-8574: -- Summary: ExpressionFunctionValues should cache per-hit value Key: LUCENE-8574 URL: https://issues.apache.org/jira/browse/LUCENE-8574 Project: Lucene -

[jira] [Commented] (LUCENE-8564) Make it easier to iterate over graphs in tokenstreams

2018-11-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685716#comment-16685716 ] Michael McCandless commented on LUCENE-8564: This sounds great – we need to make it easier

[jira] [Commented] (SOLR-12964) Use advanceExact instead of advance in a few remaining json facet use cases

2018-11-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682006#comment-16682006 ] Michael McCandless commented on SOLR-12964: --- {quote}what do you think about making 

[jira] [Commented] (SOLR-12259) Robustly upgrade indexes

2018-11-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675320#comment-16675320 ] Michael McCandless commented on SOLR-12259: --- Maybe you could abstract out the Solr specific

[jira] [Commented] (LUCENE-8558) Adding NumericDocValuesFields is slowing down the indexing process significantly

2018-11-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675308#comment-16675308 ] Michael McCandless commented on LUCENE-8558: +1, nice catch! > Adding

[jira] [Commented] (LUCENE-8508) Add the ability to set the version that created the index

2018-09-18 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619818#comment-16619818 ] Michael McCandless commented on LUCENE-8508: +1 > Add the ability to set the version that

[jira] [Resolved] (LUCENE-8459) Add SearcherTaxonomyManager constructor taking already opened readers

2018-09-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-8459. Resolution: Fixed > Add SearcherTaxonomyManager constructor taking already opened

[jira] [Commented] (LUCENE-8343) BlendedInfixSuggester bad score calculus for certain suggestion weights

2018-09-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610825#comment-16610825 ] Michael McCandless commented on LUCENE-8343: Thanks [~alessandro.benedetti]; I'll have a

[jira] [Commented] (LUCENE-8343) BlendedInfixSuggester bad score calculus for certain suggestion weights

2018-09-10 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609554#comment-16609554 ] Michael McCandless commented on LUCENE-8343: [~alessandro.benedetti] if you can resolve the

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2018-09-10 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609536#comment-16609536 ] Michael McCandless commented on LUCENE-7882: Thanks for the explanation [~hypothesisx86];

[jira] [Commented] (LUCENE-8347) BlendedInfixSuggester to handle multi term matches better

2018-09-10 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609513#comment-16609513 ] Michael McCandless commented on LUCENE-8347: This is a good idea, but we need to settle

[jira] [Commented] (LUCENE-7862) Should BKD cells store their min/max packed values?

2018-09-10 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609483#comment-16609483 ] Michael McCandless commented on LUCENE-7862: Wow, these are surprisingly massive speedups in

[jira] [Commented] (LUCENE-7882) Maybe expression compiler should cache recently compiled expressions?

2018-08-31 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599031#comment-16599031 ] Michael McCandless commented on LUCENE-7882: But even once the JVM fixes its bugs and we can

[jira] [Commented] (LUCENE-8471) Expose the number of bytes currently being flushed in IndexWriter

2018-08-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596628#comment-16596628 ] Michael McCandless commented on LUCENE-8471: +1, but could we name it {{getFlushingBytes}}

[jira] [Updated] (LUCENE-8459) Add SearcherTaxonomyManager constructor taking already opened readers

2018-08-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-8459: --- Attachment: LUCENE-8459.patch > Add SearcherTaxonomyManager constructor taking

  1   2   3   4   5   6   7   8   9   10   >