[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-15 Thread hamada (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514102#comment-16514102 ] hamada commented on SOLR-11216: --- General review comments, some not related to the patch but relevant In

[jira] [Commented] (SOLR-11216) Make PeerSync more robust

2018-06-12 Thread hamada (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509971#comment-16509971 ] hamada commented on SOLR-11216: --- from 20,000 foot level. Any time based solution is just brittle, solution

[jira] [Created] (SOLR-12354) org.apache.solr.security.PKIAuthenticationPlugin does not check response code when retrieving remotePublicKey

2018-05-14 Thread hamada (JIRA)
hamada created SOLR-12354: - Summary: org.apache.solr.security.PKIAuthenticationPlugin does not check response code when retrieving remotePublicKey Key: SOLR-12354 URL: https://issues.apache.org/jira/browse/SOLR-12354

[jira] [Comment Edited] (SOLR-11892) Avoid unnecessary exceptions in FSDirectory and RAMDirectory

2018-01-29 Thread hamada (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343976#comment-16343976 ] hamada edited comment on SOLR-11892 at 1/29/18 8:42 PM: specifically the code of

[jira] [Commented] (SOLR-11892) Avoid unnecessary exceptions in FSDirectory and RAMDirectory

2018-01-29 Thread hamada (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343976#comment-16343976 ] hamada commented on SOLR-11892: --- specifically the code of interest where an IOException is thrown :

[jira] [Commented] (SOLR-11892) Avoid unnecessary exceptions in FSDirectory and RAMDirectory

2018-01-29 Thread hamada (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343843#comment-16343843 ] hamada commented on SOLR-11892: --- Few points about Exception cost: * It can not be assumed that all JVM's