[GitHub] lucene-solr pull request:

2016-02-01 Thread mkhludnev
Github user mkhludnev commented on the pull request: https://github.com/apache/lucene-solr/commit/ff8e841fa1b26875a95fd3ec67cd785649ba35b3#commitcomment-15792753 In solr/core/src/java/org/apache/solr/update/DeleteByQueryWrapper.java: In solr/core/src/java/org/apache/solr/update

[GitHub] lucene-solr pull request: Removal of Scorer.weight

2014-03-28 Thread mkhludnev
Github user mkhludnev commented on the pull request: https://github.com/apache/lucene-solr/pull/40#issuecomment-38898977 off-top. colleague of mine just send me the pic ![47797672](https://cloud.githubusercontent.com/assets/807522/2547791/c2d5b862-b656-11e3-8fab-c2b3237aa897.jpg

[GitHub] lucene-solr pull request: Removal of Scorer.weight

2014-03-28 Thread mkhludnev
Github user mkhludnev commented on the pull request: https://github.com/apache/lucene-solr/pull/40#issuecomment-38966314 Terry, I think Robert seconds the coord cleanup, let's wait till he reviews it. If you want to know my opinion, I already supported it above. Good shoot

[GitHub] lucene-solr pull request: Removal of Scorer.weight

2014-03-26 Thread mkhludnev
Github user mkhludnev commented on the pull request: https://github.com/apache/lucene-solr/pull/40#issuecomment-38673813 Terry, IMHO 1). But I rather prefer that the person who establish this API judges this evolution, because he has plan or vision in mind. Coming back

[GitHub] lucene-solr pull request: Removal of Scorer.weight

2014-03-12 Thread mkhludnev
Github user mkhludnev commented on the pull request: https://github.com/apache/lucene-solr/pull/40#issuecomment-37409000 Terry, Yep, passing Weight everywhere might be overwhelming. My case for scorer.weight.query usage, is own drill-sideway facet collector. I run standard

[GitHub] lucene-solr pull request: Removal of Scorer.weight

2014-03-11 Thread mkhludnev
Github user mkhludnev commented on the pull request: https://github.com/apache/lucene-solr/pull/40#issuecomment-37287237 Terry, So far, cleanup in Boolean* classes seems good, but I have to mention that the bunch of my custom queries need to distinguish scorers by obtaining Query

[GitHub] lucene-solr pull request: LUCENE-5092, 2nd try

2014-02-16 Thread mkhludnev
Github user mkhludnev commented on the pull request: https://github.com/apache/lucene-solr/pull/33#issuecomment-35233474 I like it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your response