Github user rmuir commented on the issue:
https://github.com/apache/lucene-solr/pull/375
{quote}
When PrefixCompletionQuery has an empty term, its automaton is actually *
-- maybe we could look into adding a fix/ optimization there in a follow-up.
{quote}
Regexp query
Github user rmuir commented on the issue:
https://github.com/apache/lucene-solr/pull/374
FWIW i would maybe support a change that calls
Objects.html#equals(java.lang.Object, java.lang.Object) on file keys *in
addition* to the current ctime check.
More checks are better
Github user rmuir commented on the issue:
https://github.com/apache/lucene-solr/pull/374
right it has FileKey but its not used for keyFile, just locking and stuff :)
I don't think its more useful to use an unreliable method, as opposed to
using simple filesystem metadata
Github user rmuir commented on the issue:
https://github.com/apache/lucene-solr/pull/374
fileKey is implemented on windows, so its untrue that nothing would change.
in general, the problem is with the metadata on gluster. lockfactory gets
picked on because its the first thing
Github user rmuir commented on the issue:
https://github.com/apache/lucene-solr/pull/374
FileKey was avoided intentionally for several reasons here: specifically
because of problems on windows operating systems. In this case the root problem
is GlusterFS, it has inconsistent metadata
Github user rmuir commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/129#discussion_r25448647
--- Diff:
lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java
---
@@ -565,11 +566,16 @@ private static int
Github user rmuir commented on commit e6718e408941ba7ab3eb61d4d14d1f1e3f9fed5f:
https://github.com/apache/lucene-solr/commit/e6718e408941ba7ab3eb61d4d14d1f1e3f9fed5f#commitcomment-357
In lucene/core/src/java/org/apache/lucene/store/FSDirectory.java:
In lucene/core/src/java/org
Github user rmuir commented on the pull request:
https://github.com/apache/lucene-solr/pull/43#issuecomment-37806850
Thank you very much! I just committed this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmuir commented on the pull request:
https://github.com/apache/lucene-solr/pull/40#issuecomment-37408333
I can take care, i just want to do a proper review first and I ran out of
time yesterday.
As far as Scorer.getWeight, the tests may not expose this so much
Github user rmuir commented on the pull request:
https://github.com/apache/lucene-solr/pull/40#issuecomment-37290855
No matter what happens here, we should at least do the coord cleanup.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rmuir commented on the pull request:
https://github.com/apache/lucene-solr/pull/38#issuecomment-35642048
See the jira issue. Paul raised this months ago.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do
11 matches
Mail list logo
