[GitHub] lucene-solr issue #405: don't die when java prints tool options

[sarowe]

Github user sarowe commented on the issue:

https://github.com/apache/lucene-solr/pull/405
  
Can you make a JIRA issue to track this please?  
https://wiki.apache.org/solr/HowToContribute#JIRA_tips_.28our_issue.2Fbug_tracker.29

Also, it might be better to extract the line containing version info, 
rather than ignoring specific lines that don't contain it, since there may be 
other bad output lines in the future.


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr issue #263: Backporting of SOLR-11477 on branch_5_5

[sarowe]

Github user sarowe commented on the issue:

https://github.com/apache/lucene-solr/pull/263
  
Thanks Sanne!  I committed your patch with these changes: 

* The release will be 5.5.5, so I moved the CHANGES.txt entries under that 
release.
* One of the .java files had some unused imports that I removed.

I tried to close the pull request ("This closes #263" in the commit log 
message), but it didn't seem to work - would you please close this?  Thanks.


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr issue #238: LUCENE-7490: Bengali Language Analyzer for Lucene

[sarowe]

Github user sarowe commented on the issue:

https://github.com/apache/lucene-solr/pull/238
  
@sunkuet02 : please fix the JIRA issue in the title for this pull request 
to LUCENE-7940 - otherwise activity will be posted to the wrong JIRA issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #187: LUCENE-7785: Move dictionary for Ukrainan ana...

[sarowe]

Github user sarowe commented on a diff in the pull request:

https://github.com/apache/lucene-solr/pull/187#discussion_r111573637
  
--- Diff: lucene/analysis/morfologik/ivy.xml ---
@@ -25,6 +25,7 @@
 
 
 
+
--- End diff --

The `rev` attribute value has to be of the form `"${/org/name}"` - this 
will not pass precommit.  You have to make such an entry in 
`ivy-versions.properties` - look at all the other examples there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #187: LUCENE-7785: Move dictionary for Ukrainan ana...

[sarowe]

Github user sarowe commented on a diff in the pull request:

https://github.com/apache/lucene-solr/pull/187#discussion_r111574446
  
--- Diff: lucene/ivy-versions.properties ---
@@ -203,6 +203,8 @@ org.carrot2.morfologik.version = 2.1.1
 /org.carrot2/morfologik-polish = ${org.carrot2.morfologik.version}
 /org.carrot2/morfologik-stemming = ${org.carrot2.morfologik.version}
 
+ua.net.nlp.morfologik-ukrainian-search.version = 3.7.4
--- End diff --

This is fine, but you're missing the `/org/name=version` thing that's 
required to be used in `ivy.xml` files.

If you look at the rest of this file, you can see that some `/org/name` 
keys share the same version, and so a variable is introduced to simplify 
maintenance.  In your case, when there is only one `/org/name` key using this 
version, you should IMO eliminate the 
`ua.net.nlp.morfologik-ukrainian-search.version` variable entirely and add 
`/ua.net.nlp/morfologik-ukrainian-search = 3.7.4`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org