[jira] [Comment Edited] (LUCENE-8640) validate delimiters when parsing date ranges
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753749#comment-16753749
]
Mikhail Khludnev edited comment on LUCENE-8640 at 1/28/19 7:27 AM:
---
-oh, yeah.. it doesn't get well with dinosaurs era {{Improperly formatted
datetime: -187183959-07-06T11:00:57.156}}-
nope. turns out. the code hits false negative on 00 minutes. Let's remind the
trivia. We might have hours from 0 to 24 inclusively, but minutes and seconds
are just 0..59. Right?
Pushing fix with this assumption.
was (Author: mkhludnev):
oh, yeah.. it doesn't get well with dinosaurs era {{Improperly formatted
datetime: -187183959-07-06T11:00:57.156}}
> validate delimiters when parsing date ranges
>
>
> Key: LUCENE-8640
> URL: https://issues.apache.org/jira/browse/LUCENE-8640
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Attachments: LUCENE-8640.patch, LUCENE-8640.patch, LUCENE-8640.patch,
> LUCENE-8640.patch, mypatch.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> {{DateRangePrefixTree.parseCalendar()}} should validate delimiters to rejects
> dates like {{2000-11T13}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-8640) validate delimiters when parsing date ranges
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746059#comment-16746059
]
Lucky Sharma edited comment on LUCENE-8640 at 1/18/19 9:28 AM:
---
Sure, I was unaware of the pattern for the patch file, Will take care of this
in future.
I have updated the patch file name Here also,
was (Author: lsharma3):
Sure, I was unaware of the pattern for the patch file, Will take care of this
in future.
> validate delimiters when parsing date ranges
>
>
> Key: LUCENE-8640
> URL: https://issues.apache.org/jira/browse/LUCENE-8640
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
>Reporter: Mikhail Khludnev
>Priority: Major
> Attachments: LUCENE-8640.patch, mypatch.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {{DateRangePrefixTree.parseCalendar()}} should validate delimiters to rejects
> dates like {{2000-11T13}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-8640) validate delimiters when parsing date ranges
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744039#comment-16744039
]
Lucky Sharma edited comment on LUCENE-8640 at 1/16/19 1:30 PM:
---
yes It passed that test
was (Author: lsharma3):
yes
> validate delimiters when parsing date ranges
>
>
> Key: LUCENE-8640
> URL: https://issues.apache.org/jira/browse/LUCENE-8640
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
>Reporter: Mikhail Khludnev
>Priority: Major
> Attachments: mypatch.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{DateRangePrefixTree.parseCalendar()}} should validate delimiters to rejects
> dates like {{2000-11T13}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-8640) validate delimiters when parsing date ranges
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743757#comment-16743757
]
Lucky Sharma edited comment on LUCENE-8640 at 1/16/19 8:44 AM:
---
Should we reject the date completely? or just we can send the calendar which is
matching with the date partially.
In the above example with the valid year 2000 and month 11 with Hour 13
was (Author: lsharma3):
Should we reject the date completely? or just we can send the calendar which is
matching with the date partially.
In the above example with the valid year 2000 and month with Hour 13
> validate delimiters when parsing date ranges
>
>
> Key: LUCENE-8640
> URL: https://issues.apache.org/jira/browse/LUCENE-8640
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
>Reporter: Mikhail Khludnev
>Priority: Major
>
> {{DateRangePrefixTree.parseCalendar()}} should validate delimiters to rejects
> dates like {{2000-11T13}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-8640) validate delimiters when parsing date ranges
[
https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743757#comment-16743757
]
Lucky Sharma edited comment on LUCENE-8640 at 1/16/19 8:44 AM:
---
Should we reject the date completely? or just we can send the calendar which is
matching with the date partially.
In the above example with the valid year 2000 and month with Hour 13
was (Author: lsharma3):
Should we reject the date completely? or just we can send the calendar with the
valid year and month with Hour 13
> validate delimiters when parsing date ranges
>
>
> Key: LUCENE-8640
> URL: https://issues.apache.org/jira/browse/LUCENE-8640
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
>Reporter: Mikhail Khludnev
>Priority: Major
>
> {{DateRangePrefixTree.parseCalendar()}} should validate delimiters to rejects
> dates like {{2000-11T13}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
