[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121680#comment-13121680
]
Robert Muir commented on LUCENE-1536:
-
Thanks Uwe for the reviewing/policing!
Chris,
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121693#comment-13121693
]
Chris Male commented on LUCENE-1536:
What do you think of the idea of passing
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120252#comment-13120252
]
Michael McCandless commented on LUCENE-1536:
What a tiny patch this has
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120264#comment-13120264
]
Robert Muir commented on LUCENE-1536:
-
{quote}
For the default IS heuristic, how
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120293#comment-13120293
]
Robert Muir commented on LUCENE-1536:
-
Also, when we pass filter down low as
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120356#comment-13120356
]
Robert Muir commented on LUCENE-1536:
-
and current patch is missing the optimization
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120362#comment-13120362
]
Michael McCandless commented on LUCENE-1536:
{quote}
How about grab an
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120372#comment-13120372
]
Michael McCandless commented on LUCENE-1536:
Duh, nevermind: I think it is
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120388#comment-13120388
]
Michael McCandless commented on LUCENE-1536:
Patch looks great!
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119005#comment-13119005
]
Robert Muir commented on LUCENE-1536:
-
I don't understand the de-optimizations to
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119006#comment-13119006
]
Chris Male commented on LUCENE-1536:
I used what has been in the patches so far. If
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119007#comment-13119007
]
Robert Muir commented on LUCENE-1536:
-
it doesnt have anything to do with this issue.
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117242#comment-13117242
]
Michael McCandless commented on LUCENE-1536:
bq. And I think a simple
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117246#comment-13117246
]
Chris Male commented on LUCENE-1536:
+1 to this approach.
bq. Separately we still
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117288#comment-13117288
]
Michael McCandless commented on LUCENE-1536:
OK, DocIdSet seems good too? It
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117291#comment-13117291
]
Chris Male commented on LUCENE-1536:
bq. Maybe .containsOnlyLiveDocs()?
+1
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116371#comment-13116371
]
Michael McCandless commented on LUCENE-1536:
bq. Wouldn't it make sense for
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116378#comment-13116378
]
Michael McCandless commented on LUCENE-1536:
bq. I'm definitely +1 to
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116407#comment-13116407
]
Chris Male commented on LUCENE-1536:
bq. I really don't think we should pollute Bits
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116651#comment-13116651
]
Michael McCandless commented on LUCENE-1536:
+1, that change is a rote
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116702#comment-13116702
]
Robert Muir commented on LUCENE-1536:
-
{quote}
Then separately we can figure out how
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115806#comment-13115806
]
Uwe Schindler commented on LUCENE-1536:
---
Wouldn't it make sense for FCRF to always
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115811#comment-13115811
]
Uwe Schindler commented on LUCENE-1536:
---
Why does CachingWrapperFilter refers to
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116123#comment-13116123
]
Chris Male commented on LUCENE-1536:
I haven't had a chance to look at the latest
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113912#comment-13113912
]
Chris Male commented on LUCENE-1536:
Actually, the more I look at the nocommits, the
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113965#comment-13113965
]
Michael McCandless commented on LUCENE-1536:
bq. But I like we should maybe
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114041#comment-13114041
]
Robert Muir commented on LUCENE-1536:
-
I didnt look too hard here at whats going on,
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113542#comment-13113542
]
Michael McCandless commented on LUCENE-1536:
bq. Would it make more sense to
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113552#comment-13113552
]
Chris Male commented on LUCENE-1536:
bq. You mean instanceof check instead of
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113598#comment-13113598
]
Michael McCandless commented on LUCENE-1536:
bq. What if we were to expose
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113899#comment-13113899
]
Chris Male commented on LUCENE-1536:
bq. Hmm that makes me nervous, since computing
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112621#comment-13112621
]
Uwe Schindler commented on LUCENE-1536:
---
bq. The only dated aspect is the use of
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112782#comment-13112782
]
Michael McCandless commented on LUCENE-1536:
Looks good Chris; thanks for
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113167#comment-13113167
]
Chris Male commented on LUCENE-1536:
Few questions:
- Would it make more sense to
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055544#comment-13055544
]
Michael McCandless commented on LUCENE-1536:
bq. My question: Do we really
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055581#comment-13055581
]
Robert Muir commented on LUCENE-1536:
-
{quote}
+1 for getVisibleDocs – I also don't
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055169#comment-13055169
]
Uwe Schindler commented on LUCENE-1536:
---
Hi Mike,
nicae patch, only little bit big.
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055181#comment-13055181
]
Uwe Schindler commented on LUCENE-1536:
---
One more comment about
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12928948#action_12928948
]
Michael McCandless commented on LUCENE-1536:
bq. Wondering what are your
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854612#action_12854612
]
Michael McCandless commented on LUCENE-1536:
With flex, you can now get the
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12722538#action_12722538
]
Michael McCandless commented on LUCENE-1536:
bq. that requires adding a
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705257#action_12705257
]
Michael McCandless commented on LUCENE-1536:
{quote}
Early termination
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705008#action_12705008
]
Michael McCandless commented on LUCENE-1536:
bq. Has anyone tested if this
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705012#action_12705012
]
Michael McCandless commented on LUCENE-1536:
I don't think it should be the
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705013#action_12705013
]
Michael McCandless commented on LUCENE-1536:
I don't think it should be the
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704590#action_12704590
]
Yonik Seeley commented on LUCENE-1536:
--
Interesting stuff!
Has anyone tested if this
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12700984#action_12700984
]
Jason Rutherglen commented on LUCENE-1536:
--
Perhaps we can go ahead with this
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699558#action_12699558
]
Uwe Schindler commented on LUCENE-1536:
---
How about DocIdSet adds a
{code}
boolean
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699571#action_12699571
]
Uwe Schindler commented on LUCENE-1536:
---
The empty docidset instance should *not* be
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699573#action_12699573
]
Uwe Schindler commented on LUCENE-1536:
---
And the switch for different densities:
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699669#action_12699669
]
Michael McCandless commented on LUCENE-1536:
I like this approach!
But should
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699675#action_12699675
]
Uwe Schindler commented on LUCENE-1536:
---
I coupled the density check inside the
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699680#action_12699680
]
Michael McCandless commented on LUCENE-1536:
OK, if we do choose to couple,
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699892#action_12699892
]
Jason Rutherglen commented on LUCENE-1536:
--
I thought we are going to get
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699939#action_12699939
]
Michael McCandless commented on LUCENE-1536:
Ahh right, we should re-test
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679665#action_12679665
]
Paul Elschot commented on LUCENE-1536:
--
For the skipToButNotNext() did you mean sth
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679690#action_12679690
]
Michael McCandless commented on LUCENE-1536:
Ahh, that's actually something
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12672005#action_12672005
]
Michael McCandless commented on LUCENE-1536:
OK I tested a different approach
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670449#action_12670449
]
Michael McCandless commented on LUCENE-1536:
Test results:
||%tg
[
https://issues.apache.org/jira/browse/LUCENE-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670455#action_12670455
]
Michael McCandless commented on LUCENE-1536:
Some ideas / further things to
101 - 160 of 160 matches
Mail list logo
