[jira] [Commented] (LUCENE-8554) Add new LatLonShapeLineQuery
[ https://issues.apache.org/jira/browse/LUCENE-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685543#comment-16685543 ] Nicholas Knize commented on LUCENE-8554: Just pointing out there was a nice performance improvement side effect from this patch: Seen here in [geobench.html#search-polyMedium|http://people.apache.org/~mikemccand/geobench.html#search-polyMedium] A simple optimization was added to [EdgeTree.java#330|https://github.com/apache/lucene-solr/blob/95d01c6583b825b6b87591e4f27002c285ea25fb/lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java#L330] to check if either end of the polygon's line segment is contained by the target rectangle. This optimization skips all of the determinant calculations below giving what appears to be a boost in search performance of ~1.4 QPS for {{LatLonPoint#newPolygonQuery}} > Add new LatLonShapeLineQuery > > > Key: LUCENE-8554 > URL: https://issues.apache.org/jira/browse/LUCENE-8554 > Project: Lucene - Core > Issue Type: New Feature >Affects Versions: 7.6, master (8.0) >Reporter: Nicholas Knize >Assignee: Nicholas Knize >Priority: Blocker > Attachments: LUCENE-8554.patch, LUCENE-8554.patch > > > Its often useful to be able to query a shape index for documents that either > {{INTERSECT}} or are {{DISJOINT}} from a given {{LINESTRING}}. Occasionally > the linestring of interest may also have a distance component, which creates > a *buffered query* (often used in routing, or shape snapping). This feature > first adds a new {{LatLonShapeLineQuery}} for querying {{LatLonShape}} > fields by arbitrary lines. A distance component can then be added in a future > issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8554) Add new LatLonShapeLineQuery
[ https://issues.apache.org/jira/browse/LUCENE-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674965#comment-16674965 ] ASF subversion and git services commented on LUCENE-8554: - Commit 0cbefe8b25044a0f565c8491bda86626f2eddf5e in lucene-solr's branch refs/heads/jira/http2 from [~nknize] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0cbefe8 ] LUCENE-8554: Add new LatLonShapeLineQuery that queries indexed LatLonShape fields by arbitrary lines > Add new LatLonShapeLineQuery > > > Key: LUCENE-8554 > URL: https://issues.apache.org/jira/browse/LUCENE-8554 > Project: Lucene - Core > Issue Type: New Feature >Affects Versions: 7.6, master (8.0) >Reporter: Nicholas Knize >Assignee: Nicholas Knize >Priority: Blocker > Attachments: LUCENE-8554.patch, LUCENE-8554.patch > > > Its often useful to be able to query a shape index for documents that either > {{INTERSECT}} or are {{DISJOINT}} from a given {{LINESTRING}}. Occasionally > the linestring of interest may also have a distance component, which creates > a *buffered query* (often used in routing, or shape snapping). This feature > first adds a new {{LatLonShapeLineQuery}} for querying {{LatLonShape}} > fields by arbitrary lines. A distance component can then be added in a future > issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8554) Add new LatLonShapeLineQuery
[ https://issues.apache.org/jira/browse/LUCENE-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673415#comment-16673415 ] ASF subversion and git services commented on LUCENE-8554: - Commit a00cc3be72bbb39430f6b895a4d29a26bce4f6b4 in lucene-solr's branch refs/heads/branch_7x from [~nknize] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a00cc3b ] LUCENE-8554: Add new LatLonShapeLineQuery that queries indexed LatLonShape fields by arbitrary lines > Add new LatLonShapeLineQuery > > > Key: LUCENE-8554 > URL: https://issues.apache.org/jira/browse/LUCENE-8554 > Project: Lucene - Core > Issue Type: New Feature >Affects Versions: 7.6, master (8.0) >Reporter: Nicholas Knize >Assignee: Nicholas Knize >Priority: Blocker > Attachments: LUCENE-8554.patch, LUCENE-8554.patch > > > Its often useful to be able to query a shape index for documents that either > {{INTERSECT}} or are {{DISJOINT}} from a given {{LINESTRING}}. Occasionally > the linestring of interest may also have a distance component, which creates > a *buffered query* (often used in routing, or shape snapping). This feature > first adds a new {{LatLonShapeLineQuery}} for querying {{LatLonShape}} > fields by arbitrary lines. A distance component can then be added in a future > issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8554) Add new LatLonShapeLineQuery
[ https://issues.apache.org/jira/browse/LUCENE-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673404#comment-16673404 ] ASF subversion and git services commented on LUCENE-8554: - Commit 0cbefe8b25044a0f565c8491bda86626f2eddf5e in lucene-solr's branch refs/heads/master from [~nknize] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0cbefe8 ] LUCENE-8554: Add new LatLonShapeLineQuery that queries indexed LatLonShape fields by arbitrary lines > Add new LatLonShapeLineQuery > > > Key: LUCENE-8554 > URL: https://issues.apache.org/jira/browse/LUCENE-8554 > Project: Lucene - Core > Issue Type: New Feature >Affects Versions: 7.6, master (8.0) >Reporter: Nicholas Knize >Assignee: Nicholas Knize >Priority: Blocker > Attachments: LUCENE-8554.patch, LUCENE-8554.patch > > > Its often useful to be able to query a shape index for documents that either > {{INTERSECT}} or are {{DISJOINT}} from a given {{LINESTRING}}. Occasionally > the linestring of interest may also have a distance component, which creates > a *buffered query* (often used in routing, or shape snapping). This feature > first adds a new {{LatLonShapeLineQuery}} for querying {{LatLonShape}} > fields by arbitrary lines. A distance component can then be added in a future > issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8554) Add new LatLonShapeLineQuery
[ https://issues.apache.org/jira/browse/LUCENE-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672829#comment-16672829 ] Ignacio Vera commented on LUCENE-8554: -- LGTM. I have a minor comment about java docs: EdgeTree: Javadocs refer to Polygon2D. Line2D: Javadocs refer to Polygon2D. LatLonShapeLineQuery: I think the line that refers to how shapes are indexed is inaccurate. LatLonShape: Add java docs to functions that creates queries. > Add new LatLonShapeLineQuery > > > Key: LUCENE-8554 > URL: https://issues.apache.org/jira/browse/LUCENE-8554 > Project: Lucene - Core > Issue Type: New Feature >Affects Versions: 7.6, master (8.0) >Reporter: Nicholas Knize >Assignee: Nicholas Knize >Priority: Blocker > Attachments: LUCENE-8554.patch, LUCENE-8554.patch > > > Its often useful to be able to query a shape index for documents that either > {{INTERSECT}} or are {{DISJOINT}} from a given {{LINESTRING}}. Occasionally > the linestring of interest may also have a distance component, which creates > a *buffered query* (often used in routing, or shape snapping). This feature > first adds a new {{LatLonShapeLineQuery}} for querying {{LatLonShape}} > fields by arbitrary lines. A distance component can then be added in a future > issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org