[jira] [Commented] (LUCENE-8559) Tessellator: isIntersectingPolygon method skip polygon edges

2018-11-06 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/LUCENE-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677761#comment-16677761
 ] 

ASF subversion and git services commented on LUCENE-8559:
-

Commit d214f968d765e5c30c8782c5545c38d9aef487fe in lucene-solr's branch 
refs/heads/branch_7x from iverase
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d214f96 ]

LUCENE-8559: Fix bug where polygon edges were skipped when checking for 
intersections


> Tessellator: isIntersectingPolygon method skip polygon edges
> 
>
> Key: LUCENE-8559
> URL: https://issues.apache.org/jira/browse/LUCENE-8559
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/sandbox
>Affects Versions: 7.6, master (8.0)
>Reporter: Ignacio Vera
>Priority: Blocker
> Attachments: LUCENE-8559.patch
>
>
> The following condition seems wrong:
> {code:java}
> if(node.getX() != x0 && node.getY() != y0 && nextNode.getX() != x0
> && nextNode.getY() != y0 && node.getX() != x1 && node.getY() != y1
> && nextNode.getX() != x1 && nextNode.getY() != y1) {
>//check intersection
> }{code}
> Any node with the same X or Y is skipped. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8559) Tessellator: isIntersectingPolygon method skip polygon edges

2018-11-06 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/LUCENE-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677760#comment-16677760
 ] 

ASF subversion and git services commented on LUCENE-8559:
-

Commit 9952af099ae65f051056fc8ff55c8e8f4cfb3b93 in lucene-solr's branch 
refs/heads/master from iverase
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9952af0 ]

LUCENE-8559: Fix bug where polygon edges were skipped when checking for 
intersections


> Tessellator: isIntersectingPolygon method skip polygon edges
> 
>
> Key: LUCENE-8559
> URL: https://issues.apache.org/jira/browse/LUCENE-8559
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/sandbox
>Affects Versions: 7.6, master (8.0)
>Reporter: Ignacio Vera
>Priority: Blocker
> Attachments: LUCENE-8559.patch
>
>
> The following condition seems wrong:
> {code:java}
> if(node.getX() != x0 && node.getY() != y0 && nextNode.getX() != x0
> && nextNode.getY() != y0 && node.getX() != x1 && node.getY() != y1
> && nextNode.getX() != x1 && nextNode.getY() != y1) {
>//check intersection
> }{code}
> Any node with the same X or Y is skipped. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8559) Tessellator: isIntersectingPolygon method skip polygon edges

2018-11-06 Thread Nicholas Knize (JIRA) 


[ 
https://issues.apache.org/jira/browse/LUCENE-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677313#comment-16677313
 ] 

Nicholas Knize commented on LUCENE-8559:


+1  Thank you [~ivera]

> Tessellator: isIntersectingPolygon method skip polygon edges
> 
>
> Key: LUCENE-8559
> URL: https://issues.apache.org/jira/browse/LUCENE-8559
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/sandbox
>Affects Versions: 7.6, master (8.0)
>Reporter: Ignacio Vera
>Priority: Blocker
> Attachments: LUCENE-8559.patch
>
>
> The following condition seems wrong:
> {code:java}
> if(node.getX() != x0 && node.getY() != y0 && nextNode.getX() != x0
> && nextNode.getY() != y0 && node.getX() != x1 && node.getY() != y1
> && nextNode.getX() != x1 && nextNode.getY() != y1) {
>//check intersection
> }{code}
> Any node with the same X or Y is skipped. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8559) Tessellator: isIntersectingPolygon method skip polygon edges

2018-11-05 Thread Lucene/Solr QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/LUCENE-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675099#comment-16675099
 ] 

Lucene/Solr QA commented on LUCENE-8559:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  0m 21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  0m 21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  0m 21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  5m 
53s{color} | {color:green} sandbox in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 46s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8559 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12946888/LUCENE-8559.patch |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
validatesourcepatterns  |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP 
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 45b772f |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_191 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-LUCENE-Build/118/testReport/ |
| modules | C: lucene/sandbox U: lucene/sandbox |
| Console output | 
https://builds.apache.org/job/PreCommit-LUCENE-Build/118/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Tessellator: isIntersectingPolygon method skip polygon edges
> 
>
> Key: LUCENE-8559
> URL: https://issues.apache.org/jira/browse/LUCENE-8559
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/sandbox
>Affects Versions: 7.6, master (8.0)
>Reporter: Ignacio Vera
>Priority: Blocker
> Attachments: LUCENE-8559.patch
>
>
> The following condition seems wrong:
> {code:java}
> if(node.getX() != x0 && node.getY() != y0 && nextNode.getX() != x0
> && nextNode.getY() != y0 && node.getX() != x1 && node.getY() != y1
> && nextNode.getX() != x1 && nextNode.getY() != y1) {
>//check intersection
> }{code}
> Any node with the same X or Y is skipped. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org