[jira] [Commented] (LUCENE-8649) LatLonShape: Within and disjoint queries don’t work with indexed multishapes
[ https://issues.apache.org/jira/browse/LUCENE-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750999#comment-16750999 ] ASF subversion and git services commented on LUCENE-8649: - Commit 01dfe7bf4b2bd05326c66cc6297300f3dd321547 in lucene-solr's branch refs/heads/master-deprecations from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=01dfe7b ] LUCENE-8649: LatLonShape's within and disjoint queries can return false positives with indexed multi-shapes > LatLonShape: Within and disjoint queries don’t work with indexed multishapes > > > Key: LUCENE-8649 > URL: https://issues.apache.org/jira/browse/LUCENE-8649 > Project: Lucene - Core > Issue Type: Bug > Components: modules/sandbox >Reporter: Ignacio Vera >Assignee: Ignacio Vera >Priority: Major > Fix For: 8.0, 7.7, master (9.0) > > Attachments: LUCENE-8649.patch, LUCENE-8649.patch, LUCENE-8649.patch, > LUCENE-8649.patch > > > Within and disjoint queries return wrong results (false positives) when > querying for fields containing more than one shape. For example, a > multipolygon will return true for a within query if some of the polygons are > within and the other are disjoint. The same query will return true for > disjoint. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8649) LatLonShape: Within and disjoint queries don’t work with indexed multishapes
[ https://issues.apache.org/jira/browse/LUCENE-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749622#comment-16749622 ] ASF subversion and git services commented on LUCENE-8649: - Commit 8cb89df72295523bc6b58a11579b0aa8174a323e in lucene-solr's branch refs/heads/branch_8x from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8cb89df ] LUCENE-8649: Add missing entry in CHANGES.txt > LatLonShape: Within and disjoint queries don’t work with indexed multishapes > > > Key: LUCENE-8649 > URL: https://issues.apache.org/jira/browse/LUCENE-8649 > Project: Lucene - Core > Issue Type: Bug > Components: modules/sandbox >Reporter: Ignacio Vera >Assignee: Ignacio Vera >Priority: Major > Fix For: 8.0, 7.7, master (9.0) > > Attachments: LUCENE-8649.patch, LUCENE-8649.patch, LUCENE-8649.patch, > LUCENE-8649.patch > > > Within and disjoint queries return wrong results (false positives) when > querying for fields containing more than one shape. For example, a > multipolygon will return true for a within query if some of the polygons are > within and the other are disjoint. The same query will return true for > disjoint. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8649) LatLonShape: Within and disjoint queries don’t work with indexed multishapes
[ https://issues.apache.org/jira/browse/LUCENE-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748010#comment-16748010 ] ASF subversion and git services commented on LUCENE-8649: - Commit e473c351dc5f23bb2241ccbc66322eae85082fa7 in lucene-solr's branch refs/heads/branch_7x from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e473c35 ] LUCENE-8649: LatLonShape's within and disjoint queries can return false positives with indexed multi-shapes > LatLonShape: Within and disjoint queries don’t work with indexed multishapes > > > Key: LUCENE-8649 > URL: https://issues.apache.org/jira/browse/LUCENE-8649 > Project: Lucene - Core > Issue Type: Bug > Components: modules/sandbox >Reporter: Ignacio Vera >Priority: Major > Attachments: LUCENE-8649.patch, LUCENE-8649.patch, LUCENE-8649.patch, > LUCENE-8649.patch > > > Within and disjoint queries return wrong results (false positives) when > querying for fields containing more than one shape. For example, a > multipolygon will return true for a within query if some of the polygons are > within and the other are disjoint. The same query will return true for > disjoint. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8649) LatLonShape: Within and disjoint queries don’t work with indexed multishapes
[ https://issues.apache.org/jira/browse/LUCENE-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748009#comment-16748009 ] ASF subversion and git services commented on LUCENE-8649: - Commit 440e6eaa8e9ea89bdf804278070367179f43dc67 in lucene-solr's branch refs/heads/branch_8x from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=440e6ea ] LUCENE-8649: LatLonShape's within and disjoint queries can return false positives with indexed multi-shapes > LatLonShape: Within and disjoint queries don’t work with indexed multishapes > > > Key: LUCENE-8649 > URL: https://issues.apache.org/jira/browse/LUCENE-8649 > Project: Lucene - Core > Issue Type: Bug > Components: modules/sandbox >Reporter: Ignacio Vera >Priority: Major > Attachments: LUCENE-8649.patch, LUCENE-8649.patch, LUCENE-8649.patch, > LUCENE-8649.patch > > > Within and disjoint queries return wrong results (false positives) when > querying for fields containing more than one shape. For example, a > multipolygon will return true for a within query if some of the polygons are > within and the other are disjoint. The same query will return true for > disjoint. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8649) LatLonShape: Within and disjoint queries don’t work with indexed multishapes
[ https://issues.apache.org/jira/browse/LUCENE-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748008#comment-16748008 ] ASF subversion and git services commented on LUCENE-8649: - Commit 01dfe7bf4b2bd05326c66cc6297300f3dd321547 in lucene-solr's branch refs/heads/master from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=01dfe7b ] LUCENE-8649: LatLonShape's within and disjoint queries can return false positives with indexed multi-shapes > LatLonShape: Within and disjoint queries don’t work with indexed multishapes > > > Key: LUCENE-8649 > URL: https://issues.apache.org/jira/browse/LUCENE-8649 > Project: Lucene - Core > Issue Type: Bug > Components: modules/sandbox >Reporter: Ignacio Vera >Priority: Major > Attachments: LUCENE-8649.patch, LUCENE-8649.patch, LUCENE-8649.patch, > LUCENE-8649.patch > > > Within and disjoint queries return wrong results (false positives) when > querying for fields containing more than one shape. For example, a > multipolygon will return true for a within query if some of the polygons are > within and the other are disjoint. The same query will return true for > disjoint. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8649) LatLonShape: Within and disjoint queries don’t work with indexed multishapes
[ https://issues.apache.org/jira/browse/LUCENE-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747805#comment-16747805 ] Adrien Grand commented on LUCENE-8649: -- Thanks Ignacio, it looks good to me, I just have two minor comments: - Maybe rename visitor2 to disjointVisitor since it seems to always be the visitor that collects disjoint triangles (and then maybe keep the first visitor called visitor rather than visitor1). - cost() is supposed to be an estimation of the match count, so it should probably return visitor2.cost() if the relation is DISJOINT and visitor1.count() instead? > LatLonShape: Within and disjoint queries don’t work with indexed multishapes > > > Key: LUCENE-8649 > URL: https://issues.apache.org/jira/browse/LUCENE-8649 > Project: Lucene - Core > Issue Type: Bug > Components: modules/sandbox >Reporter: Ignacio Vera >Priority: Major > Attachments: LUCENE-8649.patch, LUCENE-8649.patch, LUCENE-8649.patch > > > Within and disjoint queries return wrong results (false positives) when > querying for fields containing more than one shape. For example, a > multipolygon will return true for a within query if some of the polygons are > within and the other are disjoint. The same query will return true for > disjoint. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8649) LatLonShape: Within and disjoint queries don’t work with indexed multishapes
[ https://issues.apache.org/jira/browse/LUCENE-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747434#comment-16747434 ] Lucene/Solr QA commented on LUCENE-8649: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 7 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 22s{color} | {color:red} lucene_sandbox generated 6 new + 31 unchanged - 0 fixed = 37 total (was 31) {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 22s{color} | {color:green} sandbox in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 4m 29s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | LUCENE-8649 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12955506/LUCENE-8649.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / a692d05 | | ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 | | Default Java | 1.8.0_191 | | javac | https://builds.apache.org/job/PreCommit-LUCENE-Build/152/artifact/out/diff-compile-javac-lucene_sandbox.txt | | Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/152/testReport/ | | modules | C: lucene/sandbox U: lucene/sandbox | | Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/152/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > LatLonShape: Within and disjoint queries don’t work with indexed multishapes > > > Key: LUCENE-8649 > URL: https://issues.apache.org/jira/browse/LUCENE-8649 > Project: Lucene - Core > Issue Type: Bug > Components: modules/sandbox >Reporter: Ignacio Vera >Priority: Major > Attachments: LUCENE-8649.patch, LUCENE-8649.patch, LUCENE-8649.patch > > > Within and disjoint queries return wrong results (false positives) when > querying for fields containing more than one shape. For example, a > multipolygon will return true for a within query if some of the polygons are > within and the other are disjoint. The same query will return true for > disjoint. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org