[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853203#comment-16853203 ] Shawn Heisey commented on LUCENE-8807: -- bq, I also checked the new JAR checksums after the change with "ant jar-checksums" after refreshing everything. No SHA1 changes. I was catching up on my jira spam, and that caught my eye, sparked a thought. I wonder if we should update our hashing algorithm for these checksums, perhaps to sha-512, since sha1 was proven to be vulnerable. That would need to spin off into a new issue. > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch, LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{\*build.xml}} and > {{\*ivy\*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845009#comment-16845009 ] Adrien Grand commented on LUCENE-8807: -- As usual, thanks [~thetaphi] for taking care of these issues! > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch, LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{\*build.xml}} and > {{\*ivy\*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844988#comment-16844988 ] Uwe Schindler commented on LUCENE-8807: --- I also nuked ivy caches on policeman jenkins to have a fresh build there. > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch, LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{\*build.xml}} and > {{\*ivy\*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844938#comment-16844938 ] ASF subversion and git services commented on LUCENE-8807: - Commit 0654377fec274c33bedd9ebaa7cf5ebe3c6005b3 in lucene-solr's branch refs/heads/branch_7_7 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=0654377 ] LUCENE-8807: Change all download URLs in build files to HTTPS # Conflicts: # lucene/common-build.xml > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch, LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{\*build.xml}} and > {{\*ivy\*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844935#comment-16844935 ] ASF subversion and git services commented on LUCENE-8807: - Commit 19364ac76ba601959de08c7ec899876a8c91d297 in lucene-solr's branch refs/heads/branch_8_1 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=19364ac ] LUCENE-8807: Change all download URLs in build files to HTTPS # Conflicts: # lucene/common-build.xml > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch, LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{\*build.xml}} and > {{\*ivy\*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844934#comment-16844934 ] ASF subversion and git services commented on LUCENE-8807: - Commit c7146239969b7aaf2fe1e924f081120c9e0146b5 in lucene-solr's branch refs/heads/branch_8x from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c714623 ] LUCENE-8807: Change all download URLs in build files to HTTPS # Conflicts: # lucene/common-build.xml > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch, LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{\*build.xml}} and > {{\*ivy\*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844929#comment-16844929 ] ASF subversion and git services commented on LUCENE-8807: - Commit c756b50ae4324b5692b2956c7a5d484122ac3016 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c756b50 ] LUCENE-8807: Change all download URLs in build files to HTTPS > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch, LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{\*build.xml}} and > {{\*ivy\*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844903#comment-16844903 ] Uwe Schindler commented on LUCENE-8807: --- bq. Should be https instead of http2 Fixed locally. Thanks. > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch, LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies, but ASF asked all projects to ensure > that download URLs for dependencies are using HTTPS: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{*build.xml}} and > {{*ivy*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844899#comment-16844899 ] Kevin Risden commented on LUCENE-8807: -- [~thetaphi] - I think there is one typo in the patch from a quick review: Should be https instead of http2 > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch, LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies, but ASF asked all projects to ensure > that download URLs for dependencies are using HTTPS: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{*build.xml}} and > {{*ivy*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844871#comment-16844871 ] Uwe Schindler commented on LUCENE-8807: --- I changed the Ivy URL of mecab-naist-jdic, as the redirector was using HTTP again, this one works: https://rwthaachen.dl.osdn.jp/naist-jdic/53500/mecab-naist-jdic-0.6.3b-20111013.tar.gz > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch, LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies, but ASF asked all projects to ensure > that download URLs for dependencies are using HTTPS: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{*build.xml}} and > {{*ivy*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844866#comment-16844866 ] Uwe Schindler commented on LUCENE-8807: --- I am so annoyed, if I send them a mail or open issue, it would be a policeman like one... > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies, but ASF asked all projects to ensure > that download URLs for dependencies are using HTTPS: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{*build.xml}} and > {{*ivy*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844864#comment-16844864 ] Uwe Schindler commented on LUCENE-8807: --- FYI, the maven.restlet.org stuff annoyed me a lot: They changed from restlet.org to restlet.com. But the HTTPS one at https://maven.restlet.org redirected to the insecure http://maven.restlet.com which is a disallowed action and Ivy disallows this (of course). This took me half an hour to understand the issue. Somebody should tell those - that's incredible! > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 7.7.2, master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies, but ASF asked all projects to ensure > that download URLs for dependencies are using HTTPS: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{*build.xml}} and > {{*ivy*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844855#comment-16844855 ] Uwe Schindler commented on LUCENE-8807: --- I would like to push this soon to master, 8.x and the soon to be released bugfix versions. Please wait a bit with starting the release process. > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies, but ASF asked all projects to ensure > that download URLs for dependencies are using HTTPS: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{*build.xml}} and > {{*ivy*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844854#comment-16844854 ] Uwe Schindler commented on LUCENE-8807: --- I also checked the new JAR checksums after the change with "ant jar-checksums" after refreshing everything. No SHA1 changes. > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Major > Fix For: master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies, but ASF asked all projects to ensure > that download URLs for dependencies are using HTTPS: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{*build.xml}} and > {{*ivy*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844852#comment-16844852 ] Uwe Schindler commented on LUCENE-8807: --- Patch: [^LUCENE-8807.patch] I tested this: - Nuked whole IVY cache and ran "ant resolve". - Rebuild kuromoji - ran "ant ivy-bootstrap" after deleting the file - downloaded some benchmark files (although the benchmark mdoules documentation how to get data files is not existent...) > Change all download URLs in build files to HTTPS > > > Key: LUCENE-8807 > URL: https://issues.apache.org/jira/browse/LUCENE-8807 > Project: Lucene - Core > Issue Type: Task > Components: general/build >Affects Versions: 8.1 >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Major > Fix For: master (9.0), 8.2, 8.1.1 > > Attachments: LUCENE-8807.patch > > > At least for Lucene this is not a security issue, because we have checksums > for all downloaded JAR dependencies, but ASF asked all projects to ensure > that download URLs for dependencies are using HTTPS: > {quote} > [...] Projects like Lucene do checksum whitelists of > all their build dependencies, and you may wish to consider that as a > protection against threats beyond just MITM [...] > {quote} > This patch fixes the URLs for most files referenced in {{*build.xml}} and > {{*ivy*.xml}} to HTTPS. There are a few data files in benchmark which use > HTTP only, but that's uncritical and I added a TODO. Some were broken already. > I removed the "uk.maven.org" workarounds for Maven, as this does not work > with HTTPS. By keeping those inside, we break the whole chain of trust, as > any non-working HTTPS would fallback to the insecure uk.maven.org Maven > mirror. > As the great chinese firewall is changing all the time, we should just wait > for somebody complaining. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org