[jira] [Commented] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[ https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049893#comment-14049893 ] ASF subversion and git services commented on SOLR-5768: --- Commit 1607360 from sha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1607360 ] SOLR-5768: Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS --- Key: SOLR-5768 URL: https://issues.apache.org/jira/browse/SOLR-5768 Project: Solr Issue Type: Improvement Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Minor Fix For: 4.9, 5.0 Attachments: SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff Suggested by Yonik on solr-user: http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html {quote} Although it seems like it should be relatively simple to make it work with other fields as well, by passing down the complete fl requested if some optional parameter is set (distrib.singlePass?) {quote} -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[ https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049896#comment-14049896 ] ASF subversion and git services commented on SOLR-5768: --- Commit 1607361 from sha...@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1607361 ] SOLR-5768: Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS --- Key: SOLR-5768 URL: https://issues.apache.org/jira/browse/SOLR-5768 Project: Solr Issue Type: Improvement Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Minor Fix For: 4.9, 5.0 Attachments: SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff Suggested by Yonik on solr-user: http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html {quote} Although it seems like it should be relatively simple to make it work with other fields as well, by passing down the complete fl requested if some optional parameter is set (distrib.singlePass?) {quote} -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[ https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049958#comment-14049958 ] Gregg Donovan commented on SOLR-5768: - Thank you, Shalin! Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS --- Key: SOLR-5768 URL: https://issues.apache.org/jira/browse/SOLR-5768 Project: Solr Issue Type: Improvement Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Minor Fix For: 5.0, 4.10 Attachments: SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff Suggested by Yonik on solr-user: http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html {quote} Although it seems like it should be relatively simple to make it work with other fields as well, by passing down the complete fl requested if some optional parameter is set (distrib.singlePass?) {quote} -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[ https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13926170#comment-13926170 ] Gregg Donovan commented on SOLR-5768: - Thanks, Shalin! You're right -- it's not quite so easy. Here's an updated patch with a test that returns multiple fields in a single pass. I'm not sure if it's better to work with the fields as represented by rb.rsp.getReturnFields() or by rb.req.getParams().get(CommonParams.FL). Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS --- Key: SOLR-5768 URL: https://issues.apache.org/jira/browse/SOLR-5768 Project: Solr Issue Type: Improvement Reporter: Shalin Shekhar Mangar Priority: Minor Fix For: 4.8, 5.0 Attachments: SOLR-5768.diff Suggested by Yonik on solr-user: http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html {quote} Although it seems like it should be relatively simple to make it work with other fields as well, by passing down the complete fl requested if some optional parameter is set (distrib.singlePass?) {quote} -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[ https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925441#comment-13925441 ] Shalin Shekhar Mangar commented on SOLR-5768: - Thanks Gregg. # We need tests for this. # Any field other than id and score are not being passed to the shard queries so this patch is incomplete. Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS --- Key: SOLR-5768 URL: https://issues.apache.org/jira/browse/SOLR-5768 Project: Solr Issue Type: Improvement Reporter: Shalin Shekhar Mangar Priority: Minor Fix For: 4.8, 5.0 Attachments: SOLR-5768.diff Suggested by Yonik on solr-user: http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html {quote} Although it seems like it should be relatively simple to make it work with other fields as well, by passing down the complete fl requested if some optional parameter is set (distrib.singlePass?) {quote} -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org