[jira] [Commented] (SOLR-9514) replace BALANCESHARDUNIQUE command with a more generic SETREPLICAPROP command
[
https://issues.apache.org/jira/browse/SOLR-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493685#comment-15493685
]
Noble Paul commented on SOLR-9514:
--
Yes, we should deprecate {{BALANCESHARDUNIQUE}} and make ADDREPLICAPROP &
REMOVEREPLICAPROP do the job. If there is something missing we can add to these
commands
> replace BALANCESHARDUNIQUE command with a more generic SETREPLICAPROP command
> -
>
> Key: SOLR-9514
> URL: https://issues.apache.org/jira/browse/SOLR-9514
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>
> The current command is ambiguous and has limited application. We should
> replace it with something more generic like SETREPLICAPROP
> params are
> * property
> * value
> * replicaName
> * onePerShard
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9514) replace BALANCESHARDUNIQUE command with a more generic SETREPLICAPROP command
[ https://issues.apache.org/jira/browse/SOLR-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493640#comment-15493640 ] Erick Erickson commented on SOLR-9514: -- bq: interestingly, we already have a ADDREPLICAPROP and REMOVEREPLICA prop commands which do the same Probably where I stole the idea from. Which begs the question of whether the proper thing to do is just deprecate/remove BALANCESHARDUNIQUE altogether and make onePerShard an option on ADDREPLICAPROP. I'm all for removing code when possible. > replace BALANCESHARDUNIQUE command with a more generic SETREPLICAPROP command > - > > Key: SOLR-9514 > URL: https://issues.apache.org/jira/browse/SOLR-9514 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul > > The current command is ambiguous and has limited application. We should > replace it with something more generic like SETREPLICAPROP > params are > * property > * value > * replicaName > * onePerShard -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9514) replace BALANCESHARDUNIQUE command with a more generic SETREPLICAPROP command
[ https://issues.apache.org/jira/browse/SOLR-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492725#comment-15492725 ] Noble Paul commented on SOLR-9514: -- interestingly, we already have a ADDREPLICAPROP and REMOVEREPLICA prop commands which do the same https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-AddReplicaProp > replace BALANCESHARDUNIQUE command with a more generic SETREPLICAPROP command > - > > Key: SOLR-9514 > URL: https://issues.apache.org/jira/browse/SOLR-9514 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul > > The current command is ambiguous and has limited application. We should > replace it with something more generic like SETREPLICAPROP > params are > * property > * value > * replicaName > * onePerShard -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9514) replace BALANCESHARDUNIQUE command with a more generic SETREPLICAPROP command
[
https://issues.apache.org/jira/browse/SOLR-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492621#comment-15492621
]
Noble Paul commented on SOLR-9514:
--
bq. is to keep users from overwriting important properties
We must restrict users from overwriting well-known properties such as
{{node_name}} and {{base_url}}
so, what happens when a user does invokes
{{command=SETREPLICAPROP=node_name=mynodename}}. This will
result in a new property in the {{state.json}} as
{{property.node_name=mynodename}}
So, we never have a collision of property names
> replace BALANCESHARDUNIQUE command with a more generic SETREPLICAPROP command
> -
>
> Key: SOLR-9514
> URL: https://issues.apache.org/jira/browse/SOLR-9514
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>
> The current command is ambiguous and has limited application. We should
> replace it with something more generic like SETREPLICAPROP
> params are
> * property
> * value
> * replicaName
> * onePerShard
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9514) replace BALANCESHARDUNIQUE command with a more generic SETREPLICAPROP command
[ https://issues.apache.org/jira/browse/SOLR-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491342#comment-15491342 ] Erick Erickson commented on SOLR-9514: -- >From an offline conversation: Besides the background of why BALANCESHARDUNIQUE, the purpose of prefixing custom properties (as opposed to properties like node_name or base_url) is to keep users from overwriting important properties. If we have some kind of list of "reserved" properties we run into maintenance issues when we add property N+1. At least that was the original reasoning, whether it was _good_ reasoning or not is TBD. > replace BALANCESHARDUNIQUE command with a more generic SETREPLICAPROP command > - > > Key: SOLR-9514 > URL: https://issues.apache.org/jira/browse/SOLR-9514 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul > > The current command is ambiguous and has limited application. We should > replace it with something more generic like SETREPLICAPROP > params are > * property > * value > * replicaName > * onePerShard -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
