[jira] [Updated] (SOLR-9893) EasyMock/Mockito no longer works with Java 9 b148+
[ https://issues.apache.org/jira/browse/SOLR-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-9893: -- Affects Version/s: (was: 6.x) Fix Version/s: (was: 6.x) > EasyMock/Mockito no longer works with Java 9 b148+ > -- > > Key: SOLR-9893 > URL: https://issues.apache.org/jira/browse/SOLR-9893 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Affects Versions: master (7.0) >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Labels: Java9 > Fix For: 6.4, master (7.0) > > Attachments: SOLR-9893.patch, SOLR-9893.patch > > > EasyMock does not work anymore with latest Java 9, because it uses cglib > behind that is trying to access a protected method inside the runtime using > setAccessible. This is no longer allowed by Java 9. > Actually this is really stupid. Instead of forcefully making the protected > defineClass method available to the outside, it is much more correct to just > subclass ClassLoader (like the Lucene expressions module does). > I tried updating to easymock/mockito, but all that does not work, approx 25 > tests fail. The only way is to disable all Mocking tests in Java 9. The > underlying issue in cglib is still not solved, master's code is here: > https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 > As we use an old stone-aged version of mockito (1.x), a fix is not expected > to happen, although cglib might fix this! > What should we do? This stupid issue prevents us from testing Java 9 with > Solr completely! -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9893) EasyMock/Mockito no longer works with Java 9 b148+
[ https://issues.apache.org/jira/browse/SOLR-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-9893: Labels: Java9 (was: ) > EasyMock/Mockito no longer works with Java 9 b148+ > -- > > Key: SOLR-9893 > URL: https://issues.apache.org/jira/browse/SOLR-9893 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Affects Versions: 6.x, master (7.0) >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Labels: Java9 > Fix For: 6.4, 6.x, master (7.0) > > Attachments: SOLR-9893.patch, SOLR-9893.patch > > > EasyMock does not work anymore with latest Java 9, because it uses cglib > behind that is trying to access a protected method inside the runtime using > setAccessible. This is no longer allowed by Java 9. > Actually this is really stupid. Instead of forcefully making the protected > defineClass method available to the outside, it is much more correct to just > subclass ClassLoader (like the Lucene expressions module does). > I tried updating to easymock/mockito, but all that does not work, approx 25 > tests fail. The only way is to disable all Mocking tests in Java 9. The > underlying issue in cglib is still not solved, master's code is here: > https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 > As we use an old stone-aged version of mockito (1.x), a fix is not expected > to happen, although cglib might fix this! > What should we do? This stupid issue prevents us from testing Java 9 with > Solr completely! -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9893) EasyMock/Mockito no longer works with Java 9 b148+
[ https://issues.apache.org/jira/browse/SOLR-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-9893: Fix Version/s: 6.4 master (7.0) 6.x > EasyMock/Mockito no longer works with Java 9 b148+ > -- > > Key: SOLR-9893 > URL: https://issues.apache.org/jira/browse/SOLR-9893 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Affects Versions: 6.x, master (7.0) >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 6.x, master (7.0), 6.4 > > Attachments: SOLR-9893.patch, SOLR-9893.patch > > > EasyMock does not work anymore with latest Java 9, because it uses cglib > behind that is trying to access a protected method inside the runtime using > setAccessible. This is no longer allowed by Java 9. > Actually this is really stupid. Instead of forcefully making the protected > defineClass method available to the outside, it is much more correct to just > subclass ClassLoader (like the Lucene expressions module does). > I tried updating to easymock/mockito, but all that does not work, approx 25 > tests fail. The only way is to disable all Mocking tests in Java 9. The > underlying issue in cglib is still not solved, master's code is here: > https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 > As we use an old stone-aged version of mockito (1.x), a fix is not expected > to happen, although cglib might fix this! > What should we do? This stupid issue prevents us from testing Java 9 with > Solr completely! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9893) EasyMock/Mockito no longer works with Java 9 b148+
[ https://issues.apache.org/jira/browse/SOLR-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-9893: Attachment: (was: SOLR-9893-Mockito-update.patch) > EasyMock/Mockito no longer works with Java 9 b148+ > -- > > Key: SOLR-9893 > URL: https://issues.apache.org/jira/browse/SOLR-9893 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Affects Versions: 6.x, master (7.0) >Reporter: Uwe Schindler >Priority: Blocker > Attachments: SOLR-9893.patch, SOLR-9893.patch > > > EasyMock does not work anymore with latest Java 9, because it uses cglib > behind that is trying to access a protected method inside the runtime using > setAccessible. This is no longer allowed by Java 9. > Actually this is really stupid. Instead of forcefully making the protected > defineClass method available to the outside, it is much more correct to just > subclass ClassLoader (like the Lucene expressions module does). > I tried updating to easymock/mockito, but all that does not work, approx 25 > tests fail. The only way is to disable all Mocking tests in Java 9. The > underlying issue in cglib is still not solved, master's code is here: > https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 > As we use an old stone-aged version of mockito (1.x), a fix is not expected > to happen, although cglib might fix this! > What should we do? This stupid issue prevents us from testing Java 9 with > Solr completely! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9893) EasyMock/Mockito no longer works with Java 9 b148+
[ https://issues.apache.org/jira/browse/SOLR-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-9893: Attachment: SOLR-9893.patch Final patch with all licenses corrected and SHA1 sums. I will commit this in a moment and update Policeman Jenkins to user Java 9 build 151. > EasyMock/Mockito no longer works with Java 9 b148+ > -- > > Key: SOLR-9893 > URL: https://issues.apache.org/jira/browse/SOLR-9893 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Affects Versions: 6.x, master (7.0) >Reporter: Uwe Schindler >Priority: Blocker > Attachments: SOLR-9893.patch, SOLR-9893.patch > > > EasyMock does not work anymore with latest Java 9, because it uses cglib > behind that is trying to access a protected method inside the runtime using > setAccessible. This is no longer allowed by Java 9. > Actually this is really stupid. Instead of forcefully making the protected > defineClass method available to the outside, it is much more correct to just > subclass ClassLoader (like the Lucene expressions module does). > I tried updating to easymock/mockito, but all that does not work, approx 25 > tests fail. The only way is to disable all Mocking tests in Java 9. The > underlying issue in cglib is still not solved, master's code is here: > https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 > As we use an old stone-aged version of mockito (1.x), a fix is not expected > to happen, although cglib might fix this! > What should we do? This stupid issue prevents us from testing Java 9 with > Solr completely! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9893) EasyMock/Mockito no longer works with Java 9 b148+
[ https://issues.apache.org/jira/browse/SOLR-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-9893: Attachment: SOLR-9893.patch Here is a patch that makes all of Solr working with Java 9: - Update Mockito to 2.6.2 (that is compatible to Java 9, because it uses ByteBuddy). - Disable all tests that use EasyMock. I will open a separate issue to do the migration away from IMHO "no longer maintained" EasyMock. There are scripts to do this more or less automatically. I will further update the patch and add missing sha1-sums and license files. > EasyMock/Mockito no longer works with Java 9 b148+ > -- > > Key: SOLR-9893 > URL: https://issues.apache.org/jira/browse/SOLR-9893 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Affects Versions: 6.x, master (7.0) >Reporter: Uwe Schindler >Priority: Blocker > Attachments: SOLR-9893-Mockito-update.patch, SOLR-9893.patch > > > EasyMock does not work anymore with latest Java 9, because it uses cglib > behind that is trying to access a protected method inside the runtime using > setAccessible. This is no longer allowed by Java 9. > Actually this is really stupid. Instead of forcefully making the protected > defineClass method available to the outside, it is much more correct to just > subclass ClassLoader (like the Lucene expressions module does). > I tried updating to easymock/mockito, but all that does not work, approx 25 > tests fail. The only way is to disable all Mocking tests in Java 9. The > underlying issue in cglib is still not solved, master's code is here: > https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 > As we use an old stone-aged version of mockito (1.x), a fix is not expected > to happen, although cglib might fix this! > What should we do? This stupid issue prevents us from testing Java 9 with > Solr completely! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9893) EasyMock/Mockito no longer works with Java 9 b148+
[ https://issues.apache.org/jira/browse/SOLR-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-9893: Attachment: SOLR-9893-Mockito-update.patch Here is the patch for the Mockito Update to be Java 9 compatible (Thanks to Rafael Winterhalter for fixing Bytebuddy). > EasyMock/Mockito no longer works with Java 9 b148+ > -- > > Key: SOLR-9893 > URL: https://issues.apache.org/jira/browse/SOLR-9893 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Affects Versions: 6.x, master (7.0) >Reporter: Uwe Schindler >Priority: Blocker > Attachments: SOLR-9893-Mockito-update.patch > > > EasyMock does not work anymore with latest Java 9, because it uses cglib > behind that is trying to access a protected method inside the runtime using > setAccessible. This is no longer allowed by Java 9. > Actually this is really stupid. Instead of forcefully making the protected > defineClass method available to the outside, it is much more correct to just > subclass ClassLoader (like the Lucene expressions module does). > I tried updating to easymock/mockito, but all that does not work, approx 25 > tests fail. The only way is to disable all Mocking tests in Java 9. The > underlying issue in cglib is still not solved, master's code is here: > https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 > As we use an old stone-aged version of mockito (1.x), a fix is not expected > to happen, although cglib might fix this! > What should we do? This stupid issue prevents us from testing Java 9 with > Solr completely! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9893) EasyMock/Mockito no longer works with Java 9 b148+
[ https://issues.apache.org/jira/browse/SOLR-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-9893: Priority: Blocker (was: Critical) > EasyMock/Mockito no longer works with Java 9 b148+ > -- > > Key: SOLR-9893 > URL: https://issues.apache.org/jira/browse/SOLR-9893 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Affects Versions: 6.x, master (7.0) >Reporter: Uwe Schindler >Priority: Blocker > > EasyMock does not work anymore with latest Java 9, because it uses cglib > behind that is trying to access a protected method inside the runtime using > setAccessible. This is no longer allowed by Java 9. > Actually this is really stupid. Instead of forcefully making the protected > defineClass method available to the outside, it is much more correct to just > subclass ClassLoader (like the Lucene expressions module does). > I tried updating to easymock/mockito, but all that does not work, approx 25 > tests fail. The only way is to disable all Mocking tests in Java 9. The > underlying issue in cglib is still not solved, master's code is here: > https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 > As we use an old stone-aged version of mockito (1.x), a fix is not expected > to happen, although cglib might fix this! > What should we do? This stupid issue prevents us from testing Java 9 with > Solr completely! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9893) EasyMock/Mockito no longer works with Java 9 b148+
[ https://issues.apache.org/jira/browse/SOLR-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-9893: Description: EasyMock does not work anymore with latest Java 9, because it uses cglib behind that is trying to access a protected method inside the runtime using setAccessible. This is no longer allowed by Java 9. Actually this is really stupid. Instead of forcefully making the protected defineClass method available to the outside, it is much more correct to just subclass ClassLoader (like the Lucene expressions module does). I tried updating to easymock/mockito, but all that does not work, approx 25 tests fail. The only way is to disable all Mocking tests in Java 9. The underlying issue in cglib is still not solved, master's code is here: https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 As we use an old stone-aged version of mockito (1.x), a fix is not expected to happen, although cglib might fix this! What should we do? This stupid issue prevents us from testing Java 9 with Solr completely! was: EasyMock does not work anymore with latest Java 9, because it uses cglib behind that is trying to access a protected method inside the runtime using setAccessible. This is no longer allowed by Java 9. Actually this is really stupid. Instead of forcefully making the protected defineClass method available to the outside, it is much more correct to just subclass ClassLoader (like the Lucene expressions module does). I tried updating to easymock/mockito, but all that does not work, approx 25 tests fail. The only way is to disable all Mocking tests in Java 9. The underlying issue in cglib is still not solved, master's code is here: https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 As we use an old version ock mockito (1.x), a fix is not expected to happen, although cglib might fix this! What should we do? This stupid issue prevents us from testing Java 9 with Solr completely! > EasyMock/Mockito no longer works with Java 9 b148+ > -- > > Key: SOLR-9893 > URL: https://issues.apache.org/jira/browse/SOLR-9893 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Affects Versions: 6.x, master (7.0) >Reporter: Uwe Schindler >Priority: Critical > > EasyMock does not work anymore with latest Java 9, because it uses cglib > behind that is trying to access a protected method inside the runtime using > setAccessible. This is no longer allowed by Java 9. > Actually this is really stupid. Instead of forcefully making the protected > defineClass method available to the outside, it is much more correct to just > subclass ClassLoader (like the Lucene expressions module does). > I tried updating to easymock/mockito, but all that does not work, approx 25 > tests fail. The only way is to disable all Mocking tests in Java 9. The > underlying issue in cglib is still not solved, master's code is here: > https://github.com/cglib/cglib/blob/master/cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java#L44-L62 > As we use an old stone-aged version of mockito (1.x), a fix is not expected > to happen, although cglib might fix this! > What should we do? This stupid issue prevents us from testing Java 9 with > Solr completely! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
