[GitHub] [lucene-solr] KoenDG commented on issue #707: Use append() when StringBuilder is being used, instead of regular concat.

2019-06-10 Thread GitBox
KoenDG commented on issue #707: Use append() when StringBuilder is being used, instead of regular concat. URL: https://github.com/apache/lucene-solr/pull/707#issuecomment-500474498 Right, push done, tests succeed locally, suggestions and entry to CHANGES.txt under lucene/ taken into

[GitHub] [lucene-solr] KoenDG commented on issue #707: Use append() when StringBuilder is being used, instead of regular concat.

2019-06-10 Thread GitBox
KoenDG commented on issue #707: Use append() when StringBuilder is being used, instead of regular concat. URL: https://github.com/apache/lucene-solr/pull/707#issuecomment-500461420 2 questions: Do I reference the one I made on the SOLR project or the one I made on the LUCENE

[GitHub] [lucene-solr] KoenDG commented on issue #707: Use append() when StringBuilder is being used, instead of regular concat.

2019-06-10 Thread GitBox
KoenDG commented on issue #707: Use append() when StringBuilder is being used, instead of regular concat. URL: https://github.com/apache/lucene-solr/pull/707#issuecomment-500350769 Alright, I'll do it again but without the test files and an entry in the CHANGES.txt file