[GitHub] [lucene-solr] dsmiley commented on issue #455: SOLR-12638

2019-04-08 Thread GitBox
dsmiley commented on issue #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#issuecomment-480806665 Another PR is fine. I attached the patch version of this to JIRA and enabled patch review. I'm looking forward to seeing this one done!

[GitHub] [lucene-solr] dsmiley commented on issue #455: SOLR-12638

2019-04-03 Thread GitBox
dsmiley commented on issue #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#issuecomment-479617469 For detecting which document got where, consider the `[shard]` doc transformer https://lucene.apache.org/solr/guide/7_7/transforming-result-documents.html >

[GitHub] [lucene-solr] dsmiley commented on issue #455: SOLR-12638

2019-04-02 Thread GitBox
dsmiley commented on issue #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#issuecomment-478960957 Could the necessary parts of sharded-block-schema.xml be folded into schema-nest.xml (thus one less schema) or do you view them as too dissimilar? Can you please

[GitHub] [lucene-solr] dsmiley commented on issue #455: SOLR-12638

2019-03-26 Thread GitBox
dsmiley commented on issue #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#issuecomment-476854467 * The change to `DocTermOrds` appears to be erroneous related to getting up to date with master. Same for `the-terms-component.adoc` * AddUpdateCommand.getHashableId