gerlowskija commented on issue #681: Fix SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/681#issuecomment-501317771 This looks good to me, but I'm reluctant to merge until Noble's had a chance to re-review and clear his -1. He also has more context on this stuff so I'd prefer to give him the last word. I'll ping him in JIRA, and see if he has time to take another look. If not, I'll come back and finalize this soon.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org