[GitHub] [lucene-solr] iverase edited a comment on issue #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality

2019-06-24 Thread GitBox
iverase edited a comment on issue #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality URL: https://github.com/apache/lucene-solr/pull/730#issuecomment-505284364 Tests trigger the new approach but it is true not as often as they should. I have added a new test

[GitHub] [lucene-solr] iverase edited a comment on issue #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality

2019-06-21 Thread GitBox
iverase edited a comment on issue #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality URL: https://github.com/apache/lucene-solr/pull/730#issuecomment-504405935 I think the calculation was incorrect, we need to consider the runLen compression, which basically

[GitHub] [lucene-solr] iverase edited a comment on issue #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality

2019-06-21 Thread GitBox
iverase edited a comment on issue #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality URL: https://github.com/apache/lucene-solr/pull/730#issuecomment-504405935 I think the calculation was incorrect, we need to consider the runLen compression, which basically

[GitHub] [lucene-solr] iverase edited a comment on issue #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality

2019-06-21 Thread GitBox
iverase edited a comment on issue #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality URL: https://github.com/apache/lucene-solr/pull/730#issuecomment-504378432 I had a look in how good is the formula to decide to use this optimisation and results are very

[GitHub] [lucene-solr] iverase edited a comment on issue #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality

2019-06-21 Thread GitBox
iverase edited a comment on issue #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality URL: https://github.com/apache/lucene-solr/pull/730#issuecomment-504378432 I had a look in how good is the formula to decide to use this optimisation and results are very