martin-g commented on a change in pull request #707: Use append() when
StringBuilder is being used, instead of regular concat.
URL: https://github.com/apache/lucene-solr/pull/707#discussion_r291890548
##########
File path:
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/tokenattributes/PartOfSpeechAttributeImpl.java
##########
@@ -80,7 +80,7 @@ private String displayMorphemes(Morpheme[] morphemes) {
if (builder.length() > 0) {
builder.append("+");
}
- builder.append(morpheme.surfaceForm + "/" + morpheme.posTag.name() + "("
+ morpheme.posTag.description() + ")");
+
builder.append(morpheme.surfaceForm).append("/").append(morpheme.posTag.name()).append("(").append(morpheme.posTag.description()).append(")");
Review comment:
If you want to (micro)optimize even further you can use `#append(char)`
instead of `#append(String)` for single characters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
